From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0A5E7717D for ; Fri, 13 Dec 2024 15:07:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D89A96B0088; Fri, 13 Dec 2024 10:07:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D12806B0089; Fri, 13 Dec 2024 10:07:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8B896B008A; Fri, 13 Dec 2024 10:07:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 985A66B0088 for ; Fri, 13 Dec 2024 10:07:11 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50100A1001 for ; Fri, 13 Dec 2024 15:07:11 +0000 (UTC) X-FDA: 82890263358.11.AA86811 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf30.hostedemail.com (Postfix) with ESMTP id 4BDCA80015 for ; Fri, 13 Dec 2024 15:06:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Y9ex9FRy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of kaleshsingh@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=kaleshsingh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734102417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fOK+EabcLART//wNWq/2bx90ZPHXhDUCyx5nSPtp/mo=; b=Flp/D5myJ6wmJ59NETOsf5QtueaRHyguD9D8FfenoPsOXUwhbEcXfsR+NySxBNpkyEn4HZ 3BYfE5Ub+RyYdVgB4pEQmYOa7k/72jM5/tk2IbrnGtJ5kjtHr30x/ri2znk2GK3QSt8lZZ /ukthBm5lVLZRRkdk0klgBnoCWR6i5U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734102417; a=rsa-sha256; cv=none; b=rQzg16h0R+629R1PIuJCLJ9SqZ4f0dlinm378LohLm0GfPWu/QYxA2hbiGNNmSwCDju70K MmpjiAf0+QU0Ahtv5iu3SgxpiClKQIrtinatbZzC9ibnSbGdJvMnboBt4AfemoCS5lU/v+ IU9f3AKPuBz4Pr5TflPfQkHTvWG1Fao= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Y9ex9FRy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of kaleshsingh@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=kaleshsingh@google.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21625b4f978so125675ad.0 for ; Fri, 13 Dec 2024 07:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734102428; x=1734707228; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fOK+EabcLART//wNWq/2bx90ZPHXhDUCyx5nSPtp/mo=; b=Y9ex9FRyXqfA4S4Oezyr2nrUlGIpgEOiHY0WURUEJ9qDTGlgsLGOaDcCEWZNt2hH+b F6fnosmy4jK4fpMX0FpLApPBBR4VHnsLbvspaOOYHHQ/kjeTDlamIoAttkep7oZR9LBb 2sP8n6cftkuAdVH5mo1RsbxQUQV7nVnd/34jA8uGFXuGTAtT59c5YCbPLqxiamljTNyB Tyl6H//3FwA1NY2dJteCKzKtsbvVfouSSYnGZvZH4jnRW4lCbTVTxf4nQ7uA8XlbA1cC 6cSAYTzUllep51nUnJN1tZcNdoYAfOaYf/O06QnNWWdp4SjN/mZVOVz+iE0A2CkMYLm8 wieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734102428; x=1734707228; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fOK+EabcLART//wNWq/2bx90ZPHXhDUCyx5nSPtp/mo=; b=F9cmYmuVf3VDnOb5TT0mkpBqYEK3bBxhWocoil341rTQP6wZ2KUGiO8C9/vFdjwQxA 03+YYdq+zn+CW4y9ZgErVB1Ako7Yk8kHasIg74m/hIYNfShdjUj1/eE8rkXRJ2IJ708D uLKP+z+JU3Ffh8Jn9exQcdb+6xGEbLDWH2Lp0gjQbbADJGF6bzoYf6FFn/R/ojEtrmnx 0qI2Lc8qFSvPRYwodO+03pQSR2UWG0WUnWs4ZQt9LcuV8OETLZS51DZ3B703nqiAbBvo NGuPRGWUhackXauU0phZ59dVHPSF4AwkJTlMwxXcUIEJ2f+gizB+uATaZQT6usALornI iXhQ== X-Forwarded-Encrypted: i=1; AJvYcCWn3DvXCDNZwlbeHfUz8YIhdildWWfRH+HUX+1szTbaX1qUNOyE+FYJSQ7ng7NorECAaNOblSbD3w==@kvack.org X-Gm-Message-State: AOJu0Yxww/lyF1Oq6Xox8oTxa1TUQtswbPCqsepZ/FJnAw6zME4CJ9GK WfemN5cjEg0kwOBe59EpBKnxncrmxbh+kiEr66+18XUPbjDB1k5fzgQFb8Lg2686ozDz5QNend2 YZrLEBAPxGb7GA4yYqYuuFzKwXrG/CMqndoad X-Gm-Gg: ASbGncvM72tvFOrybaCVoiEdhAbTLZAldKUF4e3ETZ4eYvRLEI3THe9YjJiFIzw41tt nZW9Gr8e29v8bLIpxc/lAFL9W2RJsi/BkQc+04w== X-Google-Smtp-Source: AGHT+IEFkkLrbUVuE/cQvOQQfUpzDKI51xwKn+aUa2wuLKN/e2/s4qkcLn7DHuV9QVymd56Ir4cx8C6BN8kJhz8qssU= X-Received: by 2002:a17:902:da82:b0:215:44af:313b with SMTP id d9443c01a7336-21891d3ead6mr2786695ad.0.1734102427757; Fri, 13 Dec 2024 07:07:07 -0800 (PST) MIME-Version: 1.0 References: <20241211232754.1583023-1-kaleshsingh@google.com> <1818e2ea-f170-4a9c-8d93-2a24f2755a41@lucifer.local> <20241212173609.afd41d1dffbefe0d731ed4ed@linux-foundation.org> <695eabb8-ba28-4031-bc4d-66dc4f1d096f@lucifer.local> In-Reply-To: <695eabb8-ba28-4031-bc4d-66dc4f1d096f@lucifer.local> From: Kalesh Singh Date: Fri, 13 Dec 2024 10:06:55 -0500 Message-ID: Subject: Re: [PATCH mm-unstable v2 00/16] mm: Introduce arch_mmap_hint() To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R. Howlett" , vbabka@suse.cz, yang@os.amperecomputing.com, riel@surriel.com, david@redhat.com, minchan@kernel.org, jyescas@google.com, linux@armlinux.org.uk, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, davem@davemloft.net, andreas@gaisler.com, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, bhelgaas@google.com, jason.andryuk@amd.com, leitao@debian.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com, android-mm@google.com, Jann Horn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: teghgk49qhz4boiuhi4u8s6fczmcbmda X-Rspamd-Queue-Id: 4BDCA80015 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734102380-903715 X-HE-Meta: U2FsdGVkX1+Ld95BTfJtxvH4qgb48qu6SGGO8705EA4J35aM4IEbaK9Vll5LclMwX5IAkqRZrSd3oC2z4YQxOS/scJwduVQfE+HzLLTfS0FD7L0vn6Acb/D5oc/qHPgQCPObPRY+2IksTbAyC2ZmAekQxC/gcx1GQYFAJLuijX5JXCT6PhlzokP+s8VSMeFfRWPWvjyMnf5X3Qxig+zRXrWWx5IZ1c0VKjzy4pRMHl6CNXSX1WlkThTL6uRDpu6QEoawEA2dhgRX/hBHV5rGszYOaeh4UktyIulrHSs8zDoIPSUpZbvhcdp2qi+QhCwFbMyU1VsEgaRHYhjg/gtDPprVX5Tm6aQeUGZx2KSkSxDiQA7ZdU4xeqn2fmQaXh+IDVfcBgaBfROCMo3lxrg/jf39fglH0T08YRVULO8CeuzrcDDWnk6bVulx5+pr7VJARfYlIt6SnF93kuknRG/1pWo/gwwlKW6Lc4ELG9QvUiY/jZkwsle+G2MNZPWkBrGhFnLEs9cmf0oOBDCcOREIiJrpvv4fW/HcmTXT57vWcy5z5dlekkMniW8jOZKqgtbIVztzxGOKBsXYHxAtuSbDjUc94cMjn500wQ3hO4DaoTicHpKEDLC1iMs1lT3vI2Wzi3E3SgYxezWvnrMvFWoN73LjDn46QRHjAvmAfHAllSm6OBuuLYUkuGuD3+pHxaILoJSAEPLHd3bXyTRepX0HumiRtfsIRrbgIeBatRYiLZvHxb4yG8bdnzpXnU6aj9UAOUSqA5/Gz5B8cDzX5tiQ6wz6UYBeOi8PMiHmXFJMZ3xbLOjS/VcjyMfsxw2DvZuAmtIwSItC16Ef3Xiy2g9rKH3LhVlQvfJMqv7n3pGTwwE21JjQkFy8EWenKr2khbHVQEbAi18kevz2jr86WMYnj4KPO4Sc1LhLF9qTCbWf9ih8GJWGmdjCQIKbZEhQV/N7K+T2iyiM9UqpIn6DM1X VFixGzoj bRVQ+j0QYzb0PgqX8/dj3c2AAWfHmOF7uVyHKp5cY4Ksv9kdo4/mvuMIgKvTcmZdOlDtPXHWxh8wBJm1dMQeRSBjYX1uFT1pxp+iBkBjzv1XMcIgVbkL6965coswY5az27xPhLpjBxavV//mufrU64KKl8s5t+9gPN1jwJCw15x8rjQD+y7E80hLqNEwyNgUjlw50Q/Y9CO6GeNhAXGEgdYMmxzTs4kcCWTq21vqydjCVKqQH/BCeQHs9TICXmphV27OiU7JqD6ZpXsE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.346999, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 4:00=E2=80=AFAM Lorenzo Stoakes wrote: > > On Thu, Dec 12, 2024 at 05:36:09PM -0800, Andrew Morton wrote: > > On Thu, 12 Dec 2024 22:51:34 +0000 Lorenzo Stoakes wrote: > > > > > You've fundamentally violated kernel process and etiquette. I'd be mo= re > > > forgiving, but this is at v2 and you've not cc'd KEY people. Twice. T= his is > > > totally unacceptable. See [0] if you are unsure of how to do so. > > > > This feels excessive to me. linux-mm averages a mere 140 mesages/day > > and it seems reasonable to assume that key people are spending their 5 > > minutes to scroll through the email subjects. > > In practice we did all miss it, and I don't think it's unreasonable to as= k > people to run get_maintainers.pl to avoid this. > > In any case, I truly do think this series works better as RFC, I mean Lia= m > has already voiced the kind of disagreements I share with it, and we need > to rethink how to approach it in general. > > So if this is simply sent as RFC with the correct cc's (and ideally with > some review feedback applied - a better cover letter, etc.) then it makes > everything easier. > > As mentioned the timing is unfortunate here, this is a series we really > want to make sure is properly reviewed before any chance of merge so agai= n > this points to RFC being the way forward. Hi everyone, Sorry for the delayed response -- I was traveling and didn=E2=80=99t have access to email. Thank you for the feedback. I realize I missed some key reviewers in the CC list for this patch. When I ran get_maintainer.pl, it returned a large list of recipients. To avoid over-CC=E2=80=99ing people (which has been an issue for me in the past), I tried to trim it down to maintainers and a few others I thought would be interested. Clearly, I got it wrong and missed some key folks. That was not my intention, and I=E2=80=99ll make sure to fix it when I resend the patch as an RFC. On the technical side, Liam is right that the copy-pasted arch code has inconsistencies (missing checks, order of checks, ...). I agree there=E2=80=99s room for further consolidation. I=E2=80=99ll take another s= tab at it and resend it as an RFC with an updated cover letter, as Lorenzo and others suggested. Thanks, Kalesh