From: Vernon Yang <vernon2gm@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, david@kernel.org,
lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Vernon Yang <yanglincheng@kylinos.cn>
Subject: Re: [PATCH mm-new v5 2/5] mm: khugepaged: refine scan progress number
Date: Fri, 23 Jan 2026 23:29:08 +0800 [thread overview]
Message-ID: <CACZaFFPx3b9VH9GLoXY1HrMaLs9OtJ+oENfobAvoyaQxAhCsQg@mail.gmail.com> (raw)
In-Reply-To: <aXORiA7_Oy60MSDR@casper.infradead.org>
On Fri, Jan 23, 2026 at 11:19 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Fri, Jan 23, 2026 at 04:22:29PM +0800, Vernon Yang wrote:
> > + if (cur_progress) {
> > + unsigned long idx = xas_get_index(&xas) - start;
>
> I agree with Dev. This is less readable than:
>
> unsigned long idx = xas.xa_index - start;
LGTM, I will use "xas->xa_index" directly in the next version. Thanks!
next prev parent reply other threads:[~2026-01-23 15:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:22 [PATCH mm-new v5 0/5] Improve khugepaged scan logic Vernon Yang
2026-01-23 8:22 ` [PATCH mm-new v5 1/5] mm: khugepaged: add trace_mm_khugepaged_scan event Vernon Yang
2026-01-23 10:25 ` Dev Jain
2026-01-23 8:22 ` [PATCH mm-new v5 2/5] mm: khugepaged: refine scan progress number Vernon Yang
2026-01-23 10:46 ` Dev Jain
2026-01-23 15:25 ` Vernon Yang
2026-01-23 15:19 ` Matthew Wilcox
2026-01-23 15:29 ` Vernon Yang [this message]
2026-01-28 8:29 ` Dev Jain
2026-01-28 14:34 ` Vernon Yang
2026-01-29 5:35 ` Dev Jain
2026-01-29 7:59 ` Vernon Yang
2026-01-29 8:32 ` Dev Jain
2026-01-29 12:24 ` Vernon Yang
2026-01-29 12:46 ` Dev Jain
2026-01-29 9:18 ` Lance Yang
2026-01-29 12:28 ` Vernon Yang
2026-01-23 8:22 ` [PATCH mm-new v5 3/5] mm: add folio_test_lazyfree helper Vernon Yang
2026-01-23 10:54 ` Dev Jain
2026-01-26 1:52 ` Barry Song
2026-01-23 8:22 ` [PATCH mm-new v5 4/5] mm: khugepaged: skip lazy-free folios Vernon Yang
2026-01-23 9:09 ` Lance Yang
2026-01-23 15:08 ` Vernon Yang
2026-01-23 16:32 ` Lance Yang
2026-01-24 3:22 ` Vernon Yang
2026-01-24 6:48 ` Dev Jain
2026-01-26 2:06 ` Barry Song
2026-01-23 8:22 ` [PATCH mm-new v5 5/5] mm: khugepaged: set to next mm direct when mm has MMF_DISABLE_THP_COMPLETELY Vernon Yang
2026-01-23 12:40 ` Dev Jain
2026-01-23 15:32 ` Vernon Yang
2026-01-26 2:18 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZaFFPx3b9VH9GLoXY1HrMaLs9OtJ+oENfobAvoyaQxAhCsQg@mail.gmail.com \
--to=vernon2gm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=willy@infradead.org \
--cc=yanglincheng@kylinos.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox