From: Vernon Yang <vernon2gm@gmail.com>
To: Lance Yang <lance.yang@linux.dev>
Cc: baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com,
ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org,
richard.weiyang@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Vernon Yang <yanglincheng@kylinos.cn>,
akpm@linux-foundation.org, david@kernel.org
Subject: Re: [PATCH v3 4/6] mm: add folio_is_lazyfree helper
Date: Mon, 5 Jan 2026 10:09:52 +0800 [thread overview]
Message-ID: <CACZaFFNyqMD7oJv1Jqf4udFarozbQ=TPkaSMt_4Vmrq9rhoHxg@mail.gmail.com> (raw)
In-Reply-To: <b79c4a9b-2d19-442c-969a-7479a8ed9dc7@linux.dev>
On Sun, Jan 4, 2026 at 7:42 PM Lance Yang <lance.yang@linux.dev> wrote:
>
> On 2026/1/4 13:41, Vernon Yang wrote:
> > Add folio_is_lazyfree() function to identify lazy-free folios to improve
> > code readability.
> >
> > Signed-off-by: Vernon Yang <yanglincheng@kylinos.cn>
> > ---
> > include/linux/mm_inline.h | 5 +++++
> > mm/rmap.c | 4 ++--
> > mm/vmscan.c | 5 ++---
> > 3 files changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
> > index fa2d6ba811b5..65a4ae52d915 100644
> > --- a/include/linux/mm_inline.h
> > +++ b/include/linux/mm_inline.h
> > @@ -35,6 +35,11 @@ static inline int page_is_file_lru(struct page *page)
> > return folio_is_file_lru(page_folio(page));
> > }
> >
> > +static inline int folio_is_lazyfree(const struct folio *folio)
> > +{
> > + return folio_test_anon(folio) && !folio_test_swapbacked(folio);
> > +}
> > +
> > static __always_inline void __update_lru_size(struct lruvec *lruvec,
> > enum lru_list lru, enum zone_type zid,
> > long nr_pages)
> > diff --git a/mm/rmap.c b/mm/rmap.c
> > index f955f02d570e..7241a3fa8574 100644
> > --- a/mm/rmap.c
> > +++ b/mm/rmap.c
> > @@ -1838,7 +1838,7 @@ static inline unsigned int folio_unmap_pte_batch(struct folio *folio,
> > max_nr = (end_addr - addr) >> PAGE_SHIFT;
> >
> > /* We only support lazyfree batching for now ... */
> > - if (!folio_test_anon(folio) || folio_test_swapbacked(folio))
> > + if (!folio_is_lazyfree(folio))
>
> Please rebase against mm-new. Commit[1] already supports file folios
> batching in folio_unmap_pte_batch()
Ok, thanks! I will rebase in the next version.
> + /* We only support lazyfree or file folios batching for now ... */
> + if (folio_test_anon(folio) && folio_test_swapbacked(folio))
>
> [1]
> https://lore.kernel.org/all/142919ac14d3cf70cba370808d85debe089df7b4.1766631066.git.baolin.wang@linux.alibaba.com/
>
> Thanks,
> Lance
>
> > return 1;
> > if (pte_unused(pte))
> > return 1;
> > @@ -1934,7 +1934,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma,
> > }
> >
> > if (!pvmw.pte) {
> > - if (folio_test_anon(folio) && !folio_test_swapbacked(folio)) {
> > + if (folio_is_lazyfree(folio)) {
> > if (unmap_huge_pmd_locked(vma, pvmw.address, pvmw.pmd, folio))
> > goto walk_done;
> > /*
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 670fe9fae5ba..f357f74b5a35 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -963,8 +963,7 @@ static void folio_check_dirty_writeback(struct folio *folio,
> > * They could be mistakenly treated as file lru. So further anon
> > * test is needed.
> > */
> > - if (!folio_is_file_lru(folio) ||
> > - (folio_test_anon(folio) && !folio_test_swapbacked(folio))) {
> > + if (!folio_is_file_lru(folio) || folio_is_lazyfree(folio)) {
> > *dirty = false;
> > *writeback = false;
> > return;
> > @@ -1501,7 +1500,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
> > }
> > }
> >
> > - if (folio_test_anon(folio) && !folio_test_swapbacked(folio)) {
> > + if (folio_is_lazyfree(folio)) {
> > /* follow __remove_mapping for reference */
> > if (!folio_ref_freeze(folio, 1))
> > goto keep_locked;
>
next prev parent reply other threads:[~2026-01-05 2:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 5:41 [PATCH v3 0/6] Improve khugepaged scan logic Vernon Yang
2026-01-04 5:41 ` [PATCH v3 1/6] mm: khugepaged: add trace_mm_khugepaged_scan event Vernon Yang
2026-01-04 5:41 ` [PATCH v3 2/6] mm: khugepaged: refine scan progress number Vernon Yang
2026-01-05 16:49 ` David Hildenbrand (Red Hat)
2026-01-06 5:55 ` Vernon Yang
2026-01-04 5:41 ` [PATCH v3 3/6] mm: khugepaged: just skip when the memory has been collapsed Vernon Yang
2026-01-04 5:41 ` [PATCH v3 4/6] mm: add folio_is_lazyfree helper Vernon Yang
2026-01-04 11:42 ` Lance Yang
2026-01-05 2:09 ` Vernon Yang [this message]
2026-01-04 5:41 ` [PATCH v3 5/6] mm: khugepaged: skip lazy-free folios at scanning Vernon Yang
2026-01-04 12:10 ` Lance Yang
2026-01-05 1:48 ` Vernon Yang
2026-01-05 2:51 ` Lance Yang
2026-01-05 3:12 ` Vernon Yang
2026-01-05 3:35 ` Lance Yang
2026-01-05 12:30 ` Vernon Yang
2026-01-06 10:33 ` Barry Song
2026-01-07 8:36 ` Vernon Yang
2026-01-04 5:41 ` [PATCH v3 6/6] mm: khugepaged: set to next mm direct when mm has MMF_DISABLE_THP_COMPLETELY Vernon Yang
2026-01-04 12:20 ` Lance Yang
2026-01-05 0:31 ` Wei Yang
2026-01-05 2:09 ` Lance Yang
2026-01-05 2:06 ` Vernon Yang
2026-01-05 2:20 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZaFFNyqMD7oJv1Jqf4udFarozbQ=TPkaSMt_4Vmrq9rhoHxg@mail.gmail.com' \
--to=vernon2gm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=yanglincheng@kylinos.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox