From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30039E95A61 for ; Sat, 7 Oct 2023 12:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41BF68D0010; Sat, 7 Oct 2023 08:05:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CC2B8D0005; Sat, 7 Oct 2023 08:05:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BAE88D0010; Sat, 7 Oct 2023 08:05:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1D4798D0005 for ; Sat, 7 Oct 2023 08:05:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DD3DFC01F5 for ; Sat, 7 Oct 2023 12:04:59 +0000 (UTC) X-FDA: 81318534318.01.7EBFA2D Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 09305180022 for ; Sat, 7 Oct 2023 12:04:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GnR0uRKI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696680298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZP8LTpVBDLLcyeu4A3mcPz76KkhgS/D8yTcePuj1WMU=; b=rVNO1hs7FeVaDXLrZPC8bRO3edl3RnItPM8NFrcpFFf6JmpildufRGfUe4XLQ/W+joGIZ6 9rP5BBYQw9Pf/vfBIzgQMH7OVtEZscMUCVHlUCwLx5BPyOPH/aVtjp8zfwQH3QuWospAzr RRo9F5WddHgy/NqmI9LgKNZGYOddILA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GnR0uRKI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696680298; a=rsa-sha256; cv=none; b=WR/hsn26LJlfWfLoZ7KOEKoxhoGEVArvcPisS3L63LvA8LpmDLbMEutVduebffKWgPYc31 mBpBTVzjTzm5qQ8ldeI2u9AysuQRKIbyIqM5syw8MdUkUTAYAOXTgmehQD1URgFm9gDGOZ 1lhGAjyjZUnf99OMIVFbeyIQ0Vbf8to= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-53829312d12so8932016a12.0 for ; Sat, 07 Oct 2023 05:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696680296; x=1697285096; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZP8LTpVBDLLcyeu4A3mcPz76KkhgS/D8yTcePuj1WMU=; b=GnR0uRKIUtXuSBzZNlqGw8PqjdT9mucJVyNpWGTiqKfTYhT7ufbHxaRWmgLHzFXzzX gDtES7E+Dz0fROJ6QOqkj/2Tq83oxtpXDsQRiNXeWbFWL0JQgkHZp60xPL5Dn/O3UTTJ 62oCfsx5ep3ENS468g0y3DVh1zmIrVeT9G9d0cgbf6sI1rJjcg5AzgEjklQmQEGiWpqz qcnKVApo22dbCcHlPSP0g/nVvG6otk7k/6v8kjeWmICx8qnHeZRyNrp+7rfim8TnWAli Qy3/Vcx/3hF2t6gAMGlJZz7sh2ntxOKUWaD9yGhNlfOWxNVsLVMDL316dO/uqJEkh2re QPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696680296; x=1697285096; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZP8LTpVBDLLcyeu4A3mcPz76KkhgS/D8yTcePuj1WMU=; b=Vskvzi4ChYpI53zpfJLxawruif9qH8lR3i23u7g8zkDzp91Ur2ZyrufZCjs7cwK9az Wu+Ww0ic2MWBpFFUgxFV03Yh9T3p81qYmam34NtNMm5OIk0UZoesjijMwV/Xl4ViquQy OWsFl9EiIiXEQZCvIwZS4HKoSZnVl/rWwIKm3E9L+D+IPIhXHLQd/1DiygD2EvRs15ue 8lEyZQxrRL8PvtO8DL4NlUewkfZs/29UP/Q3kegDa123UmXi09JJSOQ2RXRaZOdxt4Kc TxWCuwnrKWRHXo2nqUhoLA8Hl/RMoVNmPOHc6Vy3t8A86DTVzuSkuULRjNihRCtS+rr4 YTJQ== X-Gm-Message-State: AOJu0YzSESX62WIu4OHkPYN7F0bMIsu5rc0O74pMFONdJoAXjxLNLPEj c8Q1N4MxCMOOCDa18GuKi9EvLZdkKx0VY0Va/YcSBEwo X-Google-Smtp-Source: AGHT+IGyaugT+Xo2Bq2OhoYGX5SASkWncFbebvW1Y2JhtB3NMYJ1B822McR+Ftu/d2gCEGc0vctQGqPNCwj6eSq8Gjg= X-Received: by 2002:a17:906:4a03:b0:9b2:be2f:e31a with SMTP id w3-20020a1709064a0300b009b2be2fe31amr8668474eju.31.1696680296183; Sat, 07 Oct 2023 05:04:56 -0700 (PDT) MIME-Version: 1.0 References: <20230911133852.2545-1-zhiguangni01@gmail.com> In-Reply-To: <20230911133852.2545-1-zhiguangni01@gmail.com> From: Liam Ni Date: Sat, 7 Oct 2023 20:04:45 +0800 Message-ID: Subject: Re: [PATCH V4] NUMA:Improve the efficiency of calculating pages loss To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org Cc: dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: z55r5q8npwaphtygs6hcgeiqnuoi3xpf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 09305180022 X-HE-Tag: 1696680297-808792 X-HE-Meta: U2FsdGVkX18x6B19cZaOtsd57ZPfgOlP3XC078Pcv1e77A/u7VQXat/ceetBxjvllBTrGCROQwZYg2kx9+cFwmMI1M0hAeGNzcE4Lp6jHoVXoSOQy6orXj1dLX/+Aec2iFhuvPp6dWKm/3njfu4g8FR/ZWozJ7vGV5Wmf3GClu4pKejTAaoP9epi2RtwqF0vuT8sm7SEysVmyBzp6XAFvyjBKDYg1eBPO2dGmgEML7bnbIHoHyi3gbkXqbQbVBqXHYbzY1oCNj+nRwJrKMl3FkRZ9lbpGBZPUG+DqV74l3ZfNUDIlOGZf/g7IxfzdpupkFRTUCbfkFXcLYJsH3SuMkLLE/W6aXJguizd6+6XiDxW7TmuUxjK/HztxEyWuRCLz4PQb7yD6zhmS10ix4f9vA27NBf8uZcJe9CZYsrALOv2PaJUY/hwo5VCOj8UI90QJD6YSNknR6WoTKtI0eWFuJRxecJlRf18qdwnierk3x8J2ucRJ3HRaN7b5c86NDdEWGyhNcB9GsQdqa7o7VRFzAV5a3hLdpmmHLFuhtvZJN+8r0i/+SSFC02lrhRYvGzS8hN+bEB0EsHESgbtUttNYDOd03/alogDuWl9/gQrkkj8HpsvLMNcouzDEHw4JDJ2kcgQpwp5qbFP3MH0PLMH5BUBJmXEX8FLpkhygmEWP8r7AsPPs9FRkpzRJMQQdsQg2rXAmk6fwkW1ckJ/iwkvf8MHdrMNCheAEpyAPB22nDXTSmls6jHUg75a2VAgW+RZCNXu47XwKmMqc3GxRgKexIXpYHCORCuK2kFJDE6cx4tygYjejOx2a2iJKziPOVK58/LEXLPm1sEb3vnVFlVdyWQjjNMNtndEDNRyRuGTbuVAQnr9j+Yy+R3a3cz14TjANoVXsQF9fnTtGOeKXZljpQniDtPiwdcYE75zLZni/xB/yXRNkB0f9l/QoaRsiGNdl2BAFyC/o8r9dpILUIG XtbSQ9J0 oA+YujlDtZEz8zyrf+1A05tilvsiYr4KsQKKP33uHCb7cFYADIjE2gFTECi53Olc+fXYimcpcPVLqC6Hg1/o7Q6SiKh/lfgT9UCVx6SZA7mZZS5soipMPKgnS6xWi0ZFb1y7h6g/fIKn9hvXiYBV95pyAm59JKi+b5Uie4iQuC9pNpxDlGRmUPtFQQEAbbDp7lqRmEGIT/XtF28dXm+hM0fnjD3dfbT3Fim4qH07u0Ezy44CpMIy0wFmV/AItvD7iJ7hRlLP7wCs9ISeQI8O0eDiP/VrpRDVZOTeRS2WW8OfI5pNEv7Xvg54+VCn8Cnf8B6mTavDuCZbI6j2gBISBkWanwIEC73o9IoocyihUKksfkSmUsAToWDuOw0u2CSTFNEKJ8AYvKJMG5otIe/IufSG5D331anyHbR/8vDoiUBAkQBT3QgyCVQTC2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Friendly Ping On Mon, 11 Sept 2023 at 21:39, Liam Ni wrote: > > Optimize the way of calculating missing pages. > > In the previous implementation, We calculate missing pages as follows: > 1. calculate numaram by traverse all the numa_meminfo's and for each of > them traverse all the regions in memblock.memory to prepare for > counting missing pages. > > 2. Traverse all the regions in memblock.memory again to get e820ram. > > 3. the missing page is (e820ram - numaram ) > > But,it's enough to count memory in =E2=80=98memblock.memory=E2=80=99 that= doesn't have > the node assigned. > > V3:https://lore.kernel.org/all/CACZJ9cUXiWxDb6hF4JFhWe7Np82k6LopVQ+_AoGFO= ccN4kjJqA@mail.gmail.com/#r > V2:https://lore.kernel.org/all/20230619075315.49114-1-zhiguangni01@gmail.= com/ > V1:https://lore.kernel.org/all/20230615142016.419570-1-zhiguangni01@gmail= .com/ > > Signed-off-by: Liam Ni > --- > arch/x86/mm/numa.c | 33 +-------------------------------- > include/linux/memblock.h | 1 + > mm/memblock.c | 21 +++++++++++++++++++++ > 3 files changed, 23 insertions(+), 32 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 2aadb2019b4f..ee5f08adfaf6 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -447,37 +447,6 @@ int __node_distance(int from, int to) > } > EXPORT_SYMBOL(__node_distance); > > -/* > - * Sanity check to catch more bad NUMA configurations (they are amazingl= y > - * common). Make sure the nodes cover all memory. > - */ > -static bool __init numa_meminfo_cover_memory(const struct numa_meminfo *= mi) > -{ > - u64 numaram, e820ram; > - int i; > - > - numaram =3D 0; > - for (i =3D 0; i < mi->nr_blks; i++) { > - u64 s =3D mi->blk[i].start >> PAGE_SHIFT; > - u64 e =3D mi->blk[i].end >> PAGE_SHIFT; > - numaram +=3D e - s; > - numaram -=3D __absent_pages_in_range(mi->blk[i].nid, s, e= ); > - if ((s64)numaram < 0) > - numaram =3D 0; > - } > - > - e820ram =3D max_pfn - absent_pages_in_range(0, max_pfn); > - > - /* We seem to lose 3 pages somewhere. Allow 1M of slack. */ > - if ((s64)(e820ram - numaram) >=3D (1 << (20 - PAGE_SHIFT))) { > - printk(KERN_ERR "NUMA: nodes only cover %LuMB of your %Lu= MB e820 RAM. Not used.\n", > - (numaram << PAGE_SHIFT) >> 20, > - (e820ram << PAGE_SHIFT) >> 20); > - return false; > - } > - return true; > -} > - > /* > * Mark all currently memblock-reserved physical memory (which covers th= e > * kernel's own memory ranges) as hot-unswappable. > @@ -583,7 +552,7 @@ static int __init numa_register_memblks(struct numa_m= eminfo *mi) > return -EINVAL; > } > } > - if (!numa_meminfo_cover_memory(mi)) > + if (!memblock_validate_numa_coverage(SZ_1M)) > return -EINVAL; > > /* Finally register nodes. */ > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 1c1072e3ca06..0c3a193ebc58 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -120,6 +120,7 @@ int memblock_physmem_add(phys_addr_t base, phys_addr_= t size); > void memblock_trim_memory(phys_addr_t align); > bool memblock_overlaps_region(struct memblock_type *type, > phys_addr_t base, phys_addr_t size); > +bool memblock_validate_numa_coverage(const u64 limit); > int memblock_mark_hotplug(phys_addr_t base, phys_addr_t size); > int memblock_clear_hotplug(phys_addr_t base, phys_addr_t size); > int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); > diff --git a/mm/memblock.c b/mm/memblock.c > index 0863222af4a4..8f61f868bec1 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -734,6 +734,27 @@ int __init_memblock memblock_add(phys_addr_t base, p= hys_addr_t size) > return memblock_add_range(&memblock.memory, base, size, MAX_NUMNO= DES, 0); > } > > +bool __init_memblock memblock_validate_numa_coverage(const u64 limit) > +{ > + unsigned long lose_pg =3D 0; > + unsigned long start_pfn, end_pfn; > + int nid, i; > + > + /* calculate lose page */ > + for_each_mem_pfn_range(i, MAX_NUMNODES, &start_pfn, &end_pfn, &ni= d) { > + if (nid =3D=3D NUMA_NO_NODE) > + lose_pg +=3D end_pfn - start_pfn; > + } > + > + if (lose_pg >=3D limit) { > + pr_err("NUMA: We lost %ld pages.\n", lose_pg); > + return false; > + } > + > + return true; > +} > + > + > /** > * memblock_isolate_range - isolate given range into disjoint memblocks > * @type: memblock type to isolate range for > -- > 2.25.1 >