From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E55DEB64D9 for ; Tue, 27 Jun 2023 13:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0279A8D0002; Tue, 27 Jun 2023 09:24:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1A1B8D0001; Tue, 27 Jun 2023 09:23:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E09728D0002; Tue, 27 Jun 2023 09:23:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D424E8D0001 for ; Tue, 27 Jun 2023 09:23:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A6272C09C2 for ; Tue, 27 Jun 2023 13:23:59 +0000 (UTC) X-FDA: 80948595798.09.68F7E9F Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf03.hostedemail.com (Postfix) with ESMTP id BFC0520021 for ; Tue, 27 Jun 2023 13:23:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ho7foCp1; spf=pass (imf03.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687872237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/JjYFWhUkMupfyA5wc877/4DODs5BAde5YzMX5S1gP8=; b=5ksMI2Mdai6JiGcZFOeTy6rOMg4e+srNTTxKwtnJWxnAKncwNyqdMyBDD6gCWU2meuXHSK hIEtVoLSK1Fqagqx9ye0g0+YVsJ71VGW4InnG19L37g5yGIXrvdCQsM3qEoLKI1RPO1mVL k8IhN8vAhYSymc7Nh857pHMvZzKyJz0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ho7foCp1; spf=pass (imf03.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687872237; a=rsa-sha256; cv=none; b=la6PIa6ORaa3rSkyISOBxTl8cyNDWTfwk7rv4sxx6VIAGHIks4WeLDtdNZV9a/CyeuQJA8 xQLWGw3MORWGURFW4oh8BYk/nSFF9meHXb8S6bNqGdxFzYl8HLUEHbj22QJ6BekK90pcpc vpf8X+7GFtd90IMH1JOtjOVTHQ0Ll/s= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-bdd069e96b5so4540346276.2 for ; Tue, 27 Jun 2023 06:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687872237; x=1690464237; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/JjYFWhUkMupfyA5wc877/4DODs5BAde5YzMX5S1gP8=; b=ho7foCp1iomzBMJUN9dgNTqgOYV6foh3PxhD42wyab2lTivFel6OtChoy2wARvAwTW zipYDhOBCN8mIHqoPsGCzD459X7nQ2yK0seUpuAeigWN82vCEioSp+r1T+TnOZc1NbK2 eK2scxkS9uuEgo7FVcQ6mwn68nEjbwJ0VyTij68U75ELIKTD5RfmZkWYjWV/oE7txY1d hA3woL1CXR1sOioU9frSebjeK7RF5tQCACjcVcyTg/DmHy/Q3XwyZC8rgC5QpobPeJE6 2Zx18Yd2gF6zilQdrAuR4Fxau7QYqfvPst97Ut56Zxh9g8YbwgHm0nZLrISFJl8txg+Q sLRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687872237; x=1690464237; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/JjYFWhUkMupfyA5wc877/4DODs5BAde5YzMX5S1gP8=; b=kWYIIMgZ8crR71z1B/Eo0hCwdSov/1AH3hEPiDn05MtX/6GAyDzjbGYLxe5qwitmRI wriEUCq1X/BGaA7oswbZi3efDgQr8FYZR8uIGb/pdgG4Fu5Zhy1T/4TKaE2YGmYi4BiS euz7UNfyk6v/MmR/BObPI3fTtCRPb9zBYyNzwA9v8xQZ1eIgAk5YuTQhO9KszghYNhNw LrvlY7AqxZeWcJ2AXcwvIM+O0i1AtEDjeqCnxQarRySmFSAV/fnysEyYrqQm2q3Xr0lm MPW9UitCxcSziJwaWPevhJhsa2v21MJAGc41i+LH6UqGMaCR9DUTJcfrF9mkgZdECG1f 6BBg== X-Gm-Message-State: AC+VfDwRgtYNBIVJ0geSk4RdKIbZD1zAqvY2NmxExNW73Rxc7a1BCGOc HcgxYWFVUdT7EeotDAeWSwcQhVx6QjmYEfgJ5SI= X-Google-Smtp-Source: ACHHUZ5kYle0pb+ExBj6UrSHmU6RI+90cNOJvoGrC4RF/jQeBWkHQHDJOqw+v3NeiwRfA/nyZjyyhfvCiY6CN8+asB8= X-Received: by 2002:a25:dd8:0:b0:beb:5abc:763e with SMTP id 207-20020a250dd8000000b00beb5abc763emr26131120ybn.26.1687872236662; Tue, 27 Jun 2023 06:23:56 -0700 (PDT) MIME-Version: 1.0 References: <20230619075315.49114-1-zhiguangni01@gmail.com> In-Reply-To: <20230619075315.49114-1-zhiguangni01@gmail.com> From: Liam Ni Date: Tue, 27 Jun 2023 21:23:40 +0800 Message-ID: Subject: Re: [PATCH V2] x86,NUMA:improve the execution efficiency of numa_meminfo_cover_memory() To: rppt@kernel.org Cc: dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BFC0520021 X-Rspam-User: X-Stat-Signature: yicoykskrstxyhpgpqccx7pz8ybe3raf X-Rspamd-Server: rspam01 X-HE-Tag: 1687872237-756255 X-HE-Meta: U2FsdGVkX19yPpgqcOK02wr8wlv24ALj12rd4Qt1HkjVL2g2Wi0TijfwaNQZVdBZwJsmvq3jX7iOg4qb7pQhS6AGa8P3gofOJaPRG/q4Mbq+5qMm9hJCtA6R9b6GgSWrZNLBuVnoaTlpq2Rvr6eBqunKb78DAkXJOmENiKNzBZ4m4c+UQEpT2PYEqZsYpBLXR15juFD3S7fNHr3dvuaK2ahNTjmo93gG6LAWmfYlLit01QUSLKLHiI/q3DHY32h6TxKDvJvOfC1AzgdrRwISpkfhhsf4upafCereP/DNh9VGkftMRtDNjtYFNLNZ+TMus5YSO5qQLx1o6fqyDKTsghLBX43n2OLIE/0WJZjpV7M5dNb6MiTtt276PlbgswJ5jQtyko4zAzPnlqeWXKtp4KSMPLJ6aQ5dhKO5DQgOU826tTMZrXZJyrIDPUvKhsgLzHVeWAhf0FXFk+nlxCf/Go5d51EQvcBodwW+QqJM8AC60ZC1KDHa0g8vJlv9YMPdigi3ZdQXMiyO8FPZ/qE7IjA+TKCMG/V3jlP5kDbkv86RHaf84LW4jeuzn89qnFDLBXrtwW85OnlyPE1vTaqAJW2lZUF3L2ckX2Rtei444SwAYKkavlM1HEjrG/ZdcxriIj6MNIo6TzSiTPbqlyL/TE+cpA9a/P2xKj5v4G8ApflRjxHJjCJfQ003IHsULDBeN4/Qd11S65qaLq/CdSKOkZG4AJP5R1ALV1MgzgEvvt1jIvNwuV9y1zbBuNRXElVqAPXp3SavWq9cptVGkGRuj6PZoqjKDi+JDUAY8YmZhaSOdHtCxmWarGLxfj2lPvna9vsng4AQ7yzYZsqaWJjnCfzXZzr1PMJqqarVVLokrcvui0I7OhZ/UwKtDBwHKPiblgVX+1GOuM2xAuyUvSxCB8PA16CMYomg6lhQ5kC4u8zrwlikiVYtJBS8xm+BBRUZ9D+oQsRH48ai8Lg1OE2 LdYF1+qa QJAJtbUPTTQZzpKpSG6nVr2Rr53AzhUQMJEbg6To6i0s5BPXBn3Cvil6BzVug0kR6/N0yh7qC2ovib8MRA8nLJzqGGa9YtFJDtaKnQfI/zmJ4XPPXs2zM9V/Lbvr4RrLnotNegikruXj7CyjoHXQollmE8OMfcfB5ICHLcKAkbc46xC7k19jMAgOplcojZmGTr+d5KR9fJV/UR8og39bww0IW3r0FMmZNtIO/uTyQZ3zJTbJzQ+mmOFFHVcP1V02k2f00VBREwJRWutAdDEuAJx/TnmKA0C6dTZ+74Xq7j6sFQ9yq6GiSxVQUIjhoGT9ZqllEdGoQKnTHP93u5SSSM2IV7nfjo+EmTBfPCH0olA9Vhz0FtYXrN6gk0+PIn3sFNcpU1gN3yaHPV/MSFCTrMEWCCDijIYC/v5455eq5BHSGo40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: friendly ping On Mon, 19 Jun 2023 at 15:53, Liam Ni wrote: > > The number of pages in memblock that doesn't have the node > assigned,which also means that these pages are not in numa_info. > So these pages can represent the number of lose pages. > > Signed-off-by: Liam Ni > --- > arch/x86/mm/numa.c | 25 ++++++------------------- > include/linux/mm.h | 2 ++ > mm/mm_init.c | 26 ++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+), 19 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 2aadb2019b4f..ffe3b771eac7 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -451,28 +451,15 @@ EXPORT_SYMBOL(__node_distance); > * Sanity check to catch more bad NUMA configurations (they are amazingly > * common). Make sure the nodes cover all memory. > */ > -static bool __init numa_meminfo_cover_memory(const struct numa_meminfo *mi) > +static bool __init numa_meminfo_cover_memory(void) > { > - u64 numaram, e820ram; > - int i; > - > - numaram = 0; > - for (i = 0; i < mi->nr_blks; i++) { > - u64 s = mi->blk[i].start >> PAGE_SHIFT; > - u64 e = mi->blk[i].end >> PAGE_SHIFT; > - numaram += e - s; > - numaram -= __absent_pages_in_range(mi->blk[i].nid, s, e); > - if ((s64)numaram < 0) > - numaram = 0; > - } > + u64 lo_pages; > > - e820ram = max_pfn - absent_pages_in_range(0, max_pfn); > + lo_pages = without_node_pages_in_range(0, max_pfn); > > /* We seem to lose 3 pages somewhere. Allow 1M of slack. */ > - if ((s64)(e820ram - numaram) >= (1 << (20 - PAGE_SHIFT))) { > - printk(KERN_ERR "NUMA: nodes only cover %LuMB of your %LuMB e820 RAM. Not used.\n", > - (numaram << PAGE_SHIFT) >> 20, > - (e820ram << PAGE_SHIFT) >> 20); > + if (lo_pages >= (1 << (20 - PAGE_SHIFT))) { > + printk(KERN_ERR "NUMA: we lose more than 1M pages\n"); > return false; > } > return true; > @@ -583,7 +570,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) > return -EINVAL; > } > } > - if (!numa_meminfo_cover_memory(mi)) > + if (!numa_meminfo_cover_memory()) > return -EINVAL; > > /* Finally register nodes. */ > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 0daef3f2f029..99b7b49f1378 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3043,6 +3043,8 @@ unsigned long __absent_pages_in_range(int nid, unsigned long start_pfn, > unsigned long end_pfn); > extern unsigned long absent_pages_in_range(unsigned long start_pfn, > unsigned long end_pfn); > +extern unsigned long without_node_pages_in_range(unsigned long start_pfn, > + unsigned long end_pfn); > extern void get_pfn_range_for_nid(unsigned int nid, > unsigned long *start_pfn, unsigned long *end_pfn); > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 3ddd18a89b66..1d5085a8f93b 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1132,6 +1132,32 @@ static void __init adjust_zone_range_for_zone_movable(int nid, > } > } > > +/** > + * @start_pfn: The start PFN to start searching for holes > + * @end_pfn: The end PFN to stop searching for holes > + * > + * Return: Return the number of page frames without node assigned within a range. > + */ > +unsigned long __init without_node_pages_in_range(unsigned long start_pfn, > + unsigned long end_pfn) > +{ > + struct memblock_type *type = &memblock.memory; > + struct memblock_region *r; > + unsigned long num_pages; > + int i, nid; > + > + for (i = 0; i < type->cnt; i++) { > + r = &type->regions[i]; > + nid = memblock_get_region_node(r); > + > + if (PFN_UP(r->base) >= PFN_DOWN(r->base + r->size)) > + continue; > + if (nid == NUMA_NO_NODE) > + num_pages += PFN_DOWN(r->base + r->size) - PFN_UP(r->base); > + } > + return num_pages; > +} > + > /* > * Return the number of holes in a range on a node. If nid is MAX_NUMNODES, > * then all holes in the requested range will be accounted for. > -- > 2.25.1 >