From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0DFEB64D8 for ; Thu, 22 Jun 2023 05:06:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56978D0003; Thu, 22 Jun 2023 01:06:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E05CC8D0001; Thu, 22 Jun 2023 01:06:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF45E8D0003; Thu, 22 Jun 2023 01:06:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF79A8D0001 for ; Thu, 22 Jun 2023 01:06:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8CCE71C8CAC for ; Thu, 22 Jun 2023 05:06:24 +0000 (UTC) X-FDA: 80929197888.09.090A7A2 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf26.hostedemail.com (Postfix) with ESMTP id D3407140006 for ; Thu, 22 Jun 2023 05:06:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MAQtGOkk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687410382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MthCju+rZIz8gsMWBktpqG65ZcoIquNN1JdN3p215eU=; b=ZKtenH743p9H/Yf5GO6PFPOffe00kwxQzorHhpYnRdYJ/9O1Th3khTnlVb/7P5z4wLHn9t KYasXRMqfS/6d9YqyiEHzg/2Htpfq0BjMwmS7aPQa8VH66bTbLjynnnw5+gxP9Rxxes39g r4Nm9PekfpOzRFv2uPN9wy/2SxaOVwY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MAQtGOkk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of zhiguangni01@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=zhiguangni01@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687410382; a=rsa-sha256; cv=none; b=vtcKvFIEea7vZPBVROp1FvGSNZ+/0qPc357fuBJce+fp47wrXEyeBKkHK32oqWgqhBdPKi voJFw74nUcyD9K1sbN2/hFqZGt+NhYK56tf39xmAO1g6RJVK5/TdiV5lKr2oosbiEdUqoo IxpzkDJd1K2ACBXhTmXaoFgg7y6ZyXE= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-bff27026cb0so1303437276.1 for ; Wed, 21 Jun 2023 22:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687410382; x=1690002382; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MthCju+rZIz8gsMWBktpqG65ZcoIquNN1JdN3p215eU=; b=MAQtGOkk9kv3FBWEGGwDM+cn/NBnQN5GtguG9BsU406oxl0g2RznHS5jTaljD/MQ5D uoCxw55206+2UxWQ25tgkyHKqpylI8l/m+P8KKNmyBmi0Lg8x/lhar4WrcwMFmBJQxZU yoeLUdlZoJiVaps/ZX6kXgrDHffOelo7GxnHaMBmhHuNMR/NImgUCcFRdubxdmQWGAXd kS67jYfCRV6R5ZxE2WnMc+35QfNtg7dyTllhc+FzwoBtuYwk/OoScvjgrVMpkT2yHhx3 B4+V9mjxrwOFUK8QRz/Ygw8iRPY9Cu5SDpCzobzfs0k4RJNTl2lm66JYxJxZ/7DnoT2j fVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687410382; x=1690002382; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MthCju+rZIz8gsMWBktpqG65ZcoIquNN1JdN3p215eU=; b=B79RRRdorj/zbiQaUvq8XqmhMkP/pLViHS00SQ+S10LuSxMrcB3oEl5UW48j/ej+Ys FG78XKz8ZcDiAefjsma92nC7XU/iIWFlWqzUM+jLMkwCwyd7wVsUxU9qIwa+4/WTHo8I hBTct1FWvzJAYvswxwujYEnmN3y/myFqJG1oxoP5LjpfLZc95YBHO2cq6V846KJXYBen TM3Zbzj20MWm/vI7n5kBomyd1c5k5feWsARjD/MKBIuBcjOfZbkklpfsiFGKjToPPbsZ QTIW3gAfmvOA3J4fe5K+RBdi+AvLgrm0PQeNFLBRwkmsf7FuWaFmp6r8fH4x3nCYFbdo FtHA== X-Gm-Message-State: AC+VfDyxRyY5IYvqIbhF7/jsLvhz7nbp0m9peeEqIzqC95MwiW837Pb2 zsbIlsZRcDy3fE2G1Vr8XslJQldLK7InjYbxk7I= X-Google-Smtp-Source: ACHHUZ4PrGtZEFFrewBaR05yFcgsXGgNCDzkJCtEBW8P4mRUZ3wPZzIjyHdtDb4Dc4s8KAXE/aYDdtx5SpuH9HwFmeU= X-Received: by 2002:a25:b10c:0:b0:bc7:60cb:5cb4 with SMTP id g12-20020a25b10c000000b00bc760cb5cb4mr12950168ybj.12.1687410381729; Wed, 21 Jun 2023 22:06:21 -0700 (PDT) MIME-Version: 1.0 References: <20230615142016.419570-1-zhiguangni01@gmail.com> <22bba771-f10b-8624-1874-5eb747e798dd@intel.com> In-Reply-To: <22bba771-f10b-8624-1874-5eb747e798dd@intel.com> From: Liam Ni Date: Thu, 22 Jun 2023 13:06:10 +0800 Message-ID: Subject: Re: [PATCH] x86,NUMA:Get the number of ram pages directly in numa_meminfo_cover_memory() To: Dave Hansen Cc: dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, rppt@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D3407140006 X-Stat-Signature: s733d73ftbh1xqhnfgzduwyjixm3onyu X-Rspam-User: X-HE-Tag: 1687410382-170856 X-HE-Meta: U2FsdGVkX19y++gnyHja7n7tc6VUPSBAkB5oHripFH4C733Upfs4Q0JidznMowiHxUX0tnOoRfmD1eA6Q0T67G1Yy+Qe/ulMxboXTBIUnEBDbCuqwrEic7BoTwNF0iUDPwOUbBvS+I0PM9jspiwKfwYMX9FhQlD1FJXvUCozJ3XmTW/YlIJSf4dK0sRLAyERDMW8iUKhGdVfZLZJ4l8M8HewaKA9p9+lYrjkLbuxmuj+WYfybniBiaHvHoJ7weMJivhrBVNr19FoRJPGHJR4g4u0XJCZi/GBTxaLCIMRYvRJaqrw6Nsj/oUyhzb2BccXztd/6dzXrXuxaVb3z9LdUgqhPAhdcxzu8XrR+mCOLMEmmx3X8Pj42BVm/BbjvIOWb+forvw8zl2jxpvNaXuJ6hS8oBUkoHaFAQiXYLgny+Mbuu55QjPjRLw6/OeRoCbsOmBlh/symnAKFrYDwp8kJjvq6kzdj4pA3InqzoVFzX7ikQE7UX8NlAhNv+UVNTSgFQcgw19PCWD6xcrjzgkN5rnm4noKTLfilKoT06i7j8iQKll1PElVNlPsohDPB5Hc03awvmRSmfw0d/yma5b7pX/m5gBAUQG9UBBdfzPZxfxjEF3IEP+/YhV1a53gmPyo6AvioXylALnNT221g2KxWHkeLFd6fHNfDRLfgMg4Rm6hdgJ0rQh7t8dJvgiTuVqGy1myXbhe4v5+RQaOFPO6WkR1q3inCz+gVMSF1mAXHvzAOM7/JaABx90yg/aDp+q8jnAiyRxkz9EUWsdYgrmz4hdS7UODo4/SRzfl3zQl/E/uREGoswIdEpIlIWE0o/Fmgfcu87KIVMa89ts1i6i4pclnErcecSWDHm5LFFmn4DZ2nxAO7pormXLFDMd6aAPWkuctiTqQtyiwpDWBNNnVy1xTV57rMZ4VzgzSKT6mbYFBX+xS0xnY6Nr05OyzVL2RxrMjnKwjJ+07XwvtLTc LJ4znAyQ r2JloHVYqnUy36YO1zVm7MdUzBtz9uJd9zE5pUg0LGet5pxLsIeG4Fp4fx9VsP8O0NOs4dY6+gTLutB0GZdZ1Y+M8UOpPClBRKs/egEiTbs/eme8zc0xuxTVs2uZ+IxNXZXc0kMlhK1anJa7oRBjRgJgDbjh+d9Kfxnej1n7J1YexPMXOGFUefOPAsYSbIhqsvatCS/bIbaXcIgrRDop61eHcrxy+meQw+yCp9UG40cmo/WjxfYSZpMfrDajvSUqvyWLgwZKUBaKkSTe/ixlalDjmUhlwkfgYfPQsWWDfDEmeIPZdRYAH57FqjgHdK1uHHEB7TLoUEld3M9m8Hs+OD4eHmDrNkU+TXUaHoTScmm9wRalisX77VLlF8RREnvkJK4fKV4fS+dxRH6jtQeNDFaDoGzL4DfZcMkFJtCl+162MO1pj7dQ5b5thown9YaByO1yNbb+4UTvod5Pq7aDP4iJKIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Jun 2023 at 01:49, Dave Hansen wrote: > > On 6/15/23 07:20, Liam Ni wrote: > > In a previous implementation,The ram page is calculated > > by counting the number of holes, > > however,the number of ram pages is calculated during hole calculation. > > Therefore,we can directly calculate the amount of ram pages. > > What problem does this patch solve? I has send patch V2 to improve the execution efficiency of numa_meminfo_cover_memory() by optimize the way of calculating missing pages. patch V2: https://lore.kernel.org/all/20230619075315.49114-1-zhiguangni01@gmail.com/ In the previous implementation, We calculate missing pages as follows: 1. calculate numaram by traverse all the numa_meminfo's and for each of them traverse all the regions in memblock.memory to prepare for counting missing pages. 2. Traverse all the regions in memblock.memory again to get e820ram. 3. the missing page is (e820ram - numaram ) But,it's enough to count memory in memblock.memory that doesn't have the node assigned. we only need to traverse memblock.memory **once**.