From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3322C4167B for ; Tue, 12 Dec 2023 19:22:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30B2C6B0343; Tue, 12 Dec 2023 14:22:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 294476B0345; Tue, 12 Dec 2023 14:22:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BFB36B0346; Tue, 12 Dec 2023 14:22:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E52376B0343 for ; Tue, 12 Dec 2023 14:22:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8397140ABB for ; Tue, 12 Dec 2023 19:22:25 +0000 (UTC) X-FDA: 81559137450.29.AC01B3C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 8BC9A160006 for ; Tue, 12 Dec 2023 19:22:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f5ytUkjB; spf=pass (imf08.hostedemail.com: domain of kpsingh@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kpsingh@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702408943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eN8yfx7+Za9RLRe5Uuwd5P4QNYc1FoGJDmzpWtfbAIU=; b=R6/UbxJRyT1gXF5ad0Sq2dffqAMbpVP1GThyP8/lVI0YtZ/oFY5v2VJ/xDtBRCQArBYyvV L0pcjlGjXx/Bm24YdfubwzdjeCdsVG3Nah4aR6U/KVCvf8rYLEIZu4ONG9FkozxjFsHDlE jGN4NE3iWvb6CNdzW1bLWFXv+4Plli8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702408943; a=rsa-sha256; cv=none; b=t9EVntWO1bk6bgEIlDyx02TvVqZViEuUwMJnPpysfnrAeX4gm9QR5U5L0yLXn3FerZv0jt umbRAzF9h70Gdeczfa+TDUfIZWzCPD8LGNfNmgG9m8rF71J3wns1YlLMSqbw4pnd1Uiclg DHgGqKD9bQR9FjiBaXKAFeQhgVobnvI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f5ytUkjB; spf=pass (imf08.hostedemail.com: domain of kpsingh@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kpsingh@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 050FCB81097 for ; Tue, 12 Dec 2023 19:22:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2CBC433CC for ; Tue, 12 Dec 2023 19:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702408941; bh=GWSziTK7PkiFilfV05Scv9fS3VasGlENydizrC12iJU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f5ytUkjBaFSM81xZ3oETxIxEgu7fIpCOKc3PADXV3INiEEzNpWnXaB7MYtpC/Gi3I 1wNbXtyKlblZFd1dBmP6o0EQcss3bFRxmpEnaGAKhbMDDUHJCImEfwzfignStiIObi +8zJhhJDSHJvPCKVNQmBAEkEeWK0JsEzQkIZOElMpTxSGx6JblIQ5/3Fw5vf9Ko2ZH 2Sip2+jN+n0rK34lK8beTRQnUafNbbkA2P/QoRD+l1u6u4lcRzVSInH09Gj7eAfQd4 YYTq3MuPvcYZWUSok8Uv4hccJ5ZBX2BGurEo6Awz7DwZwGQlydgCKas/kWEGV3ysLN BUAR4kZ1GXPOQ== Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-551d5cd1c5fso974009a12.0 for ; Tue, 12 Dec 2023 11:22:21 -0800 (PST) X-Gm-Message-State: AOJu0YzXWeyRSDKEXBWVGYfYz2S9zTDFK8RGsWIA5ztmtX7kfJUPxiZc 9/oVeAHCO6iOz3pBwZIgePtgewkvyJZNhb9yHPjvfw== X-Google-Smtp-Source: AGHT+IGt7+EiPa2NUH35A5YujCkzrmLERWiAdyOrjpgY/ezwMiXHBzFZgc6YWQ1mlQyfRtwOs+FtPdkeuskg+LpIVB0= X-Received: by 2002:a50:9357:0:b0:54c:553e:67f5 with SMTP id n23-20020a509357000000b0054c553e67f5mr7027221eda.8.1702408939747; Tue, 12 Dec 2023 11:22:19 -0800 (PST) MIME-Version: 1.0 References: <20231208090622.4309-1-laoar.shao@gmail.com> <20231208090622.4309-6-laoar.shao@gmail.com> In-Reply-To: <20231208090622.4309-6-laoar.shao@gmail.com> From: KP Singh Date: Tue, 12 Dec 2023 20:22:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 5/5] selftests/bpf: Add selftests for set_mempolicy with a lsm prog To: Yafang Shao Cc: akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, omosnace@redhat.com, mhocko@suse.com, ying.huang@intel.com, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, ligang.bdlg@bytedance.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: jmidf91udrf69txz8tysuejfga45gn3n X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8BC9A160006 X-Rspam-User: X-HE-Tag: 1702408943-508207 X-HE-Meta: U2FsdGVkX18EjvI+xlpTdn3r3s75UGbZa/cX2+nRNUr8FSn1X06n8dIR8F2WnBseg4kCaNxcC7VQKSGEA0Id3JVayfwmFAgqKOyHnUqMmZuKnc+Qb325mF4EN9xfDOMi9qLw+8XzueibvXBtoZbVrN03dKipggSoj/pHYzrIdsftU7+MXEr85g0RcJLNM7AOMpYJrucUaE8E6FKFUu/4JnJ3Cj1JDi6aLExr2ZJEldnvcjgk23OUzBpfsDmAPuJNFPTXHmKLoy8aIJMeh8VjxrljvCN9mYd2cwjcKUJa03INeERnj7XcsAXt1tVCkIXHJOYVe3LGTMYz5+qACcC5PzHCqgThNiAWxLXEhEUASBpuv3q7aturgM24QBXBoUNMtwBiqKaZIjSuhWM/AuCcuFEZ5CG6UYZMz/s3xz62SADIyQSSqG8V1tF4vcGNfXGJY5Zw5fX7Qj9/wCv6KIGqz+wxMD0peuZOlNd/Y6P9gVA+9PE+mQ9ssa3ixzP70vlVU7D02XUmJ+IjSrMTYUbO0ftpqKZUDHOW01uGuNoijXYOJR/xbBt6+8m8WatNs7jQgQqINARmPm+HbvDhYcVVr56u3kKHWNEe9F1//dvSuSr9zhwu32nyAmnTuz1bFs7E988oAgEBaKCvpgchS1tUQz56nZSzzkMtcOPb8ug+TpZ4/ikMbCLgfN6mKshO/MH6H+QzHp6rUCTn6XD52cHjnIMIV96+Z09v0qBcb4/SN50WcTV5UO6rkoLgfmiHZgG8O4QnWKcZLFLzlkM47Ky7Sy9fbnUrlPbKSXOAjFwe9qm868S9ByXGohRjz5NPFuL8WRzQoKi52RpKnvPUsGheDP8WQ4Ah8Rkyfei3M1qfyV1QESG5C/N8sJQyMW7d7mnQb9WogykU6XQcGiJrWHOCkR9tQk4ybLyYgzTJTQ4nQUtAGBZk2S3WYLGqpPV+MWvfZ/G0tytCqjnX7Tv6gBb jJZwULeV 8Cqa9GFYb24ffXsvanMFi2dggS9Vk80EkK6oeVtzt9wLf//ms2GHRW1n8QImG+/hv9iq4nuNPQsoo4EQ8CR/p12/dxU+nRZZqWUb+qgbyLT298j8TORLXxM8z+qZuCpgLnm0WvD+o2ZR9DL1dGaKO1c7kdL3vutGwzSMLImsdULXQpWAbI6p3X+a781eEt2wCjVBjapIdb5QFAOVdDyLknNImyWboscPLLOnClAJ3JXyK2QAcegv0MUqD+F2djEaypebGgJiR0b4ReBQl4jWtgeyQMDQTS7NT4ZOik7TO7yNE5j2ira0UVSm/Iw5vxOe++zuGruLa/v/WHCa69ZNkTnOaOX+TvLbgb8yJBRDAKgqu6JfdmSMtg/OTdtBmT1autUV3efrZOJD0LFw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 8, 2023 at 10:06=E2=80=AFAM Yafang Shao = wrote: > > The result as follows, > #263/1 set_mempolicy/MPOL_BIND_without_lsm:OK > #263/2 set_mempolicy/MPOL_DEFAULT_without_lsm:OK > #263/3 set_mempolicy/MPOL_BIND_with_lsm:OK > #263/4 set_mempolicy/MPOL_DEFAULT_with_lsm:OK > #263 set_mempolicy:OK > Summary: 1/4 PASSED, 0 SKIPPED, 0 FAILED Please write a commit description on what the test actually does. I even think of something simple that mentions a BPF LSM program that denies all mbind with the mode MPOL_BIND and checks whether the corresponding syscall is denied when the program is loaded. > > Signed-off-by: Yafang Shao > --- > .../selftests/bpf/prog_tests/set_mempolicy.c | 81 ++++++++++++++++= ++++++ > .../selftests/bpf/progs/test_set_mempolicy.c | 28 ++++++++ > 2 files changed, 109 insertions(+) > create mode 100644 tools/testing/selftests/bpf/prog_tests/set_mempolicy.= c > create mode 100644 tools/testing/selftests/bpf/progs/test_set_mempolicy.= c > > diff --git a/tools/testing/selftests/bpf/prog_tests/set_mempolicy.c b/too= ls/testing/selftests/bpf/prog_tests/set_mempolicy.c > new file mode 100644 > index 0000000..736b5e3 > --- /dev/null > +++ b/tools/testing/selftests/bpf/prog_tests/set_mempolicy.c > @@ -0,0 +1,81 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (C) 2023 Yafang Shao */ > + > +#include > +#include > +#include > +#include > +#include > +#include "test_set_mempolicy.skel.h" > + > +#define SIZE 4096 > + > +static void mempolicy_bind(bool success) > +{ > + unsigned long mask =3D 1; > + char *addr; > + int err; > + > + addr =3D mmap(NULL, SIZE, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_A= NONYMOUS, -1, 0); > + if (!ASSERT_OK_PTR(addr, "mmap")) > + return; > + > + /* -lnuma is required by mbind(2), so use __NR_mbind to avoid the= dependency. */ > + err =3D syscall(__NR_mbind, addr, SIZE, MPOL_BIND, &mask, sizeof(= mask), 0); > + if (success) > + ASSERT_OK(err, "mbind_success"); > + else > + ASSERT_ERR(err, "mbind_fail"); > + > + munmap(addr, SIZE); > +} > + > +static void mempolicy_default(void) > +{ > + char *addr; > + int err; > + > + addr =3D mmap(NULL, SIZE, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_A= NONYMOUS, -1, 0); > + if (!ASSERT_OK_PTR(addr, "mmap")) > + return; > + > + err =3D syscall(__NR_mbind, addr, SIZE, MPOL_DEFAULT, NULL, 0, 0)= ; > + ASSERT_OK(err, "mbind_success"); > + > + munmap(addr, SIZE); > +} > + > +void test_set_mempolicy(void) > +{ > + struct test_set_mempolicy *skel; > + int err; > + > + skel =3D test_set_mempolicy__open(); > + if (!ASSERT_OK_PTR(skel, "open")) > + return; > + > + skel->bss->target_pid =3D getpid(); > + > + err =3D test_set_mempolicy__load(skel); > + if (!ASSERT_OK(err, "load")) > + goto destroy; > + > + if (test__start_subtest("MPOL_BIND_without_lsm")) > + mempolicy_bind(true); > + if (test__start_subtest("MPOL_DEFAULT_without_lsm")) > + mempolicy_default(); > + > + /* Attach LSM prog first */ > + err =3D test_set_mempolicy__attach(skel); > + if (!ASSERT_OK(err, "attach")) > + goto destroy; > + > + /* syscall to adjust memory policy */ > + if (test__start_subtest("MPOL_BIND_with_lsm")) > + mempolicy_bind(false); > + if (test__start_subtest("MPOL_DEFAULT_with_lsm")) > + mempolicy_default(); > + > +destroy: > + test_set_mempolicy__destroy(skel); > +} > diff --git a/tools/testing/selftests/bpf/progs/test_set_mempolicy.c b/too= ls/testing/selftests/bpf/progs/test_set_mempolicy.c > new file mode 100644 > index 0000000..b5356d5 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/test_set_mempolicy.c > @@ -0,0 +1,28 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (C) 2023 Yafang Shao */ > + > +#include "vmlinux.h" > +#include > +#include > + > +int target_pid; > + > +static int mem_policy_adjustment(u64 mode) > +{ > + struct task_struct *task =3D bpf_get_current_task_btf(); > + > + if (task->pid !=3D target_pid) > + return 0; > + > + if (mode !=3D MPOL_BIND) > + return 0; > + return -1; > +} > + > +SEC("lsm/set_mempolicy") > +int BPF_PROG(setmempolicy, u64 mode, u16 mode_flags, nodemask_t *nmask, = u32 flags) > +{ > + return mem_policy_adjustment(mode); > +} > + > +char _license[] SEC("license") =3D "GPL"; > -- > 1.8.3.1 > >