From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEF9C43334 for ; Thu, 30 Jun 2022 06:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F65E8E0001; Thu, 30 Jun 2022 02:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A59E6B0073; Thu, 30 Jun 2022 02:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E048E0001; Thu, 30 Jun 2022 02:56:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 345436B0072 for ; Thu, 30 Jun 2022 02:56:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id EE6038106A for ; Thu, 30 Jun 2022 06:56:08 +0000 (UTC) X-FDA: 79633992816.20.5BC51B1 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 9395720041 for ; Thu, 30 Jun 2022 06:56:08 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id bx13so13223166ljb.1 for ; Wed, 29 Jun 2022 23:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9T64cR/FufP6/CunzmPu+rS6tL4/EEVZVw0GWwm9EzE=; b=nl5CzODxaap3kUpQ3c2ewioKttk0evPfzAmsXqdVyJfDD8Xz+h/P9z06jbmly4yY7L /SM81HeOvWYYR0bESzaNPrOyZkAsFvQIjXs194O9V8hUZkGD02pFl87F8XvIsCO+LlWv mkecnJBaPs4XiX7XR3NVe5iGdkM+0fGDXQ50hC0hcvxwOJf4ZKwmlrSa6jYlba9pQc9w T7fp9kDH3QmsLOkOhsJPm3WXqFH2iFPXVYbxfLCZViV5EDzIyz6oMIMFmzVd/t9KU61S UkykkTPPYWyMxXlgV5ldCyrJkG2Wg5OMuNDb+cllPJ+UdoQLg8xNwuYJts5K7Oi0xqEb rw1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9T64cR/FufP6/CunzmPu+rS6tL4/EEVZVw0GWwm9EzE=; b=jQnYho87fj1wEDMI9bKO2VxBiHpQakD8ScqVS5NJtCba3XFBgqn3XCc4xVQVG/ab0p YUsngxfDjjuLYZXPKMRwu++Vd5IBQfrbKkt1qoPrX4SZ/Zvdp6qOTusrHTxIwqbxQVTz ewxuivBgWlXAtSTKztzpmxhzIMgVMY5e/1Fs1jxGuWYOBYyncq0kRxv7fsh1IR+91bHf sx1F1MpnKE6oEP3MeJ2QvGivYqQWMCitgYlfgKWZc/78KVHTllvZTxMdBdFJlm6Y2v6x xexknC4l+RuKJKRziBLjk4FiYrdUfsL2fsqtALVlJ19m9C6Oa+OFcbWWswkKOFlPYz4N EdDQ== X-Gm-Message-State: AJIora+X/xenNaF2On8DRXlU7YPAWK2LdmCIXteoNF9OSpOnH1qNFzBO 8I1l+4XZc8DrYjQSDjbHIMg4zSmxXfE0xH0Cf/g= X-Google-Smtp-Source: AGRyM1sBSAIZws0B107oPIkAqK3Mwmga7wYdFH+S0RC6qMSnCbwXbR12svkou4bYDjabtTAqq0wQOWxW/qt69hbMDDY= X-Received: by 2002:a2e:4e12:0:b0:25a:9d28:7d6b with SMTP id c18-20020a2e4e12000000b0025a9d287d6bmr4218881ljb.482.1656572166748; Wed, 29 Jun 2022 23:56:06 -0700 (PDT) MIME-Version: 1.0 References: <20220630043237.2059576-1-chenhuacai@loongson.cn> <20220630043237.2059576-5-chenhuacai@loongson.cn> In-Reply-To: From: Feiyang Chen Date: Thu, 30 Jun 2022 14:55:54 +0800 Message-ID: Subject: Re: [PATCH V2 4/4] LoongArch: Enable ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP To: Arnd Bergmann Cc: Huacai Chen , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , loongarch@lists.linux.dev, linux-arch , Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux-MM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List , Linux ARM , Feiyang Chen Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656572168; a=rsa-sha256; cv=none; b=tRbC2SY16/kKAiSdV5v9HYePnkbvUd2tt9f9gGgPSnKzYAnduKjF8sE1pvUkBVsIabxgbG HProZZ+zElxWKh2epGoxgJPcHhNljaLZoiSAbCZF4DKXpkXdhV+ell5QAQkYOWsYYZsNTd ZaGV12MajAmpc9MdeX3ApTIx7i0iHms= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nl5CzODx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of chris.chenfeiyang@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=chris.chenfeiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656572168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9T64cR/FufP6/CunzmPu+rS6tL4/EEVZVw0GWwm9EzE=; b=Nk599UFEsLlLc3zFbLWKwpbvoabwaWE/mMUAQj71C8eCJ9ZtMszA7GsSVZ4NDoPqIbFXUg D3ZXoGAd+2YW9UH6JnYrAdqLRK/c0Zd3Ff5HYH6HyCx7A85XG95qQYjBmPJBWnEneoGNUO mZgRWIlJbBpKmRNhcKj/5rxAwFPG/Xo= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9395720041 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nl5CzODx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of chris.chenfeiyang@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=chris.chenfeiyang@gmail.com X-Rspam-User: X-Stat-Signature: sibs6fjfqktt6oy1hr665ynzmimg3t14 X-HE-Tag: 1656572168-786359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 30 Jun 2022 at 14:07, Arnd Bergmann wrote: > > On Thu, Jun 30, 2022 at 6:32 AM Huacai Chen wrote: > > > > To avoid build error on LoongArch we should include linux/static_key.h > > in page-flags.h. > > This is an expensive change in terms of compile speed, as static_key.h has > lots of dependencies, and page-flags.h is included in a lot of places. What > it is actually needed for? > Hi, Arnd, If CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y, the page-flags.h relies on static keys. If we don't include static_key.h, we will get the following errors when compiling. In file included from ./include/linux/mmzone.h:22, from ./include/linux/gfp.h:6, from ./include/linux/mm.h:7, from arch/loongarch/kernel/asm-offsets.c:9: ./include/linux/page-flags.h:208:1: warning: data definition has no type or storage class 208 | DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, | ^~~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/page-flags.h:208:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_MAYBE' [-Werror=implicit-int] ./include/linux/page-flags.h:209:26: warning: parameter names (without types) in function declaration 209 | hugetlb_optimize_vmemmap_key); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/page-flags.h: In function 'hugetlb_optimize_vmemmap_enabled': ./include/linux/page-flags.h:213:16: error: implicit declaration of function 'static_branch_maybe' [-Werror=implicit-function-declaration] 213 | return static_branch_maybe(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, | ^~~~~~~~~~~~~~~~~~~ ./include/linux/page-flags.h:213:36: error: 'CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON' undeclared (first use in this function); did you mean 'CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP'? 213 | return static_branch_maybe(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP ./include/linux/page-flags.h:213:36: note: each undeclared identifier is reported only once for each function it appears in ./include/linux/page-flags.h:214:37: error: 'hugetlb_optimize_vmemmap_key' undeclared (first use in this function); did you mean 'hugetlb_optimize_vmemmap_enabled'? 214 | &hugetlb_optimize_vmemmap_key); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | hugetlb_optimize_vmemmap_enabled Thanks, Feiyang > Arnd >