From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx192.postini.com [74.125.245.192]) by kanga.kvack.org (Postfix) with SMTP id CA1CC6B002B for ; Wed, 17 Oct 2012 06:56:15 -0400 (EDT) Received: from mail-ee0-f41.google.com ([74.125.83.41]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1TORIM-0004CK-PM for linux-mm@kvack.org; Wed, 17 Oct 2012 10:56:14 +0000 Received: by mail-ee0-f41.google.com with SMTP id c4so4483409eek.14 for ; Wed, 17 Oct 2012 03:56:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <507E3EA6.5080809@jp.fujitsu.com> References: <1350403183-12650-1-git-send-email-ming.lei@canonical.com> <1350403183-12650-2-git-send-email-ming.lei@canonical.com> <507E3EA6.5080809@jp.fujitsu.com> Date: Wed, 17 Oct 2012 18:56:14 +0800 Message-ID: Subject: Re: [RFC PATCH v1 1/3] mm: teach mm by current context info to not do I/O during memory allocation From: Ming Lei Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: linux-kernel@vger.kernel.org, Alan Stern , Oliver Neukum , Minchan Kim , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, Jiri Kosina , Andrew Morton , Mel Gorman , Michal Hocko , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , linux-mm On Wed, Oct 17, 2012 at 1:14 PM, Kamezawa Hiroyuki wrote: > > I think the idea is reasonable. I have a request. Thanks for your comment. > > In current implemententation of vmscan.c, it seems sc.may_writepage, sc.may_swap > are handled independent from gfp_mask. > > So, could you drop changes from this patch and handle these flags in another patch > if these flags should be unset if ~GFP_IOFS ? OK, I agree. In theory, mm should make sure no I/O is involved if memory allocation users passes ~GFP_IOFS. > > I think try_to_free_page() path's sc.may_xxxx should be handled in the same way. Yes, alloc_page_buffers() and dma_alloc_from_contiguous may drop into the path, so gfp flag should be changed in try_to_free_page() too. Thanks, -- Ming Lei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org