From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA98C43218 for ; Tue, 11 Jun 2019 11:39:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 123DD20673 for ; Tue, 11 Jun 2019 11:39:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HjkPP0rM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 123DD20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B2F56B0005; Tue, 11 Jun 2019 07:39:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D216B0006; Tue, 11 Jun 2019 07:39:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B59C6B0007; Tue, 11 Jun 2019 07:39:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by kanga.kvack.org (Postfix) with ESMTP id 48B376B0005 for ; Tue, 11 Jun 2019 07:39:24 -0400 (EDT) Received: by mail-io1-f69.google.com with SMTP id n4so9756410ioc.0 for ; Tue, 11 Jun 2019 04:39:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=efKaC7Y7c8Vr7TGFSTF+nZFI+Dv5FKl3QaIWZEc3/K8=; b=mJJxkWD0o157sWZy8DoqF3hWivNrByLu+vy0BXGAfRnXwgD16/cFU/LyoOhLLyYOya mnnAMWnc9yKvA4Efj+P8/nHsOUwpxvdk9trE5R0EbvU06VUL/XWfsFsuWGIhnpMZ3G2O 9MmY0yKN0ZB3WQ2zYnmTIdUlYxt06DarQpJCouybwnqXDwis5ezB0MHsTlZeL3dFsje4 rmssMICYVJ2FcpOnyg1PDiJkRO/GVAElJiCh6N201knlMFyWs/INWs7loGo3vdThBMic ryiDxNP08vAE/yIZcqig6Bj06WexBqtB7MP40NUpffOWzTyRiKhv61CSDNZJPZwgqKbL 2apA== X-Gm-Message-State: APjAAAV3gOfbxzAhpfx7AoeNBKSOKfdH9tGXh7JablXB5AlC/HV3FXiB 2oCcTdj/DL6MmHuJd1SFhHL/verWQ0qZ/U0izI7rFgGVU0Ef0HpsoOnsjLTohwxPpeOuGQCAIIx 3nzzEYsww0EckcHE9vfVpJ1UA/2MEO384LTZ82um7J38jrCKDAi7zGwt8FjbIWMjmHA== X-Received: by 2002:a6b:8bd1:: with SMTP id n200mr28171484iod.134.1560253164031; Tue, 11 Jun 2019 04:39:24 -0700 (PDT) X-Received: by 2002:a6b:8bd1:: with SMTP id n200mr28171447iod.134.1560253163321; Tue, 11 Jun 2019 04:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560253163; cv=none; d=google.com; s=arc-20160816; b=0TqsOlem6rvWw3W26/0BUUlRVixczXoLfk7MymDduLvZ+CvdwB3bNiuhpy17V/Wwu1 ycBg0dGG+Xf9zQlC1l71ncSqEVWuOp6+MfA0URvfPY/3K1iVFinyp3vXuWm7AY8M8lDk ILU3RIIwyNNfba0bW3VGcxPeaeoaPU+OGrb2hvvJBANq5JNIZGKrkQj/6NR3RW+2t3fQ WVmIHKTvEtNlFXpRfM1nXqIry433UQPlISq6PosMWEohyCcIWgoLvHAnuWtJyK9skvzZ KgQKqWQXQDUZAPnMtmug+reQRH7tGW2jomr+cdbLgXkfjyX6SqQZ19LMFtGBafBlLlq6 Dy/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=efKaC7Y7c8Vr7TGFSTF+nZFI+Dv5FKl3QaIWZEc3/K8=; b=mBwdmdQcYjmI6QBrcWkvrgmPItYq4ZOQu+mWBJ0er3oajzK4ORBUDBbhqlLA/bsu0z iGh4MLOd9xAlTteSeabApyd70clPCTsXx8Jq/cd+bT0t4xNQ8gobugm+IXSe/HbeGphY o7CjtEfJ93ryiSJ6xYa2ixc5+782sBboRAKMTkf3fNSmgSGCpf1ET57ZvuapyaXORfm1 bjeUAo9S/JWWZWk8UhWb2q6xMmHOsa5hU3PmRln79fMPaYuJiC8iPikG8EgoJpk0rIdw DbM9FApUev/RC7UYR1WWEgsxRS78ouEkGWzT+H1WwOp4FxtIRT6FP/J2EMmDJ2ISfopb p91A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=HjkPP0rM; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id r189sor2513004ith.31.2019.06.11.04.39.23 for (Google Transport Security); Tue, 11 Jun 2019 04:39:23 -0700 (PDT) Received-SPF: pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=HjkPP0rM; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=efKaC7Y7c8Vr7TGFSTF+nZFI+Dv5FKl3QaIWZEc3/K8=; b=HjkPP0rM7pScVIY6Xh/M07vmy3aQ5PQtlC4eQYxtn2CajIu0HwuzsdInUj68v/sWmU hPVZnnKJgp+oUG80tXsDTJeeiwSwiivMpO0vNbd8Gf3CFiHbqENah0ETB0RfLCB6+Cel zV1g6cD4FIiPPCKmVB/vpUdW1IWSgVJjxuAJstz5UaA+fR/VYZZ7nN9jQs3wgxItZZHl yRVioUQib6ztXoltXQxhJ6x1FfcH4KcUZnu2nXxkr8kmQNPy1YmL3IeB0nkALe+v9Xm3 YEflz1uRYXO2RmAqI4hG289nPmmdWAyZWzs8FpQP11ZhkFCE8VkA78TvZrQjZkSxpaPU dwbw== X-Google-Smtp-Source: APXvYqw6TS3RA5VFysgGlUoRPwCP73C8eavMXMYwqcgn3y/f0Ev240DJzy0aqeonNciKyczUrHgd4GX2uq+/P9k9YbM= X-Received: by 2002:a24:9083:: with SMTP id x125mr18085676itd.76.1560253162633; Tue, 11 Jun 2019 04:39:22 -0700 (PDT) MIME-Version: 1.0 References: <1559651172-28989-1-git-send-email-walter-zh.wu@mediatek.com> <1560151690.20384.3.camel@mtksdccf07> <1560236742.4832.34.camel@mtksdccf07> <1560249891.29153.4.camel@mtksdccf07> In-Reply-To: From: Dmitry Vyukov Date: Tue, 11 Jun 2019 13:39:11 +0200 Message-ID: Subject: Re: [PATCH v2] kasan: add memory corruption identification for software tag-based mode To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Matthias Brugger , Martin Schwidefsky , Arnd Bergmann , Vasily Gorbik , Andrey Konovalov , "Jason A. Donenfeld" , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , kasan-dev , LKML , Linux-MM , Linux ARM , "linux-mediatek@lists.infradead.org" , wsd_upstream Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I should have been asked this earlier, but: what is your use-case? Could you use CONFIG_KASAN_GENERIC instead? Why not? CONFIG_KASAN_GENERIC already has quarantine. On Tue, Jun 11, 2019 at 1:32 PM Dmitry Vyukov wrote: > > On Tue, Jun 11, 2019 at 12:44 PM Walter Wu wrote: > > > > On Tue, 2019-06-11 at 10:47 +0200, Dmitry Vyukov wrote: > > > On Tue, Jun 11, 2019 at 9:05 AM Walter Wu wrote: > > > > > > > > On Mon, 2019-06-10 at 13:46 +0200, Dmitry Vyukov wrote: > > > > > On Mon, Jun 10, 2019 at 9:28 AM Walter Wu wrote: > > > > > > > > > > > > On Fri, 2019-06-07 at 21:18 +0800, Dmitry Vyukov wrote: > > > > > > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > > > > > > > > index b40ea104dd36..be0667225b58 100644 > > > > > > > > --- a/include/linux/kasan.h > > > > > > > > +++ b/include/linux/kasan.h > > > > > > > > @@ -164,7 +164,11 @@ void kasan_cache_shutdown(struct kmem_cache *cache); > > > > > > > > > > > > > > > > #else /* CONFIG_KASAN_GENERIC */ > > > > > > > > > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > +void kasan_cache_shrink(struct kmem_cache *cache); > > > > > > > > +#else > > > > > > > > > > > > > > Please restructure the code so that we don't duplicate this function > > > > > > > name 3 times in this header. > > > > > > > > > > > > > We have fixed it, Thank you for your reminder. > > > > > > > > > > > > > > > > > > > > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > > > > > > > > +#endif > > > > > > > > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > > > > > > > > > > > > > > > > #endif /* CONFIG_KASAN_GENERIC */ > > > > > > > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > > > > > > > index 9950b660e62d..17a4952c5eee 100644 > > > > > > > > --- a/lib/Kconfig.kasan > > > > > > > > +++ b/lib/Kconfig.kasan > > > > > > > > @@ -134,6 +134,15 @@ config KASAN_S390_4_LEVEL_PAGING > > > > > > > > to 3TB of RAM with KASan enabled). This options allows to force > > > > > > > > 4-level paging instead. > > > > > > > > > > > > > > > > +config KASAN_SW_TAGS_IDENTIFY > > > > > > > > + bool "Enable memory corruption idenitfication" > > > > > > > > > > > > > > s/idenitfication/identification/ > > > > > > > > > > > > > I should replace my glasses. > > > > > > > > > > > > > > > > > > > > + depends on KASAN_SW_TAGS > > > > > > > > + help > > > > > > > > + Now tag-based KASAN bug report always shows invalid-access error, This > > > > > > > > + options can identify it whether it is use-after-free or out-of-bound. > > > > > > > > + This will make it easier for programmers to see the memory corruption > > > > > > > > + problem. > > > > > > > > > > > > > > This description looks like a change description, i.e. it describes > > > > > > > the current behavior and how it changes. I think code comments should > > > > > > > not have such, they should describe the current state of the things. > > > > > > > It should also mention the trade-off, otherwise it raises reasonable > > > > > > > questions like "why it's not enabled by default?" and "why do I ever > > > > > > > want to not enable it?". > > > > > > > I would do something like: > > > > > > > > > > > > > > This option enables best-effort identification of bug type > > > > > > > (use-after-free or out-of-bounds) > > > > > > > at the cost of increased memory consumption for object quarantine. > > > > > > > > > > > > > I totally agree with your comments. Would you think we should try to add the cost? > > > > > > It may be that it consumes about 1/128th of available memory at full quarantine usage rate. > > > > > > > > > > Hi, > > > > > > > > > > I don't understand the question. We should not add costs if not > > > > > necessary. Or you mean why we should add _docs_ regarding the cost? Or > > > > > what? > > > > > > > > > I mean the description of option. Should it add the description for > > > > memory costs. I see KASAN_SW_TAGS and KASAN_GENERIC options to show the > > > > memory costs. So We originally think it is possible to add the > > > > description, if users want to enable it, maybe they want to know its > > > > memory costs. > > > > > > > > If you think it is not necessary, we will not add it. > > > > > > Full description of memory costs for normal KASAN mode and > > > KASAN_SW_TAGS should probably go into > > > Documentation/dev-tools/kasan.rst rather then into config description > > > because it may be too lengthy. > > > > > Thanks your reminder. > > > > > I mentioned memory costs for this config because otherwise it's > > > unclear why would one ever want to _not_ enable this option. If it > > > would only have positive effects, then it should be enabled all the > > > time and should not be a config option at all. > > > > Sorry, I don't get your full meaning. > > You think not to add the memory costs into the description of config ? > > or need to add it? or make it not be a config option(default enabled)? > > Yes, I think we need to include mention of additional cost into _this_ > new config.