From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59623C761A6 for ; Mon, 3 Apr 2023 13:55:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 019236B0071; Mon, 3 Apr 2023 09:55:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0C326B0072; Mon, 3 Apr 2023 09:55:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD3486B0074; Mon, 3 Apr 2023 09:55:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE3076B0071 for ; Mon, 3 Apr 2023 09:55:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 984C61A057C for ; Mon, 3 Apr 2023 13:55:58 +0000 (UTC) X-FDA: 80640228396.21.C9B7922 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf14.hostedemail.com (Postfix) with ESMTP id CEB8C100019 for ; Mon, 3 Apr 2023 13:55:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RSURZppH; spf=pass (imf14.hostedemail.com: domain of dvyukov@google.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680530156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5Zx2eZQePqnyU3jO2bDpJxc2Hq5psZfequ5YzrYbHY=; b=baDmHaLkeEJbJBgV9z5Se8NLP2Pj+rvJYzrC18DH8Scwi5S1mrkrIw3e2Kwzq+TiOaxlbW +RNUKiKJ6MFMK1WUwogVrxmoAwhi65xxEqhmKVDzzLfErRGgCzAaesKzqb/nhz8Wg4RuLY GR3mW3OQl3EnKerCGYL46pjV4ooW668= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RSURZppH; spf=pass (imf14.hostedemail.com: domain of dvyukov@google.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680530156; a=rsa-sha256; cv=none; b=gdLc7pxgCC9sEkCxcM1+hdM3BlWXlDT7SJ+RywJjcJpq44bOYWO60W6eUz0JKBfeh0kLhF /zXTucT6M6XPJxGFYGFE13KJienKOhoU2wqmotfqymohBkwZ4NZMtyMqFivdHfzmLFNPO7 Phe48e7hQDLnKZbuF6NML7OZMIaKWBs= Received: by mail-lj1-f172.google.com with SMTP id h9so30455316ljq.2 for ; Mon, 03 Apr 2023 06:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680530155; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/5Zx2eZQePqnyU3jO2bDpJxc2Hq5psZfequ5YzrYbHY=; b=RSURZppHyMHfLXYJ6cYrt3X4//roop14nutqpZ39uquOsLcXxvXqdBcpklyZtcDDvQ o0tkT3Vixuiy1rWcQD2Rp2cOlp3rpDjfIcVgFp8RR8N/Mw5X0QkzgXV/QScmcpX9lhMO 7+DD0cC7giFYmGphfYV4r49q2zer4yj9kIfylLe7iDXdyyCQibiph9Ml39aGgdVbSQU+ dR2aZn4re1Nyq/opJCqjCk1mWcE9M/fSt+ajjqm9i0MjGZFJKyD9aA3ixtk/D9oLhcps y2hQO7YzJ0RQnuSI6nWfbbZkHjMMp1VG+knz146+pTABVf0QlN5esfWoIhVNsv+Ik0lB J/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680530155; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/5Zx2eZQePqnyU3jO2bDpJxc2Hq5psZfequ5YzrYbHY=; b=TLSolhfQ3pBiyzceDggzUa2Ojtr1mHKAR0goCG0hoV2B9+wzhNCNujI3jZ/ja0JBwV k7CwQewUjsHSz/1kmt9h4S7yJhgp5x7fD8wIFjcJJwrta+GiE79QqBDFIDaOsDeMrMHV Iii7nK6+0XAzbxFYVfAv71Z1yyrvCza3XKMMc+qA2fedEOwiDwWubXb9XWhRguBlTt07 qnvvow4LWGt0CYpl4iJLQSCfSOUj6ggdf20PEbWVL2spJdp1ISxPMJadfT4GTAmGv6EN ro8/SfHTv0/0/XMM6ty5juz/aey4Fr34Sc1k9Ad3M+ctKprgcC5Q+z9jINye1pl4gS9Q XdhA== X-Gm-Message-State: AAQBX9c0jKfQDJNy2Xx0jyGVYowo5x84uUDZSJtNy7ATTbFj+8e73BMt l7ltG6w4lgEkdZFX52mb6EXG16UMg4gzs3PJN7klsg== X-Google-Smtp-Source: AKy350b6GzK2LPgpejAVC48Na07/2rfnj818m0hmVue412JxJo4CZzRvP2f1ux3gKtirZZ0ofaAfNUfNSUT1R0KMxBU= X-Received: by 2002:a2e:7004:0:b0:299:c8c4:c9f1 with SMTP id l4-20020a2e7004000000b00299c8c4c9f1mr10719258ljc.8.1680530154972; Mon, 03 Apr 2023 06:55:54 -0700 (PDT) MIME-Version: 1.0 References: <20230403111020.3136-1-kirill.shutemov@linux.intel.com> <20230403111020.3136-2-kirill.shutemov@linux.intel.com> In-Reply-To: <20230403111020.3136-2-kirill.shutemov@linux.intel.com> From: Dmitry Vyukov Date: Mon, 3 Apr 2023 15:55:43 +0200 Message-ID: Subject: Re: [PATCH 1/2] x86/mm/iommu/sva: Fix error code for LAM enabling failure due to SVA To: "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CEB8C100019 X-Rspam-User: X-Stat-Signature: ta9hkyfbyx48sn8hj45do7hipfybea1i X-HE-Tag: 1680530156-578433 X-HE-Meta: U2FsdGVkX19DnZ3TlkssRwtiTHYgHZPDuCqyRRGmNYOvD06pigfkKpX//S2o0LUnS0nnj/QbO5DOpWi8lIh9D6DxDc+oboEZ37AKo5ovaU6kbY5/yF2J0TtNPQkCBoOxwt7U4EFyW1eUIsq0lEzyiVmY/ChetA0NQp2Oa3YcAuroI7WtZzPh19L013FaOkwV6VXZT+QcF2NFfj7OcJ33iux/JK6wzxpzsXoZJiI3FoDNKmgMrpW/Bn3PCi6D9HV7rdWj4UPpK4Rt+vWMZSai08L29b2YzHRFzakSx5jCpi6XVmqBS7+a0OyXwM5pFLLUtLyQ+QqVBlDws9AJt10Elt7npueEl0K9egcnOwk/pdbwr32INDBaXIPGSqQ0oPdjLHw4d9a1LLIihR7iQkHwbdMkrA7vnzNfv0jNgFetDZEhp7+F/Jt3ZLz/tKx7hUdNZTpGuCJ7tfqaxAz6kxdm2k6xqowuWdv7Iexz9F/cgCLwSgptXCxySJIJdZPVJH5aeoKLmjw8KSjqIWgDyx/9mXfvPoEEKpZfQDb5xTdB5Ry9TGUDLPWfBSQ8s219XTk0x37Qv7MEXppQupDhwY2/6/oNEctIM7qZ3lWyx1wD7VwzvKk2IwPecSYbHQJNTGTtY+vCDd/MNdk/bfbIfZaHk8v/G5TscNTRosgDvTsTdzgY63UMnohnYKLqCimlduU3lckUq5XzaN5mE8SEBmNWzWwKgLVGgbvP/JpSniL+5tM4YHAp8A9oXAYyTeErmsdPsOahirnUJ3FL8kqac1uv3SYqSzDM//k26ftYDNagwW8XpRDCqDAtSjjnZjAPuhN3t2ORHeqSC4tP/7RSxqyVEOjxNZFcq6cFmeZ0+g5VHkHwDeovJp2naSRDVLiq2RfHI4/ww+3ZhE+i/PgGZnkJokOUUiLu8C0gSkpcK0i7+mH+h+xcVptsZ7wWTTn7fpwbKO/lVbTuja13Dj3rksX WPk9ViQV ssF1n46aiN19r26sVjo3BTaRm2WUJ0C2ZMgzxUnoHrIfELNBynD5oj5WPUvVH7+7ur+u5izkZU2m4VsFzlV2egwR9iPNo5TCwViqZelJeZebjXIhRW2OfF9BYX2CSOWmlXmSueGimLkWvGEtzdGoElvN9xdFlT3mqcVAba/DIegIAsFzwKH11YDD8mb/ZQaEMT49Q6A1TpcdDGMXB8xW5F3UjbiDxh0xQ/BcPY/dV2lzPMmT8czkVWdwJIlqBpEqzOXgf6pEZ26GVNemTl3W6VXm0o0pFLXIG14U5AC5JhLvW5iqmNi3/iABYJzHurxSlWDmXkgkVCoRZaMsPu412qak1JGzSWypiZ+ymHCA5HHD3Tb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 3 Apr 2023 at 13:10, Kirill A. Shutemov wrote: > > Normally, LAM and SVA are mutually exclusive. LAM enabling will fail if > SVA is already in use. > > Correct error code for the failure. EINTR is nonsensical there. > > Signed-off-by: Kirill A. Shutemov > Fixes: 23e5d9ec2bab ("x86/mm/iommu/sva: Make LAM and SVA mutually exclusive") > Reported-by: Dmitry Vyukov Reviewed-by: Dmitry Vyukov > --- > arch/x86/kernel/process_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c > index 74c7e84a94d8..c7dfd727c9ec 100644 > --- a/arch/x86/kernel/process_64.c > +++ b/arch/x86/kernel/process_64.c > @@ -760,7 +760,7 @@ static int prctl_enable_tagged_addr(struct mm_struct *mm, unsigned long nr_bits) > > if (mm_valid_pasid(mm) && > !test_bit(MM_CONTEXT_FORCE_TAGGED_SVA, &mm->context.flags)) > - return -EINTR; > + return -EINVAL; > > if (mmap_write_lock_killable(mm)) > return -EINTR; > -- > 2.39.2 >