From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCDBC433C1 for ; Thu, 25 Mar 2021 18:35:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA57E61A39 for ; Thu, 25 Mar 2021 18:35:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA57E61A39 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C8DE6B006C; Thu, 25 Mar 2021 14:35:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 678AC6B006E; Thu, 25 Mar 2021 14:35:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F2CB6B0070; Thu, 25 Mar 2021 14:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 2F5176B006C for ; Thu, 25 Mar 2021 14:35:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CB63DA748 for ; Thu, 25 Mar 2021 18:35:07 +0000 (UTC) X-FDA: 77959248654.10.373AEAC Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf03.hostedemail.com (Postfix) with ESMTP id 3FC29C0007DB for ; Thu, 25 Mar 2021 18:35:06 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id v70so2777918qkb.8 for ; Thu, 25 Mar 2021 11:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ktz4pNsyMmw5FFMeMEqkr+bDgHdxIyIlPDtgBMB9GQg=; b=pKgRRTmXHDg2rpAcH1DUv2asXxqphFmsg4s6H5CmbxfKh3Ur7x4+if6AHxQPmdW2B4 qkJJrxV5p5SGt4y9PHR1er16MV5FZdY73ty56B9ZccI27ADVGprIUUhAVBbkuTZb+Fj0 wJ2XL0sQwliypPwKjLj3F3Gq0QCerU3jaLcpDf1MVj/NkVCi9nkWf/FuJZAgEtUiWPQu ndna050C3w33jdQK1zKfLys7CVocTZcw0TSdb+jtT6j0lM/baTrTkt3VKymFni8CKUv0 dhoGO5tnFs03UizsA/RCSvZJVA8HfUgowoZEy/iW4GEp6ogg3rfpExk1GQ4eJdmYCGUD UWOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ktz4pNsyMmw5FFMeMEqkr+bDgHdxIyIlPDtgBMB9GQg=; b=pKB9oxBeNsmTlA6/wFP+U07SjHocqhSQBZnXAwuYlyBSkbdhcjw3biIjzrnIYMrVaj Mba4bC9Xd+JwgRT9R1cEllasbhE4rrO5lFWeigf39SHZJaUtH3d/9LTK1eF0IhVS9K0f Wzj7ZBzuV/4dk/20FlHu/gVdqYqqU3VHo/frDESETw6K9BpG45Js0ZYxUAgt4ETO58or BLP3BL0XJbZ65KPs+JdFV7Svv37QP0GR1pjrptk7rYY6JmSUiooq3efIu7zyoXEJ9SRF cStDSfErYA4+XDinEXNMBhc2/ylYZtwm6kYT9KQIqOSO0XKuXJh9MaYVPMz8fWpxGa3/ 3sxg== X-Gm-Message-State: AOAM533GbSe3UYpHqWSPnWSA5Y5CLoufI5JiNHa+/aScMCpt10pILbxs hcQjsC3t+cFF6dYE720rdrVV9ttXYPqZgXw4aSvlKw== X-Google-Smtp-Source: ABdhPJy3q6VaMniItkA5pooxgheav1ONAkDpPz7IasHkdpjQn6IBCn/HffQyD/vyg6Nn2qzziG307gD6EJdIhpgqqeI= X-Received: by 2002:a05:620a:981:: with SMTP id x1mr9138045qkx.501.1616697306371; Thu, 25 Mar 2021 11:35:06 -0700 (PDT) MIME-Version: 1.0 References: <000000000000ce4c9505bdd4a48f@google.com> <20210325182046.GA15860@willie-the-truck> In-Reply-To: <20210325182046.GA15860@willie-the-truck> From: Dmitry Vyukov Date: Thu, 25 Mar 2021 19:34:54 +0100 Message-ID: Subject: Re: [syzbot] BUG: soft lockup in do_wp_page (4) To: Will Deacon Cc: syzbot , kernel-team@android.com, Andrew Morton , LKML , Linux-MM , syzkaller-bugs , Linux ARM , syzkaller Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1gc6jaa6uregmabrgyokfge7oijbh9us X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3FC29C0007DB Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-qk1-f170.google.com; client-ip=209.85.222.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616697306-812309 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 7:20 PM Will Deacon wrote: > > On Thu, Mar 18, 2021 at 08:34:16PM +0100, Dmitry Vyukov wrote: > > On Thu, Mar 18, 2021 at 8:31 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: bf152b0b Merge tag 'for_linus' of git://git.kernel.org/pub.. > > > git tree: upstream > > > console output: https://syzkaller.appspot.com/x/log.txt?x=17d5264ed00000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=2c9917c41f0bc04b > > > dashboard link: https://syzkaller.appspot.com/bug?extid=0b036374a865ba0efa8e > > > userspace arch: arm64 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+0b036374a865ba0efa8e@syzkaller.appspotmail.com > > > > > > watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [syz-executor.1:3684] > > > > +Will, arm > > > > If I am reading this commit correctly, this is caused by: > > > > commit cae118b6acc309539b33339e846cbb19187c164c > > Author: Will Deacon > > Date: Wed Mar 3 13:49:27 2021 +0000 > > arm64: Drop support for CMDLINE_EXTEND > > > > syzbot passes lots of critical things in CONFIG_CMDLINE: > > https://github.com/google/syzkaller/blob/c3c81c94865791469d376eba84f4a2d7763d3f71/dashboard/config/linux/upstream-arm64-kasan.config#L495 > > but also wants the bootloader args to be appended. > > What is the way to do it now? > > For now, there isn't a way to do it with CONFIG_CMDLINE, so I think you can > either: > > * Revert my patch for your kernels > * Pass the arguments via QEMU's -append option > * Take a look at one of the series which should hopefully add this > functionality back (but with well-defined semantics) [1] [2] Unfortunately none of these work for syzbot (and I assume other testing environments). syzbot does not support custom patches by design: http://bit.do/syzbot#no-custom-patches As any testing system, it tests the official trees. It's not humans who start these VMs, so it's not as easy as changing the command line after typing... There is no support for passing args specifically to qemu, syzkaller support not just qemu, so these things are specifically localized in the config. Additionally there is an issue of communicating all these scattered details to developers in bug reports. Currently syzbot reports the kernel config and it as well captures command line. Could you revert the patch? Is there any point in removing the currently supported feature before the new feature lands? > Sorry for the nuisance; I did try to fix this [3] but it's a bit of a > mess. > > Will > > [1] https://lore.kernel.org/linux-arch/cover.1614705851.git.christophe.leroy@csgroup.eu/ > [2] https://lore.kernel.org/linux-mips/20210308235319.2988609-2-danielwa@cisco.com/#t > [3] https://lore.kernel.org/r/20210225125921.13147-1-will@kernel.org