From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DFEC4360F for ; Tue, 5 Mar 2019 06:26:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62D232082C for ; Tue, 5 Mar 2019 06:26:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r9sQzt4Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62D232082C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB4FB8E0003; Tue, 5 Mar 2019 01:26:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3D9F8E0001; Tue, 5 Mar 2019 01:26:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A053C8E0003; Tue, 5 Mar 2019 01:26:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by kanga.kvack.org (Postfix) with ESMTP id 736C78E0001 for ; Tue, 5 Mar 2019 01:26:21 -0500 (EST) Received: by mail-io1-f69.google.com with SMTP id g3so6108406ioh.12 for ; Mon, 04 Mar 2019 22:26:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=mKVQnomC16pbW1flC8sH/PkvIYCtFQbG1KC4UWOn23Y=; b=nFEYtk2PUSI5WWlTqnsz1Kj4Bu3H3mn131e8+BOw2xQ0A0LoAXtZjDwchmyjhC76yo rMAJu4O2p14juYHyVGUGlZ+w0dPi+5DINdz/4vFM+d44cv8tlj5SBxUoLqK00+KZeoW2 3l8hZ9hnbU9n9z3M7yAQQP5mN1nBCZ7in2GaVeFBUMGW8EjdOAcY4rfMp5+Gh4/tozJ4 +FLQBCrQErNsi1PvZBvSwYA4FGAOtbLoMUsCuwihdjlN8uyLjHyCWj5nwLYkPP0ac49M nGhZARFPhy4KS8y743xZ8JXyohHrtNBSlhha9vAdHeJrObAIKQuK4VVCW67eGFDpjloY mVOQ== X-Gm-Message-State: APjAAAV0degyfoPhD9TvEUvJ1PO5RS8xJUuslgY8Zz1eFwU4AGnkXfD5 tQNBA02VFhMUCMABP1/UrluuW+BMRDY174WmTv8yh5G+mJ6q2PWM8g6uYwHBWSdwX/GPkB4/8Bl Hm45j/czeGLgjiidWn4CeIRRqH2bQtQim5+SwYxQA7VDBAREFaGl29/4a+Hwfyzm9lc0C/yUiu7 OkEy2dWZELL0w8OoMWmy0p2zltoGPNblEfkdqYDjxlSp9mfnrrEDW1UNI7ybGx8DsfutJhol1TW Rk+1X5nl7glur1g5E32kyUG66BFyt1k/2sRToC0uDn3YwLik35S3NNDNX7Q/GHv1iPK2JvJ5iPs +N1abqDbYLwn6ylvmYqfk/kk70wzAMXYmx41ngNv/kT3vgnb775NrA5F6Hq75h798IPzVz4+HzQ T X-Received: by 2002:a5d:93d9:: with SMTP id j25mr12671644ioo.305.1551767181096; Mon, 04 Mar 2019 22:26:21 -0800 (PST) X-Received: by 2002:a5d:93d9:: with SMTP id j25mr12671606ioo.305.1551767179757; Mon, 04 Mar 2019 22:26:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551767179; cv=none; d=google.com; s=arc-20160816; b=kriZEK35NVdJ6Gte5zF9xn4/AJ+TU2pbpq09WVh4XqxXX6sykJfqooo4fTBRU+wOOw mpfvgNx+v5+kNhN+I6oR+5aecOC1zX9wNhor2aOjaZGRjQZ6tdHhBavS5cl6LC17OC9H QYUDWrScMSNzicxEC/+XUuPkvz/pOe72Aq5bu6BoHUCG8MsgJ0rnq2oKYm83mJiT3mni MkSGjFwfgGV4FNtIE6CuXSwMU+7G51ScohyyTHG4cfjl59N0yInMiWpIOa9YAOXwxd0s 3rmoMXockxakyGc3drrodN4EaoVBETiFfMiER140e/4gyaiYMKNf2WHFCLobYF3S4rem akRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=mKVQnomC16pbW1flC8sH/PkvIYCtFQbG1KC4UWOn23Y=; b=l49CwIAnZE9gfqs8b5YT1DjWRoRsIyOGZ35uXxilFsMEugls1IveX07zHNtWfkXHV+ Uz/itUX+WZ/l+ifEMAOsQD0yCb1oj/wAW6EzecpCVvN07zM7o+eXaEiPiHTpN4M+jQyl ZsTgohGbNjG8kM5Ny8FccAphkj+oo38JMe6jCjoH4hGDhClkVD0YtFegPGV1S4t0MnPW U288lQ1Q3Q4VDfSdDXEw2zalPsS5plmk7cF/OVY1pORjRrWxmtF6xUCK39k/T13+xvzI 980I4S3WjZseAnjxuLfovJKkFi7tDNWVjZBSEIGf8o4exSueZmpWSxcSMgCP59oNpIOT J1Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=r9sQzt4Y; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l199sor14107284itb.13.2019.03.04.22.26.19 for (Google Transport Security); Mon, 04 Mar 2019 22:26:19 -0800 (PST) Received-SPF: pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=r9sQzt4Y; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKVQnomC16pbW1flC8sH/PkvIYCtFQbG1KC4UWOn23Y=; b=r9sQzt4Yef3cuCXx5ZORdAdB4+vkAYoJDipBDVEu7x9MVf4VBaOjxmQeCGPQntYH46 t8Nl5ZsyHKl06BobWvtHd8yd8RKZtncGAYMfEQgJnxfjHU2rgpLpIsQ8YFum8BdVYHOp I7X+FzPSrANbeGJdHuW/LV/TOhgLBsSDqRPpitvVtXqXE5I0qv1ZDhtEAOh7vvRPGUKW LYsp+a/bAitfPGREFe+nIigBHgIMcWTkdOuDLbsVONNXEqqQnY4Dfe20msG5tEood8hy SSs26lb83IBYZzwhvxZDraqwTZ5lUHFdrNYbKZYLjgmpl48VVXCD+IMTJI6aI9vkMJNG jWQA== X-Google-Smtp-Source: APXvYqwgmU4Gv9E0+QVs4mQgU6aFMKSYTn1D91QZdOgZSJzzJKXzWUh7PJJ/KC3Q2i251BAVGaLBsqGGQMatthEK5ic= X-Received: by 2002:a24:3b01:: with SMTP id c1mr1595031ita.144.1551767178993; Mon, 04 Mar 2019 22:26:18 -0800 (PST) MIME-Version: 1.0 References: <00000000000006457e057c341ff8@google.com> <5C7BFE94.6070500@huawei.com> <5C7D2F82.40907@huawei.com> <5C7D4500.3070607@huawei.com> In-Reply-To: <5C7D4500.3070607@huawei.com> From: Dmitry Vyukov Date: Tue, 5 Mar 2019 07:26:07 +0100 Message-ID: Subject: Re: KASAN: use-after-free Read in get_mem_cgroup_from_mm To: zhong jiang Cc: syzbot , Michal Hocko , Andrea Arcangeli , cgroups@vger.kernel.org, Johannes Weiner , LKML , Linux-MM , syzkaller-bugs , Vladimir Davydov , David Rientjes , Hugh Dickins , Matthew Wilcox , Mel Gorman , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote: > > On 2019/3/4 22:11, Dmitry Vyukov wrote: > > On Mon, Mar 4, 2019 at 3:00 PM zhong jiang wrote: > >> On 2019/3/4 15:40, Dmitry Vyukov wrote: > >>> On Sun, Mar 3, 2019 at 5:19 PM zhong jiang wrote: > >>>> Hi, guys > >>>> > >>>> I also hit the following issue. but it fails to reproduce the issue by the log. > >>>> > >>>> it seems to the case that we access the mm->owner and deference it will result in the UAF. > >>>> But it should not be possible that we specify the incomplete process to be the mm->owner. > >>>> > >>>> Any thoughts? > >>> FWIW syzbot was able to reproduce this with this reproducer. > >>> This looks like a very subtle race (threaded reproducer that runs > >>> repeatedly in multiple processes), so most likely we are looking for > >>> something like few instructions inconsistency window. > >>> > >> I has a little doubtful about the instrustions inconsistency window. > >> > >> I guess that you mean some smb barriers should be taken into account.:-) > >> > >> Because IMO, It should not be the lock case to result in the issue. > > > > Since the crash was triggered on x86 _most likley_ this is not a > > missed barrier. What I meant is that one thread needs to executed some > > code, while another thread is stopped within few instructions. > > > > > It is weird and I can not find any relationship you had said with the issue.:-( > > Because It is the cause that mm->owner has been freed, whereas we still deference it. > > From the lastest freed task call trace, It fails to create process. > > Am I miss something or I misunderstand your meaning. Please correct me. Your analysis looks correct. I am just saying that the root cause of this use-after-free seems to be a race condition. > >>>> On 2018/12/4 23:43, syzbot wrote: > >>>>> syzbot has found a reproducer for the following crash on: > >>>>> > >>>>> HEAD commit: 0072a0c14d5b Merge tag 'media/v4.20-4' of git://git.kernel.. > >>>>> git tree: upstream > >>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=11c885a3400000 > >>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=b9cc5a440391cbfd > >>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=cbb52e396df3e565ab02 > >>>>> compiler: gcc (GCC) 8.0.1 20180413 (experimental) > >>>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12835e25400000 > >>>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=172fa5a3400000 > >>>>> > >>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit: > >>>>> Reported-by: syzbot+cbb52e396df3e565ab02@syzkaller.appspotmail.com > >>>>> > >>>>> cgroup: fork rejected by pids controller in /syz2 > >>>>> ================================================================== > >>>>> BUG: KASAN: use-after-free in __read_once_size include/linux/compiler.h:182 [inline] > >>>>> BUG: KASAN: use-after-free in task_css include/linux/cgroup.h:477 [inline] > >>>>> BUG: KASAN: use-after-free in mem_cgroup_from_task mm/memcontrol.c:815 [inline] > >>>>> BUG: KASAN: use-after-free in get_mem_cgroup_from_mm.part.62+0x6d7/0x880 mm/memcontrol.c:844 > >>>>> Read of size 8 at addr ffff8881b72af310 by task syz-executor198/9332 > >>>>> > >>>>> CPU: 0 PID: 9332 Comm: syz-executor198 Not tainted 4.20.0-rc5+ #142 > >>>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > >>>>> Call Trace: > >>>>> __dump_stack lib/dump_stack.c:77 [inline] > >>>>> dump_stack+0x244/0x39d lib/dump_stack.c:113 > >>>>> print_address_description.cold.7+0x9/0x1ff mm/kasan/report.c:256 > >>>>> kasan_report_error mm/kasan/report.c:354 [inline] > >>>>> kasan_report.cold.8+0x242/0x309 mm/kasan/report.c:412 > >>>>> __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433 > >>>>> __read_once_size include/linux/compiler.h:182 [inline] > >>>>> task_css include/linux/cgroup.h:477 [inline] > >>>>> mem_cgroup_from_task mm/memcontrol.c:815 [inline] > >>>>> get_mem_cgroup_from_mm.part.62+0x6d7/0x880 mm/memcontrol.c:844 > >>>>> get_mem_cgroup_from_mm mm/memcontrol.c:834 [inline] > >>>>> mem_cgroup_try_charge+0x608/0xe20 mm/memcontrol.c:5888 > >>>>> mcopy_atomic_pte mm/userfaultfd.c:71 [inline] > >>>>> mfill_atomic_pte mm/userfaultfd.c:418 [inline] > >>>>> __mcopy_atomic mm/userfaultfd.c:559 [inline] > >>>>> mcopy_atomic+0xb08/0x2c70 mm/userfaultfd.c:609 > >>>>> userfaultfd_copy fs/userfaultfd.c:1705 [inline] > >>>>> userfaultfd_ioctl+0x29fb/0x5610 fs/userfaultfd.c:1851 > >>>>> vfs_ioctl fs/ioctl.c:46 [inline] > >>>>> file_ioctl fs/ioctl.c:509 [inline] > >>>>> do_vfs_ioctl+0x1de/0x1790 fs/ioctl.c:696 > >>>>> ksys_ioctl+0xa9/0xd0 fs/ioctl.c:713 > >>>>> __do_sys_ioctl fs/ioctl.c:720 [inline] > >>>>> __se_sys_ioctl fs/ioctl.c:718 [inline] > >>>>> __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 > >>>>> do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 > >>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe > >>>>> RIP: 0033:0x44c7e9 > >>>>> Code: 5d c5 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b c5 fb ff c3 66 2e 0f 1f 84 00 00 00 00 > >>>>> RSP: 002b:00007f906b69fdb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > >>>>> RAX: ffffffffffffffda RBX: 00000000006e4a08 RCX: 000000000044c7e9 > >>>>> RDX: 0000000020000100 RSI: 00000000c028aa03 RDI: 0000000000000004 > >>>>> RBP: 00000000006e4a00 R08: 0000000000000000 R09: 0000000000000000 > >>>>> R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006e4a0c > >>>>> R13: 00007ffdfd47813f R14: 00007f906b6a09c0 R15: 000000000000002d > >>>>> > >>>>> Allocated by task 9325: > >>>>> save_stack+0x43/0xd0 mm/kasan/kasan.c:448 > >>>>> set_track mm/kasan/kasan.c:460 [inline] > >>>>> kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553 > >>>>> kasan_slab_alloc+0x12/0x20 mm/kasan/kasan.c:490 > >>>>> kmem_cache_alloc_node+0x144/0x730 mm/slab.c:3644 > >>>>> alloc_task_struct_node kernel/fork.c:158 [inline] > >>>>> dup_task_struct kernel/fork.c:843 [inline] > >>>>> copy_process+0x2026/0x87a0 kernel/fork.c:1751 > >>>>> _do_fork+0x1cb/0x11d0 kernel/fork.c:2216 > >>>>> __do_sys_clone kernel/fork.c:2323 [inline] > >>>>> __se_sys_clone kernel/fork.c:2317 [inline] > >>>>> __x64_sys_clone+0xbf/0x150 kernel/fork.c:2317 > >>>>> do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 > >>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe > >>>>> > >>>>> Freed by task 9325: > >>>>> save_stack+0x43/0xd0 mm/kasan/kasan.c:448 > >>>>> set_track mm/kasan/kasan.c:460 [inline] > >>>>> __kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521 > >>>>> kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528 > >>>>> __cache_free mm/slab.c:3498 [inline] > >>>>> kmem_cache_free+0x83/0x290 mm/slab.c:3760 > >>>>> free_task_struct kernel/fork.c:163 [inline] > >>>>> free_task+0x16e/0x1f0 kernel/fork.c:457 > >>>>> copy_process+0x1dcc/0x87a0 kernel/fork.c:2148 > >>>>> _do_fork+0x1cb/0x11d0 kernel/fork.c:2216 > >>>>> __do_sys_clone kernel/fork.c:2323 [inline] > >>>>> __se_sys_clone kernel/fork.c:2317 [inline] > >>>>> __x64_sys_clone+0xbf/0x150 kernel/fork.c:2317 > >>>>> do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 > >>>>> entry_SYSCALL_64_after_hwframe+0x49/0xbe > >>>>> > >>>>> The buggy address belongs to the object at ffff8881b72ae240 > >>>>> which belongs to the cache task_struct(81:syz2) of size 6080 > >>>>> The buggy address is located 4304 bytes inside of > >>>>> 6080-byte region [ffff8881b72ae240, ffff8881b72afa00) > >>>>> The buggy address belongs to the page: > >>>>> page:ffffea0006dcab80 count:1 mapcount:0 mapping:ffff8881d2dce0c0 index:0x0 compound_mapcount: 0 > >>>>> flags: 0x2fffc0000010200(slab|head) > >>>>> raw: 02fffc0000010200 ffffea00074a1f88 ffffea0006ebbb88 ffff8881d2dce0c0 > >>>>> raw: 0000000000000000 ffff8881b72ae240 0000000100000001 ffff8881d87fe580 > >>>>> page dumped because: kasan: bad access detected > >>>>> page->mem_cgroup:ffff8881d87fe580 > >>>>> > >>>>> Memory state around the buggy address: > >>>>> ffff8881b72af200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > >>>>> ffff8881b72af280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > >>>>>> ffff8881b72af300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > >>>>> ^ > >>>>> ffff8881b72af380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > >>>>> ffff8881b72af400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > >>>>> ================================================================== > >>>>> > >>>>> > >>>>> . > >>>>> > >>>> -- > >>>> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > >>>> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > >>>> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/5C7BFE94.6070500%40huawei.com. > >>>> For more options, visit https://groups.google.com/d/optout. > >>> . > >>> > >> > > . > > > >