From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704CDC352A4 for ; Mon, 10 Feb 2020 07:28:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 331B221835 for ; Mon, 10 Feb 2020 07:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KzcOIJTh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 331B221835 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C75A96B00C8; Mon, 10 Feb 2020 02:28:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C27596B00C9; Mon, 10 Feb 2020 02:28:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63976B00CA; Mon, 10 Feb 2020 02:28:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 9D84A6B00C8 for ; Mon, 10 Feb 2020 02:28:07 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 22967181AC9C6 for ; Mon, 10 Feb 2020 07:28:07 +0000 (UTC) X-FDA: 76473388614.16.bear10_63f129db10e2b X-HE-Tag: bear10_63f129db10e2b X-Filterd-Recvd-Size: 3909 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 07:28:06 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id e21so422045qtp.13 for ; Sun, 09 Feb 2020 23:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9aJSYcVShjw9Lb0CxygRCx6IiLyoO1qzlgwQMvTtLho=; b=KzcOIJThFowfRliZtkVfRl6aidxfG7Hhy2CAIlPr2dOIiXnnvNCJD6PAejFWFmLfKI /S4y+W0xcK6BAYIPxVn5DrpPHMnpO8S6aihCp8+r5UdDg15xt3iuiOeXS3im+A3+a/w2 CMy8t6fiiAk7BXeWD6MoglyrOmAOd67NaSD+edivJXQAPLt+6hIJ8Bla4meSrPlSLapP hfuTqe1HFTjvht8kWu86WCpts4qiXUuqf7O3XmgpaR/lqZ7lBd9AYsqVMbzvMO94nPuV 3vgD0xDw7jyiAhiLV1+4tch70IY4ShQvTcia+iftk52MzXIS6kme4zix7f36CYAc5hFC pBPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9aJSYcVShjw9Lb0CxygRCx6IiLyoO1qzlgwQMvTtLho=; b=Gpr30jNy/n6AxgNVKMUekuR/dXzBl0m4TGKDHzReIWnyWtYnlbecO2l199r6M1VNNI frDBtN5Lfr8S1mFRiNYwKB2sIC5C0ETpN7jgClqoCOLb/A0JaaZ4nb49EcdMi4o/AZKF iCNKfQ0lyltc4Fe4MBJ5xpOgJwm0rarPIv6ue6ToWdOrSt7GW6Pu/4hURZrcK1f4Zmqa JztAXOU3Oksmjjgmo8w62XAk96JD0RcB9Jwp8WNRBqCXjDSVz/Ulp5AVllaiSeUlcHeF upGBqgl/YPj/qvwp3R6UgDh6yhTPHxS4jv8ZSyxpVfaF6S6zgKTchHK1fcSCHY4kV9uk 9C2A== X-Gm-Message-State: APjAAAUbj4CUy8LLrivoWHdgDmVW15sAKpkcYoQO9S/6f8nWm+EaL0eM XH+cIspvhm+nVI+/uFEgI5YxpUVVYHxhIXTzMYkhcQ== X-Google-Smtp-Source: APXvYqzvGDV8241QnMd0vtySTz+Ty3R182/wGhurUpRKMrSSEabtIWqt2bjsWn4Vbaon5w230yBnka5lvOVf+lLs/Z0= X-Received: by 2002:ac8:71d7:: with SMTP id i23mr9011849qtp.50.1581319685983; Sun, 09 Feb 2020 23:28:05 -0800 (PST) MIME-Version: 1.0 References: <1eca01a2537e0500f4f31c335edfecf0a10bd294.1581282103.git.jbi.octave@gmail.com> In-Reply-To: <1eca01a2537e0500f4f31c335edfecf0a10bd294.1581282103.git.jbi.octave@gmail.com> From: Dmitry Vyukov Date: Mon, 10 Feb 2020 08:27:55 +0100 Message-ID: Subject: Re: [PATCH 09/11] kasan: add missing annotation for start_report() To: Jules Irenge Cc: Boqun Feng , LKML , Linux-MM , kasan-dev , Andrew Morton , Alexander Potapenko , Andrey Ryabinin Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000393, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 9, 2020 at 11:48 PM Jules Irenge wrote: > > Sparse reports a warning at start_report() > > warning: context imbalance in start_report() - wrong count at exit > > The root cause is a missing annotation at start_report() > > Add the missing annotation __acquires(&report_lock) > > Signed-off-by: Jules Irenge Acked-by: Dmitry Vyukov > --- > mm/kasan/report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 5ef9f24f566b..5451624c4e09 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -77,7 +77,7 @@ static void print_error_description(struct kasan_access_info *info) > > static DEFINE_SPINLOCK(report_lock); > > -static void start_report(unsigned long *flags) > +static void start_report(unsigned long *flags) __acquires(&report_lock) > { > /* > * Make sure we don't end up in loop. > -- > 2.24.1 >