From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BF3C47255 for ; Mon, 11 May 2020 10:38:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A241B206E6 for ; Mon, 11 May 2020 10:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mqCzMPdN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A241B206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 35FAA90001F; Mon, 11 May 2020 06:38:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 336D9900006; Mon, 11 May 2020 06:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2744890001F; Mon, 11 May 2020 06:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 0F7E3900006 for ; Mon, 11 May 2020 06:38:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B80E78248047 for ; Mon, 11 May 2020 10:38:45 +0000 (UTC) X-FDA: 76804089810.21.swing00_4c76614ec0849 X-HE-Tag: swing00_4c76614ec0849 X-Filterd-Recvd-Size: 7300 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 May 2020 10:38:45 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id g16so6697144qtp.11 for ; Mon, 11 May 2020 03:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uf04Bplo4VLk4LrjpEdz9FsKxhkP+ZdN12Hn8z8gR3k=; b=mqCzMPdN1teGg+bTUJ01IQPzCKWAyY17rXaBqjFXSPbHfTK6eVvfpfhpRGaGtPu+so iv6Jd3DU9G0rPUCR44eqM9VMiVhXQIUY4PSxySOMunDn7pPZiNpTE8QVn0gklug4tYtL HhxyJGVKSCzbVbUBfSexUl29cX/iFDCHXNBoyFYW1CsI18YThM3pKlwl72PNt3AjZolH /avPwS+NyEJL+Kshm6XR1HRSQDQ5ObnJ37DttPS1Bh+ugYOMsAJGHM8M8aUCU/iGQ611 B2GlRrMt09krd7851/RYyF3ez8kweAYOugm5MtHHlGE2cFq18qlesvNwgwhgIwZ7MF18 notg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uf04Bplo4VLk4LrjpEdz9FsKxhkP+ZdN12Hn8z8gR3k=; b=R258IkEpxLvBNSGgcpJCmny+gH4B/B8bFTfwUSD4ECyOpbaxhbC0p4cifgPxRBCRgE xzUu6OjfvUzaPjOQFBeFtzzmrkUpfJzytEeoNfyCIyfkRWDfNLStcdQMdaWBO/9XTvGS lhn4bL6VAWuNcLN6YzMycxRUmR/P8G+NbJ7K3lCz3tdDv3AntTymp4/+GK1QQdMSa2BB 6mNDdavc7nFwnDnD9RDs7CCjU5bpklNnEjY4beeoCvAJfWi6u7ONrBRCgHGQ+ZIF3x4w /LeC6S5T+UMqW3mOI4gX9wemzQclVtcD8Py6IQcrrT6oXBD4P4US00UvTFXmM5FW9U1I DIXw== X-Gm-Message-State: AGi0PuY4jj9SHw5eCW3DuCgm2MlDrj+Nmgp/Xbm6uOEBT4LeWCLBdXNc /MlOuLLHzaQ/+IoRDWXaZtaRmUkBy1kb72WDMbGrCQ== X-Google-Smtp-Source: APiQypKA80aT7+91W0G/UAG3ToBMU16CEkrdAIjzMcXXPQQBDIf2vVmju/g34hV4WYzwqrhQjb6qWRfjMFJ+BMKUNlw= X-Received: by 2002:ac8:6c24:: with SMTP id k4mr15495561qtu.257.1589193524519; Mon, 11 May 2020 03:38:44 -0700 (PDT) MIME-Version: 1.0 References: <20200511022359.15063-1-walter-zh.wu@mediatek.com> <1589193126.2930.2.camel@mtksdccf07> In-Reply-To: <1589193126.2930.2.camel@mtksdccf07> From: Dmitry Vyukov Date: Mon, 11 May 2020 12:38:32 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] kasan: memorize and print call_rcu stack To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Matthias Brugger , "Paul E . McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Andrew Morton , kasan-dev , Linux-MM , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 11, 2020 at 12:32 PM Walter Wu wrote: > > On Mon, 2020-05-11 at 12:01 +0200, 'Dmitry Vyukov' via kasan-dev wrote: > > On Mon, May 11, 2020 at 4:24 AM Walter Wu wrote: > > > > > > This patchset improves KASAN reports by making them to have > > > call_rcu() call stack information. It is useful for programmers > > > to solve use-after-free or double-free memory issue. > > > > Hi Walter, > > > > I am looking at this now. > > > > I've upload the change to gerrit [1] > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458 > > > > I am not capable enough to meaningfully review such changes in this format... > > > > [1] https://linux.googlesource.com/Documentation > > > > Hi Dmitry, > > I don't fully understand your meaning, our patchset's format has > problem? or? No, it does not have any problems. Your patch format is standard for kernel. It's just complex patches in the standard kernel format that are hard to review for me. > > > The KASAN report was as follows(cleaned up slightly): > > > > > > BUG: KASAN: use-after-free in kasan_rcu_reclaim+0x58/0x60 > > > > > > Freed by task 0: > > > save_stack+0x24/0x50 > > > __kasan_slab_free+0x110/0x178 > > > kasan_slab_free+0x10/0x18 > > > kfree+0x98/0x270 > > > kasan_rcu_reclaim+0x1c/0x60 > > > rcu_core+0x8b4/0x10f8 > > > rcu_core_si+0xc/0x18 > > > efi_header_end+0x238/0xa6c > > > > > > First call_rcu() call stack: > > > save_stack+0x24/0x50 > > > kasan_record_callrcu+0xc8/0xd8 > > > call_rcu+0x190/0x580 > > > kasan_rcu_uaf+0x1d8/0x278 > > > > > > Last call_rcu() call stack: > > > (stack is not available) > > > > > > Generic KASAN will record first and last call_rcu() call stack > > > and print two call_rcu() call stack in KASAN report. > > > > > > This feature doesn't increase the cost of memory consumption. It is > > > only suitable for generic KASAN. > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > > [2]https://groups.google.com/forum/#!searchin/kasan-dev/better$20stack$20traces$20for$20rcu%7Csort:date/kasan-dev/KQsjT_88hDE/7rNUZprRBgAJ > > > > > > Changes since v2: > > > - remove new config option, default enable it in generic KASAN > > > - test this feature in SLAB/SLUB, it is pass. > > > - modify macro to be more clearly > > > - modify documentation > > > > > > Walter Wu (3): > > > rcu/kasan: record and print call_rcu() call stack > > > kasan: record and print the free track > > > kasan: update documentation for generic kasan > > > > > > Documentation/dev-tools/kasan.rst | 6 ++++++ > > > include/linux/kasan.h | 2 ++ > > > kernel/rcu/tree.c | 4 ++++ > > > lib/Kconfig.kasan | 2 ++ > > > mm/kasan/common.c | 26 ++++---------------------- > > > mm/kasan/generic.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > mm/kasan/kasan.h | 23 +++++++++++++++++++++++ > > > mm/kasan/report.c | 47 +++++++++++++++++++++-------------------------- > > > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > > > 9 files changed, 149 insertions(+), 48 deletions(-) > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200511022359.15063-1-walter-zh.wu%40mediatek.com. > > > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/1589193126.2930.2.camel%40mtksdccf07.