From: Dmitry Vyukov <dvyukov@google.com>
To: 20170315021431.13107-3-andi@firstfloor.org
Cc: Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error
Date: Thu, 16 Mar 2017 09:27:32 +0100 [thread overview]
Message-ID: <CACT4Y+asa7rDwjQi_09cYGsgqy0LFRRiCHq3=3t6__VUMLzmXg@mail.gmail.com> (raw)
In-Reply-To: <20170316044704.GA729@jagdpanzerIV.localdomain>
On Thu, Mar 16, 2017 at 5:47 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> Hello,
>
> commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line")
> moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic
> instrumentation [1] can't see it anymore
>
>
> In file included from ./arch/x86/include/asm/atomic.h:257:0,
> from ./include/linux/atomic.h:4,
> from ./include/asm-generic/qspinlock_types.h:28,
> from ./arch/x86/include/asm/spinlock_types.h:26,
> from ./include/linux/spinlock_types.h:13,
> from kernel/bounds.c:13:
> ./include/asm-generic/atomic-instrumented.h: In function ‘__atomic_add_unless’:
> ./include/asm-generic/atomic-instrumented.h:70:9: error: implicit declaration of function ‘__arch_atomic_add_unless’ [-Werror=implicit-function-declaration]
> return __arch_atomic_add_unless(v, a, u);
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
>
> so we need a declaration of __arch_atomic_add_unless() in arch/x86/include/asm/atomic.h
>
>
> [1] lkml.kernel.org/r/7e450175a324bf93c602909c711bc34715d8e8f2.1489519233.git.dvyukov@google.com
>
> -ss
Andi, why did you completely remove __arch_atomic_add_unless() from
the header? Don't we need at least a declaration there?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-16 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 4:47 Sergey Senozhatsky
2017-03-16 8:27 ` Dmitry Vyukov [this message]
2017-03-16 16:27 ` Andi Kleen
2017-03-16 16:41 ` Andi Kleen
2017-03-16 18:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACT4Y+asa7rDwjQi_09cYGsgqy0LFRRiCHq3=3t6__VUMLzmXg@mail.gmail.com' \
--to=dvyukov@google.com \
--cc=20170315021431.13107-3-andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox