From: Dmitry Vyukov <dvyukov@google.com>
To: Joel Fernandes <joelaf@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
syzbot <syzbot+8ec30bb7bf1a981a2012@syzkaller.appspotmail.com>,
Hugh Dickins <hughd@google.com>, Linux-MM <linux-mm@kvack.org>,
syzkaller-bugs@googlegroups.com
Subject: Re: possible deadlock in shmem_file_llseek
Date: Wed, 24 Jan 2018 19:40:10 +0100 [thread overview]
Message-ID: <CACT4Y+apdswWOB1XW6HsG+AUowVhozhO1ZeHDeCRBCkY8gkYfg@mail.gmail.com> (raw)
In-Reply-To: <20180124174723.25289-1-joelaf@google.com>
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
On Wed, Jan 24, 2018 at 6:47 PM, Joel Fernandes <joelaf@google.com> wrote:
>
> #syz test: https://github.com/joelagnel/linux.git test-ashmem
Oops, this email somehow ended up without Content-Type header, which
was unexpected on syzbot side. Now should be fixed with:
https://github.com/google/syzkaller/commit/866f1102f786c19a67e3857f891eaf5107550663
Let's try again:
#syz test: https://github.com/joelagnel/linux.git test-ashmem
[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 450 bytes --]
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 0f695df14c9d..248983cf2db1 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -343,7 +343,9 @@ static loff_t ashmem_llseek(struct file *file, loff_t offset, int origin)
goto out;
}
+ mutex_unlock(&ashmem_mutex);
ret = vfs_llseek(asma->file, offset, origin);
+ mutex_lock(&ashmem_mutex);
if (ret < 0)
goto out;
next prev parent reply other threads:[~2018-01-24 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 6:58 syzbot
2018-01-10 8:02 ` Dmitry Vyukov
2018-01-24 17:47 ` Joel Fernandes
2018-01-24 18:40 ` Dmitry Vyukov [this message]
2018-01-24 18:42 ` syzbot
2018-01-24 18:43 ` Dmitry Vyukov
2018-01-24 19:01 ` syzbot
2018-01-24 21:11 ` Joel Fernandes
2018-01-30 3:05 ` Joel Fernandes
2018-01-31 17:23 Joel Fernandes
2018-01-31 17:42 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+apdswWOB1XW6HsG+AUowVhozhO1ZeHDeCRBCkY8gkYfg@mail.gmail.com \
--to=dvyukov@google.com \
--cc=hughd@google.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+8ec30bb7bf1a981a2012@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox