From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A647C3B185 for ; Mon, 10 Feb 2020 07:27:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2DE420870 for ; Mon, 10 Feb 2020 07:27:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qdfc8f2F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2DE420870 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8F44A6B00C6; Mon, 10 Feb 2020 02:27:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4E56B00C7; Mon, 10 Feb 2020 02:27:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B9CB6B00C8; Mon, 10 Feb 2020 02:27:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 6298B6B00C6 for ; Mon, 10 Feb 2020 02:27:35 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DCF2C180AD804 for ; Mon, 10 Feb 2020 07:27:34 +0000 (UTC) X-FDA: 76473387228.17.loaf59_5f44452922d20 X-HE-Tag: loaf59_5f44452922d20 X-Filterd-Recvd-Size: 4039 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 07:27:34 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id a2so5076074qko.12 for ; Sun, 09 Feb 2020 23:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hzcZT/UWGik4t5gs1NKn0cClPiT0b3AGqVBvPjLWL6E=; b=Qdfc8f2FzV1RpB9MRVV1aynBc0H4QOGQa7h+tsu2mHtMP2jgv8n9U3W99cY4YIRUY8 KMfy1kcCCz46qL9KpDceFaN7MqeY2EzD91XBoxUOUT3pn1mp6gyahfqiu9l/3N1occ10 8yZgNjwyWTfCHVpIHIKd/kS8xQmCPfdoz3SwIqhtQzwPiFu/4WJozEf8ZNEgdW+Ab7Ri 2+4ZeToxtMvOoguvLIkHGh67Cws1wsv+FDNKcfgAcRUuS7N4tilt+mSmlMs1vPkZkJ5m 87mUdeqCAI3/Ic0J8EfS7p1e6ddEwNW6tPiSNND0e28k96CxJto9l4vpW4kS2VYgLS2b ZWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hzcZT/UWGik4t5gs1NKn0cClPiT0b3AGqVBvPjLWL6E=; b=A9yXZ8A+Cxln4BEy5LkjIynOaIxX2Lv4C4eK4WikcKW1PJtiF8u0lbC7ZXLufM+O4g UAkxjGHgL2EX09aIJBrk09hr5l3ToJW0/vu1D09Pq8D1LSFni6WurMgp4QSBHJ8anqXW 86CWwQKsjJeyc2Fx5qs8G9yYYubSmAYC2KcOQAVvZqNAbjVnMcbaPIRzk9TJned4ddKo KUMIGcPmQVk6AlQZK78tUTvDGGvtyi0JE1Vc7kKa0wrgMpAQxGhFaK2O3mkjH2edRVHa 8W179K1OziJzols9KlMZ5h/pz0HpenJdPewhtO7E+mtAKsZQkNrezd7V7Qz0LlAct3dl OmIQ== X-Gm-Message-State: APjAAAXPmqW53iJ/ITqnIO3W/nE32NrZxjQ5E+VxIMJ1mbx2ojZxnWl7 Ua2cmlZQDGVxq4GIop4PpPSVgFMOlaWWkUcg67+v2A== X-Google-Smtp-Source: APXvYqznkEYPuGUAjv0MkVzqxTC84niz0mOgxTbarhDOpdF3uqOqX4ys8UPmqfho/6vhZ/VaoLmcF0QjI31AfoyQRFw= X-Received: by 2002:a37:e30f:: with SMTP id y15mr180681qki.8.1581319653847; Sun, 09 Feb 2020 23:27:33 -0800 (PST) MIME-Version: 1.0 References: <38efa7c3a66dd686be64d149e198f2fddc3e7383.1581282103.git.jbi.octave@gmail.com> In-Reply-To: <38efa7c3a66dd686be64d149e198f2fddc3e7383.1581282103.git.jbi.octave@gmail.com> From: Dmitry Vyukov Date: Mon, 10 Feb 2020 08:27:22 +0100 Message-ID: Subject: Re: [PATCH 10/11] kasan: add missing annotation for end_report() To: Jules Irenge Cc: Boqun Feng , LKML , Linux-MM , kasan-dev , Andrew Morton , Alexander Potapenko , Andrey Ryabinin Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 9, 2020 at 11:49 PM Jules Irenge wrote: > > Sparse reports a warning at end_report() > > warning: context imbalance in end_report() - unexpected lock > > The root cause is a missing annotation at end_report() > > Add the missing annotation __releases(&report_lock) > > Signed-off-by: Jules Irenge Acked-by: Dmitry Vyukov > --- > mm/kasan/report.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 5451624c4e09..8adaa4eaee31 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -87,7 +87,7 @@ static void start_report(unsigned long *flags) __acquires(&report_lock) > pr_err("==================================================================\n"); > } > > -static void end_report(unsigned long *flags) > +static void end_report(unsigned long *flags) __releases(&report_lock) > { > pr_err("==================================================================\n"); > add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > -- > 2.24.1 >