From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F008C7618E for ; Mon, 24 Apr 2023 07:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1F46B0071; Mon, 24 Apr 2023 03:48:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A026B0074; Mon, 24 Apr 2023 03:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E058E6B0075; Mon, 24 Apr 2023 03:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA8F06B0071 for ; Mon, 24 Apr 2023 03:48:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86D71AC670 for ; Mon, 24 Apr 2023 07:48:54 +0000 (UTC) X-FDA: 80715508188.02.CD42C1D Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf28.hostedemail.com (Postfix) with ESMTP id 979D8C0003 for ; Mon, 24 Apr 2023 07:48:52 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="508/yBtl"; spf=pass (imf28.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682322532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sBn9MP8gsO/9Z4/eW6ATiLedWzLjSk/fKcpX7dMZveA=; b=Clo1gwYDMCAE8Z3QtJ3mnB/bSMTRVNYhcrvRdrkvTi4oDhRhnQTThRdlS7B812IF4goaXw +F2msHg4smNzRssawcJrc73wnz1aApGTv1y1JHCgh2m7glbijilRG7eabI89T+clNO5Red yWYvhXubNURx5NZR3UvlhPFH2cZNdiI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="508/yBtl"; spf=pass (imf28.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682322532; a=rsa-sha256; cv=none; b=lUOfs/wL44w3KkLSSfDvIsULlLUfu4KG2b0Ev1zPk68Xe0ujRNCAzSIBZITFIJVI919Spt 5+HzZN+JtMgzrGg5dzdFLPwnDBHtKh8FKaWpdFUpJRm3QMIBPt2wx3iJCrN0uBaQfNNZIo QAI2bNk5v5efw0CxR+Qm4T4rY+ZDKlo= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4efd5e4d302so4043e87.0 for ; Mon, 24 Apr 2023 00:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682322531; x=1684914531; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sBn9MP8gsO/9Z4/eW6ATiLedWzLjSk/fKcpX7dMZveA=; b=508/yBtlnonuvvT+/PvqrAjIjdJiOjGt/S0cx2WdIneDC1rDxi2GCj+P59chqtm3kr FsEh7PH8fWZJuMbuLUetNWWo5k7EzV8ZyhOBrxdEefOrunjivJ7ptpJyYkR8PNSpetDJ v5k8c+Wy1y2GyJeOYEp+PYbgiaQOJ7+IPQk27D8xKzB02Y5JL5f9WgTDeE1DzuupJz4t l95u6kRFu8DfB9PBQmGAa2HuHsTAwIQ4K/Cbc9w2HT+XGuzXeBGz21kc8KznUkfDGkbu BG+OUbwkvUXPlN4XMZLtuK/WIb2B/XfF5Dxf7RXKQNxpYc8dbXc57Nl04rBVsTy2CfNw pQyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682322531; x=1684914531; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sBn9MP8gsO/9Z4/eW6ATiLedWzLjSk/fKcpX7dMZveA=; b=LTqqtPY8cyJ5tLsU2xqu1GCVhFXxwbrQjqZsqCtd5VU9lZKAu1JkqYL9s4Ct9a/jAy 9Avw65MG4ff0MD1fZsb3W64GKjtdbOS6cjzJcYnqVWUV2Nz6JlvNMsecGWWzpdPTbFWA ppVSo88kucnsfYkg783wVQztgAF/RhjbQclNccNsCEO9mjulx5AQbBQ2usUPBknch/zg vh7vo2cQUFS7o2Ay2Q+QSKN2KUzmex9inul4lySHXdyuycx1N0VHfWeJbmj6nVFQR5Bm 4XFCc3KJv3QnLFqCqpeQ2FRFrAqBA68N4qo2yXksGIhCQIIQUDnBYWe50pTTb4lUe1S3 G8Ew== X-Gm-Message-State: AAQBX9cxmp1Xe6sDFFoDpx2rGTG5ok02hBBnrhumsmChItXWDvNOhfzf alHd3l1eHHI8F8lDzn607Fx8HyGj+s6ySxMddPxedw== X-Google-Smtp-Source: AKy350aQBjeLf7pGBQHnXgI4moJm5eqG1WAVCi9zY6m161Flll023f+bc0gDJapF0elzS0jIdPTFF8YsCe0xnS8l7T4= X-Received: by 2002:a05:6512:12ce:b0:4e8:3f1e:de43 with SMTP id p14-20020a05651212ce00b004e83f1ede43mr220567lfg.7.1682322530834; Mon, 24 Apr 2023 00:48:50 -0700 (PDT) MIME-Version: 1.0 References: <000000000000fb55ed05fa0fdb4b@google.com> In-Reply-To: <000000000000fb55ed05fa0fdb4b@google.com> From: Dmitry Vyukov Date: Mon, 24 Apr 2023 09:48:37 +0200 Message-ID: Subject: Re: [syzbot] [mm?] [fs?] KCSAN: data-race in __filemap_remove_folio / shmem_get_folio_gfp To: syzbot Cc: akpm@linux-foundation.org, hughd@google.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xbe8z9x1pfwp3yxtif5wbxn9378sfpks X-Rspamd-Queue-Id: 979D8C0003 X-HE-Tag: 1682322532-284839 X-HE-Meta: U2FsdGVkX1/oJXnZlqkZAal7+3Oeox0P65qORrdgNGIqUq0Nqarz8hHwhmTh2AVZDShKC+KP3ppyKsjDH/XXbgp+ifmZGc7zlEPWgnla9DJZUqmaWijdQYbL4CFdXdRIjeOmdbh/ehxFWgW/OUGl8m9Pxhv+cSYDvP2lgzPUxFhlvWpTl2qyPE7Fn7CKRfyR4f1Fi8nL0k5dV5vMZnZ0Byv0j7oEEXBbYHUcrdGDxe/E+Ok0TGc6ONRIUgFFNXkdFT4GHqg6V/xvWBOUITUwIPNEplS3RqfR/Af0KtChVsu2VgKT0TSlEiHoqTw1w6uI6xNhGeOHbQa+c+7c8tDBxmUfmlrOLWXU2tMw/1YxuzNzzuKltF9XdrmjqU+C5L5ySULtz95uYWJa4HTc7Ru3qZAbgLN6SuoLXUMsEb5BihvH/PWsV/RE4yHsBWVCbRSlE/YYrHLL+kshjop0Obo4ORi2Nk+ZxfNv0xMFv5P8FFqv6qIO2kdhEDpxUdV14kq5FlGnehykjUE5NZLLFX4eveKzh+GpXfM0DvZUpf0UwN1r/tlmF2fO2WOom1Gq0wzvg1xQq0ZfuOtAeMpxd6slv/yugI5T3yPX9bQJ9z8QY5KbaApbfAcu/HYMPg1eBUAp9Gt3CFjAaHlNSV8/S/DBUm/B49YvKxX1OA3nNqynOQJ7ZYNxM7q0VtLUVjJ6AAn8+pnjcjbFCrpxlyZ/vz9aAKvfcdibka6bT8f/yZfM9MQ8bDBdjmFt/9rPQqrNCcKdegSO971367rDCbXWwEYuHoCGFE9sjKMjO7G5C5NY08KhV3is08ll35v1sEqBbzn7seFSFGEDq51v3pWw13uGawK3f5aLa4UnsL7qSp3kLqrIWOTJaXZuj+Kt3ySIKPJ1lmgDw7etVUyH3SEzmZBMp3PHLUb4JyuswjoAVso18IHRzTU4UU2twRrcbXXHtRwWBRZ66yVQmMkdjG5DgYJ L2mdbB8j 5tsyeu8UZgeW6y+ueF2l9LCiwr3EgpbiSO1NHYR856hR+jIa+i3ORQBmRjHiaMZmP8NfnIRX7RYqD7zNyZCbIHuI6wJwsOXPwnahBuuXFVL2XppaTygcFq6AaHtZEN3/B9FkzHbR+DMh41beulFCtU0JCEIJZUH+AQNEgN2gFRTUnNVdA/YIdRB73XtYIYXR0b6yhRVMGt3ZUghH1svut+xTH8U4Sy72ksvqKgLSq4mSWBYV/e3zed0TB/LKsSsZJzMM9Y1xStl+wKYqHI41bjHnbIQMlTnkjBwabYHqCT1iyoUd55DbyC08hBnzU+c52kw3uQDMxJ07YJvlU/AI5feCLzdCz0l86xTfYM4TPGzLI+APth9jyTHtsXdQ2CSx8id2uZfu79nABLUiY/ehN2RoJTskVbNHvg/i4A7v9xKN1FQQnxBDclqctMtVcvWWgjnIll4J0GZNb1ue0MM8ZzrEFrH9rRKmXCtE5y+7oG+01a1yvGbsU2mqhsw9NShwb277WxrIJ1cGvZoFlrq9l6Tg4Cr3yFS2naOZGBjR3j+q48JH8eCgl6eFF8RQxFS5Czg8SZjHLPyGdAzZNgpXFG5dls8N3r2jubUQW7et9gTd5ahtrsHwBsEKDilWobdZvweOV9POh1bTXoAkArTGfB0BiAVbv+X6rU0NLx9+DnkJWfNX6IYICzWlyd2qQ2xnqLIjrYFTOIjMI9vWASYV9rB1gacMIriqYdcktKYnWzLR6SyI831v9NE1kryijZW+E9ODNjEwyvwIvVYqLp1mzYsQwq//NCQYhGWFaJ8iHEirtj4LMjLbSYfhjt5LPiHMlcRlhoXfy2b4NJnF6ZH1dsgoq5loFvMW8qp94gDfEtoL9YCsmXgEYuPDmQQBYFcGjvNFzVU607JvUx9Z5xVBTR3rY/Jwj/jS48vUEnU3II3j3QpYQnAjtHBBP0ITKCmy6rgPQG8o/fml0DwKQkvaUQRHLlryV QxL+BJ39 aSjnZ84x4bmVYtJpEIKuaf4BeGSoTi7MUo0JbEFVx78Oz/L5rg+4ZM1E7Wq5nc0pIv6ICkSz9j2Pne74aOtMmmmqVXdtrA3X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Apr 2023 at 09:21, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: cb0856346a60 Merge tag 'mm-hotfixes-stable-2023-04-19-16-3.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=170802cfc80000 > kernel config: https://syzkaller.appspot.com/x/.config?x=fa4baf7c6b35b5d5 > dashboard link: https://syzkaller.appspot.com/bug?extid=ec4650f158c91a963120 > compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/a02dd7789fb2/disk-cb085634.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/a1a1eac454f6/vmlinux-cb085634.xz > kernel image: https://storage.googleapis.com/syzbot-assets/bb0447014913/bzImage-cb085634.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+ec4650f158c91a963120@syzkaller.appspotmail.com shmem_recalc_inode() has a check for "freed > 0", but I think it can be violated due to this race, if i_mapping->nrpages is read twice. If there are concurrent modifications, the code should use at least READ/WRITE_ONCE for accesses. > ================================================================== > BUG: KCSAN: data-race in __filemap_remove_folio / shmem_get_folio_gfp > > read-write to 0xffff888136bf8960 of 8 bytes by task 19402 on cpu 1: > page_cache_delete mm/filemap.c:147 [inline] > __filemap_remove_folio+0x22f/0x330 mm/filemap.c:225 > filemap_remove_folio+0x6c/0x220 mm/filemap.c:257 > truncate_inode_folio+0x19f/0x1e0 mm/truncate.c:196 > shmem_undo_range+0x24d/0xc20 mm/shmem.c:942 > shmem_truncate_range mm/shmem.c:1041 [inline] > shmem_fallocate+0x2fc/0x8d0 mm/shmem.c:2779 > vfs_fallocate+0x369/0x3d0 fs/open.c:324 > madvise_remove mm/madvise.c:1001 [inline] > madvise_vma_behavior mm/madvise.c:1025 [inline] > madvise_walk_vmas mm/madvise.c:1260 [inline] > do_madvise+0x77b/0x28a0 mm/madvise.c:1439 > __do_sys_madvise mm/madvise.c:1452 [inline] > __se_sys_madvise mm/madvise.c:1450 [inline] > __x64_sys_madvise+0x60/0x70 mm/madvise.c:1450 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > read to 0xffff888136bf8960 of 8 bytes by task 19400 on cpu 0: > shmem_recalc_inode mm/shmem.c:359 [inline] > shmem_get_folio_gfp+0xc0a/0x1120 mm/shmem.c:1977 > shmem_fault+0xd9/0x3d0 mm/shmem.c:2152 > __do_fault mm/memory.c:4155 [inline] > do_read_fault mm/memory.c:4506 [inline] > do_fault mm/memory.c:4635 [inline] > handle_pte_fault mm/memory.c:4923 [inline] > __handle_mm_fault mm/memory.c:5065 [inline] > handle_mm_fault+0x115d/0x21d0 mm/memory.c:5211 > faultin_page mm/gup.c:925 [inline] > __get_user_pages+0x363/0xc30 mm/gup.c:1147 > populate_vma_page_range mm/gup.c:1543 [inline] > __mm_populate+0x23a/0x360 mm/gup.c:1652 > mm_populate include/linux/mm.h:3026 [inline] > vm_mmap_pgoff+0x174/0x210 mm/util.c:547 > ksys_mmap_pgoff+0xc5/0x320 mm/mmap.c:1410 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > value changed: 0x0000000000000437 -> 0x0000000000000430 > > Reported by Kernel Concurrency Sanitizer on: > CPU: 0 PID: 19400 Comm: syz-executor.3 Not tainted 6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 > ================================================================== > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > -- > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/000000000000fb55ed05fa0fdb4b%40google.com.