From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E9BC77B76 for ; Fri, 21 Apr 2023 14:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C46066B0075; Fri, 21 Apr 2023 10:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF5666B0078; Fri, 21 Apr 2023 10:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD606B007B; Fri, 21 Apr 2023 10:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D81F6B0075 for ; Fri, 21 Apr 2023 10:43:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 74890C073B for ; Fri, 21 Apr 2023 14:43:35 +0000 (UTC) X-FDA: 80705666790.18.D70AB4C Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf16.hostedemail.com (Postfix) with ESMTP id 9074318001D for ; Fri, 21 Apr 2023 14:43:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="vfAbBNK/"; spf=pass (imf16.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682088213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8B725ZBKfP0GpWx9JPfGFqkXbZvh/CpPapZ/L8/4CIg=; b=bs5Bn9VZTmPCa+9S+9TLRHgvhmZtdoq3oFn8lPe2ObNAzyvf9T/2v4reIZ1MHKLO0USth3 fBcYxhXk2ia0KBBIkviAbBnlQoBo7TjAEJjbvH8AhzwDMW25ssH9tvEL9QqohnlXe8o12g hA8YbDhegXVzcG8F4jbvYHPNG5ymYuI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="vfAbBNK/"; spf=pass (imf16.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682088213; a=rsa-sha256; cv=none; b=6Ue72KIO+XcvcIUY/XdEK90hZMrq9rCCahJ984jMtw5++/k/ll/giLqjNrLmplIQXx6UvV n3N0GFvWgIUDn3B7+sbjoCMAIg49uUeV9GwjelGLbF0nCmzfn80O6LEGYLegB/NNmMtK05 quSd7qkWgxMQSVTPNEjJD6m1crkt5g8= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4ecb7fe8fb8so7036e87.0 for ; Fri, 21 Apr 2023 07:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682088212; x=1684680212; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8B725ZBKfP0GpWx9JPfGFqkXbZvh/CpPapZ/L8/4CIg=; b=vfAbBNK/+7FEiarLloglLl9iO8FTuYu+DqjWSf1EILAEkpr/+RBkwZVWJpJiwz3O2w lZAFTrwKio3jZyQKQtc470ZsIRvz7dqV+4FYhWi+ycNv1Cmr61/d3PASWu3I4rsI267U SwhwivkYP4Lm+x6AKgkv6z5kMY17enk2SCRkaZZPatYuVT0jFFeKbnOjgjYPv5qodA5D kLYikZQKJmJjMUWj+y94YZ1pmg7HgNlPys+sI0FSrdXR23dGz6qhjYupAB8V2uamfuCo oiz3ci1vlDssHste7IM3UV+NolCsno7yAYGHFYCwiJWVOq9VRavVUbA9WMg+7hjTUesw hKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682088212; x=1684680212; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8B725ZBKfP0GpWx9JPfGFqkXbZvh/CpPapZ/L8/4CIg=; b=SqHSPWaFPJDDmU4lKAlZ/LPdjxavcbqVmQakRQR41BNoUhXcS3FG14AYPqNINhR89t HIOkp3pewRfAkzsm8FLraAgN/jG6usITsnW7SxEHTHoTw04k6XYaNVvJ9Z9hnBGMu3+J uHHkmNgsrTLw3Lbv3o2uAaCrc0in170C+59scH+vEkXS7wWrodfXUQPNwwxZGhfYj/4A hNOHV2Cc6uYQgc8OxK2gz8Nwp/z1ZK0ivPeVYogUlUhtqMFeOVsS6SKs1wVoJPfwIUzk cEsZeVS/GoHH7PJF47OCdSwu43XkJ5oJcQ1w7Ds8aC+QY+lEQvLXTvnzC6Rf1u1heL91 rSHQ== X-Gm-Message-State: AAQBX9fpKVuPvzP0C8w4f6F67KrL+HG4RM3Jh89Ov8e5nQSHEq34BN+G JF+AdaxsNdctc52v5wz/L6eVaT7P58rN6B4g6JTyiA== X-Google-Smtp-Source: AKy350ZgFLgjPf0keMqVaZ2XCOPWr5zcEJMuWlapT5bkkYcpH7oSDLcOJm/h5S8depl9UFnyNz5jzxG+9P31BBCsJ4Y= X-Received: by 2002:a05:6512:1319:b0:4e9:d785:37cb with SMTP id x25-20020a056512131900b004e9d78537cbmr123998lfu.1.1682088211800; Fri, 21 Apr 2023 07:43:31 -0700 (PDT) MIME-Version: 1.0 References: <000000000000b9915d05f9d98bdd@google.com> In-Reply-To: <000000000000b9915d05f9d98bdd@google.com> From: Dmitry Vyukov Date: Fri, 21 Apr 2023 16:43:19 +0200 Message-ID: Subject: Re: [syzbot] [ext4?] [mm?] KCSAN: data-race in strscpy / strscpy (3) To: syzbot Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, nathan@kernel.org, ndesaulniers@google.com, syzkaller-bugs@googlegroups.com, trix@redhat.com, tytso@mit.edu, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , martin.lau@linux.dev, bpf , KP Singh Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9074318001D X-Stat-Signature: w6obqamujawa38a49178fzwx59rnsp5h X-HE-Tag: 1682088213-363002 X-HE-Meta: U2FsdGVkX19qlF5C4w8LEbiH+OWXvaDE/fpmWONN+J4GL6GHyUKbzQGpJsmgm/gfy3aXAHFK3EP18m7gqARk1MxHACl4DF+saNV2hXN2UzIb2PVKUwdMpwW2U5BSD+wP9zS1YPc8iSx4tD8rX4Zy8u0mUo6ZPZQ5rPvlPHnP6KQOMNu2ob827+OGA3Sqk9I69nqb2gfhBq1iO8RcTJhHG6GsLcv92U1p6cE+0GefztyC4aATnd/4vI2C/vNXvNiheGEjT9BIbail8ECYxwTHLc249x+5wVYadQ3F+ySRNhoq7qrJc+EIMNesMkDIlikf1dvwz5jKtdYMBk9Us0JOfLFItuHnVLbRxRjvnfhu3uBIvfVs/Yypy8my31UDALuWRQI/9Jln7NWDSe7sYy9jD3ricfriV6FBDZXz4/kn/gTWkUfAmKzJy2vLGEFbiMV1GRfidpaQj0/2yKUDe1e2G+PH6uilvwkbRUO1fIOThgBQNrNkb4OoKvPBX+qDNXMhk860OssTPxef5L7BnofM9MfI7+S8WL431z1QHc4kaB9Aet8AqtEymDh/Iba79kbEvbKxntWudVPluyKSnQp1RsrFb2c3gGAtz6LcaAX4uCT8+Xe3VsrljQNvfiHvsqOG4OpM7ckWKfSQVSgfpeExfgvcLUsQqrCML8r8QsTFgFb1xTj65EIzIKMjB0bP6QOwOEg1SGV5d+sxpUEBTfG31vjZwnEqHEbRwXLdOlkTMqv//yqKsz0vIKJ5IE3aL6VZ7CutYOoGh3c2AE4fsRgx+Q/LVIkygw+zhiVKIXCWow/bVoBvGDmL84YrnnbkRBbCQA7mDDUgd1Srno72bDfy4IE+hmHa4/BppZcBbXzG7dhyLsBALD0xOHJJdIQNdEXWigZwS/5YXVP5jwhx/ZtsyqsvqcROmP6phfPHfM1U3R142BeqsTXOq0x3Z2PSJMfDcLPxFsw5c6qZFSeiFW5 sVCiQOQA nDrZ44gMBZ+59i/QiIeYP8rv62ItkkM2cVb/6axyZa6+8U1jS2Rb12ACkszaBaB/JWItkhcGGbv/WV47v0x7jo4wIetJclxxTiW12CuTE+5keAQuDAWSdSOIGDN5nQ4+HfHw0CPTh58Go8QGdk+eRghfClHFcyYALaIwpF0X9W73w5DAABX2WNcka0kt1SXwLSwAXLjHo0xqfc56Ry7W0gb3VkOu/ZOo54nfzEcXv7lwyFqs9eYRxvFvMu3up3KIvweT52kpqOGecPGUhjqTYz1Ct/JMQZI+2gywuYeLxpAsUt5keInsCltqKE6EaDOyUWVv76aOCzN5+0XjW8YacZ0lKO/juSpUbAWQzAogOGYppSMK4yvwZe88Ey3RfBWJci9pGbjjQ2CaAV1f5sHdmowdViYrWeFGpI68et9kgrc2wdLVGNc+EbkhrhIUuAWQi0uB+8xjLQKxVIjRWbkkrRCOCYwEBWPadhYTvtr2QArRpHFfT90zf5aw0SnODO4v9sunZPrrwdsDBlmA49Q8GBVaEacZPHbwpMZOkvVl/2oMY4pCHwRpUvA4sC7C3kgkme4WG3LYg2YQJMGruvh4HVqy8cT3XAD9Cpcq+7DcAvN+l9pBhOSjS1lNQKm29T9OokLv74IiINGfsQkBa6jNrApwv3I3j2UeIw1ol3axZKuqcTEeXQl1Kppwsd+JcFqu9sUuQ+Za38GVZFaESN7XiW0UkpZjWivyPXu+d2LRnTIrTSBisAADWF00ZUV/Qv6IS5GnIo/LiBtAT+nJTELJiYxnrSgDb+E5dlBe61vXo80iOoiNDCozL4BV7WzAxqvlLatWnCIsjCj2c5x89Y6SJ67h4NeULPpqlnhW04lKgR/AjbY1Cocsbvfc0OmGKSz++K55K2BJXh/EhxLHZL5rRd8NrclxV31QrTyfVpK7tsqMHPQWBZljkYbtSttB4K/G7d1HEhgr68NnGhobdn4L2AlH8VgDb ERSwpBPn v8HWELO1xd0cpBsWb7kfPoYLdq/7iy1m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 21 Apr 2023 at 16:33, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: 76f598ba7d8e Merge tag 'for-linus' of git://git.kernel.org.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=133bfbedc80000 > kernel config: https://syzkaller.appspot.com/x/.config?x=9c5d44636e91081b > dashboard link: https://syzkaller.appspot.com/bug?extid=c2de99a72baaa06d31f3 > compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/a3654f5f77b9/disk-76f598ba.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/abfb4aaa5772/vmlinux-76f598ba.xz > kernel image: https://storage.googleapis.com/syzbot-assets/789fb5546551/bzImage-76f598ba.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+c2de99a72baaa06d31f3@syzkaller.appspotmail.com +bpf maintainers If I am reading this correctly, this can cause a leak of kernel memory and/or crash via bpf_get_current_comm helper. strcpy() can temporary leave comm buffer non-0 terminated as it terminates it only after the copy: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/string.c?id=76f598ba7d8e2bfb4855b5298caedd5af0c374a8#n184 If bpf_get_current_comm() observes such non-0-terminated comm, it will start reading off bounds. > ================================================================== > BUG: KCSAN: data-race in strscpy / strscpy > > write to 0xffff88812ed8b730 of 8 bytes by task 16157 on cpu 1: > strscpy+0xa9/0x170 lib/string.c:165 > strscpy_pad+0x27/0x80 lib/string_helpers.c:835 > __set_task_comm+0x46/0x140 fs/exec.c:1232 > set_task_comm include/linux/sched.h:1984 [inline] > __kthread_create_on_node+0x2b2/0x320 kernel/kthread.c:474 > kthread_create_on_node+0x8a/0xb0 kernel/kthread.c:512 > ext4_run_lazyinit_thread fs/ext4/super.c:3848 [inline] > ext4_register_li_request+0x407/0x650 fs/ext4/super.c:3983 > __ext4_fill_super fs/ext4/super.c:5480 [inline] > ext4_fill_super+0x3f4a/0x43f0 fs/ext4/super.c:5637 > get_tree_bdev+0x2b1/0x3a0 fs/super.c:1303 > ext4_get_tree+0x1c/0x20 fs/ext4/super.c:5668 > vfs_get_tree+0x51/0x190 fs/super.c:1510 > do_new_mount+0x200/0x650 fs/namespace.c:3042 > path_mount+0x498/0xb40 fs/namespace.c:3372 > do_mount fs/namespace.c:3385 [inline] > __do_sys_mount fs/namespace.c:3594 [inline] > __se_sys_mount+0x27f/0x2d0 fs/namespace.c:3571 > __x64_sys_mount+0x67/0x80 fs/namespace.c:3571 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > read to 0xffff88812ed8b733 of 1 bytes by task 16161 on cpu 0: > strscpy+0xde/0x170 lib/string.c:174 > ____bpf_get_current_comm kernel/bpf/helpers.c:260 [inline] > bpf_get_current_comm+0x45/0x70 kernel/bpf/helpers.c:252 > ___bpf_prog_run+0x281/0x3050 kernel/bpf/core.c:1822 > __bpf_prog_run32+0x74/0xa0 kernel/bpf/core.c:2043 > bpf_dispatcher_nop_func include/linux/bpf.h:1124 [inline] > __bpf_prog_run include/linux/filter.h:601 [inline] > bpf_prog_run include/linux/filter.h:608 [inline] > __bpf_trace_run kernel/trace/bpf_trace.c:2263 [inline] > bpf_trace_run4+0x9f/0x140 kernel/trace/bpf_trace.c:2304 > __traceiter_sched_switch+0x3a/0x50 include/trace/events/sched.h:222 > trace_sched_switch include/trace/events/sched.h:222 [inline] > __schedule+0x7e7/0x8e0 kernel/sched/core.c:6622 > schedule+0x51/0x80 kernel/sched/core.c:6701 > schedule_preempt_disabled+0x10/0x20 kernel/sched/core.c:6760 > kthread+0x11c/0x1e0 kernel/kthread.c:369 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 > > value changed: 0x72 -> 0x34 > > Reported by Kernel Concurrency Sanitizer on: > CPU: 0 PID: 16161 Comm: ext4lazyinit Not tainted 6.3.0-rc5-syzkaller-00022-g76f598ba7d8e #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 > ================================================================== > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot.