From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDF3C4363A for ; Wed, 28 Oct 2020 10:58:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A945724691 for ; Wed, 28 Oct 2020 10:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cbY/uyv1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A945724691 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 10D086B0062; Wed, 28 Oct 2020 06:58:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A516B0068; Wed, 28 Oct 2020 06:58:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC7026B006C; Wed, 28 Oct 2020 06:58:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id BC9236B0062 for ; Wed, 28 Oct 2020 06:58:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 523848249980 for ; Wed, 28 Oct 2020 10:58:06 +0000 (UTC) X-FDA: 77421034572.01.glove26_070b00e27284 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 2E9B1100480B7 for ; Wed, 28 Oct 2020 10:58:06 +0000 (UTC) X-HE-Tag: glove26_070b00e27284 X-Filterd-Recvd-Size: 4899 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 10:58:05 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id a23so4017792qkg.13 for ; Wed, 28 Oct 2020 03:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EA88P84wG7kGfxM9G+4L3+CwyjZDcOPZBnLgcdYKwco=; b=cbY/uyv1cCh6c4oVgWj/70SyO8pIWpjKKYS24jIL8ftPfO8BZWFXtfKrzozYnJCUaJ eJKpqiICo94HYV9FZPpoIl9y1TYV/HUPAuccmo2xG6x97wDJN2wNPhkHcV/PmQoLTBAO opk2srUWE6ryeNqyO1otV0FCocX0IWzROBPY0aNwK9bwWbjajVs+7NwgVL4pOYUHAISo bvPV6EQ2ItsFWRI4fcbRGpdI+PFF2frNS7z/9TnVlSGOj7HLj/pnRmz/kADfKvRDVkJ3 U6xDnw758nFkmx+UvIe37zMR3saHZ9/sPhYH68otLUJHA2QZ28A3E/79TV/oQlnxeIT7 ZUlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EA88P84wG7kGfxM9G+4L3+CwyjZDcOPZBnLgcdYKwco=; b=LNHZF7yw935/V4ciAm7g5O9mRR39oiX8jVBkua1aOgOUukb75iDVNqtXmnDMd0Wd9c czzGC7GGdJlKWpONQyiI50YEuICEOYViVyMmr9rTlv5W4FAsZ/lr7EMJX09A2Ntt7yVq nOAJHUx2616dmfJQNjqhenvhuWI2bfnTlNdjgS8FpoKHS3EBuUT8rio+KlrQv6YaYknU 6gHjQ5Fp2fyDCFm18ufi+kEj3/WEWjd8R4ca/DB/IMZapVWfT3GkwgRc6oz+TYKplxTp axxOBQE/sUluMY2JVeJR2MWGVJ11g5Bpw6ZIKxT++hV7p8RgBsTZ2a8Ko6XYkvB9Z0Mv 088g== X-Gm-Message-State: AOAM531qMYeYgJlKameLqEsixvcfYf52HJFS6w0/6VD0fe9BGjt93fLE NUR5ZWSQicnyAlNTXTeOP1hAxSwNFse1MmevESy0DQ== X-Google-Smtp-Source: ABdhPJxTS7XfOF1hOSGhrrT3dGmt5XHhPd9PotQKYgC0JpwNp0z3cpU1oZp83OQvirnXXXWdiSnJmLOpSs1e8J3LLtw= X-Received: by 2002:a37:a00c:: with SMTP id j12mr799887qke.231.1603882684633; Wed, 28 Oct 2020 03:58:04 -0700 (PDT) MIME-Version: 1.0 References: <84dc684519c5de460c58b85f0351c4f9ab57e897.1603372719.git.andreyknvl@google.com> In-Reply-To: <84dc684519c5de460c58b85f0351c4f9ab57e897.1603372719.git.andreyknvl@google.com> From: Dmitry Vyukov Date: Wed, 28 Oct 2020 11:57:53 +0100 Message-ID: Subject: Re: [PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > There's no need for __kasan_unpoison_stack() helper, as it's only > currently used in a single place. Removing it also removes undeed > arithmetic. > > No functional changes. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/Ie5ba549d445292fe629b4a96735e4034957bcc50 Reviewed-by: Dmitry Vyukov > --- > mm/kasan/common.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index a3e67d49b893..9008fc6b0810 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -59,18 +59,12 @@ void kasan_disable_current(void) > #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > #if CONFIG_KASAN_STACK > -static void __kasan_unpoison_stack(struct task_struct *task, const void *sp) > -{ > - void *base = task_stack_page(task); > - size_t size = sp - base; > - > - kasan_unpoison_memory(base, size); > -} > - > /* Unpoison the entire stack for a task. */ > void kasan_unpoison_task_stack(struct task_struct *task) > { > - __kasan_unpoison_stack(task, task_stack_page(task) + THREAD_SIZE); > + void *base = task_stack_page(task); > + > + kasan_unpoison_memory(base, THREAD_SIZE); > } > > /* Unpoison the stack for the current task beyond a watermark sp value. */ > -- > 2.29.0.rc1.297.gfa9743e501-goog >