From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874F1C433E0 for ; Tue, 23 Jun 2020 08:31:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E03E2072E for ; Tue, 23 Jun 2020 08:31:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pyp7tjOJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E03E2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8870E6B0002; Tue, 23 Jun 2020 04:31:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 836AD6B0005; Tue, 23 Jun 2020 04:31:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7260B6B0006; Tue, 23 Jun 2020 04:31:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 5863F6B0002 for ; Tue, 23 Jun 2020 04:31:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BD88A181AC9BF for ; Tue, 23 Jun 2020 08:31:45 +0000 (UTC) X-FDA: 76959808170.05.lake41_6307eb726e3a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 9CA1C180000F5 for ; Tue, 23 Jun 2020 08:31:45 +0000 (UTC) X-HE-Tag: lake41_6307eb726e3a X-Filterd-Recvd-Size: 7465 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 08:31:45 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id u17so14807516qtq.1 for ; Tue, 23 Jun 2020 01:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HCA63Bq1RhuGBZe+uCuPvGnPrsrwVNbQ3GCsOT/wmUM=; b=pyp7tjOJLOow1mDmvUgdLzldCixoa3daJpceZRVRHM+OzpQ/SmxfXvKTg7TPGpWZ0h w9zNErQ1h+mBD4PNVGUz/jv2MeWWgYVzBvIZqZSCrlI+VjInJq2Ir6Jcvo7TnHXFJQ8d qzDCbWX+mu2FFp0hOscTEFGTGc78NhlmkV9spdDRGudKbA+bbF13WHFg7q9Y0f1Pl9uY +1unTOYVJLuI1U32TB40WaUyOo6V44vX98oiIlbCIBZnSFy6RQPQd7DxmYQEk0VU1H7I a9eDAbXL77lwtq7oMWOD6u3bATYqd2I5ikJUPZt+EaHU+xw8FhqKcZeyP/LvbQm60cbC 4AZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HCA63Bq1RhuGBZe+uCuPvGnPrsrwVNbQ3GCsOT/wmUM=; b=dGdoDssFUy8LLncX+2890RSl815bdUT5oWJyORsTjzFFEnEy1s9VhFDsfaUND5vBjv x41qOD6u1IEATGSM5oYnILVRKZdmSp+DfbW1nb5PtC4etLwz6VIT84wL3U35BaZKU8zj 7y993hF4xrvvgl4k4y8IC/eeesLk7PXiH4tVbtBnwL5DFQrmFhmItMRR7CSXdgPUL5mY 1h6ysZN0SR9TqWicN84MZtWu8QBlt+4p4V92lYCDoflnqdzcJwVrUoVuILj/gxQR7HUn lDqE+YCTGrPuwPoT6cxgRrq4nU1CY0DGcBkCPLSGJM2Wzq06V+HJM5Hfn0R1uvwqOvm2 cr4g== X-Gm-Message-State: AOAM532vEU9gm44enqSAwJ4kfOmH9M4nYLlqdPQfgdWMdDJK5zTDrz+3 WgjRo8v4Jj2NbHelNIe47tAt/HzxQSfwTVs3VOX2lQ== X-Google-Smtp-Source: ABdhPJxJ2f+R+KS7pfQohsYdVddkjHZxwk/0JQR8S7eNdH2ExKuk8ndnjpdBmu09F1/q3NGaVBzOR2OyjOycGTRiof0= X-Received: by 2002:ac8:7a87:: with SMTP id x7mr20922438qtr.50.1592901104200; Tue, 23 Jun 2020 01:31:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Tue, 23 Jun 2020 10:31:32 +0200 Message-ID: Subject: Re: Kernel hardening project suggestion: Normalizing ->ctor slabs and TYPESAFE_BY_RCU slabs To: Alexander Potapenko Cc: Marco Elver , Jann Horn , Kernel Hardening , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux-MM , Andrey Konovalov , Will Deacon , kasan-dev , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9CA1C180000F5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 23, 2020 at 9:24 AM Alexander Potapenko wro= te: > > KFENCE also has to ignore both TYPESAFE_BY_RCU and ctors. > For ctors it should be pretty straightforward to fix (and won't > require any changes to SL[AU]B). Not sure if your proposal for RCU > will also work for KFENCE. Does it work for objects freed by call_rcu in normal slabs? If yes, then I would assume it will work for TYPESAFE_BY_RCU after this change, or is there a difference? > Another beneficiary of RCU/ctor normalization would be > init_on_alloc/init_on_free, which also ignore such slabs. > > On Tue, Jun 23, 2020 at 9:18 AM Marco Elver wrote: > > > > On Tue, 23 Jun 2020 at 08:45, Dmitry Vyukov wrote: > > > > > > On Tue, Jun 23, 2020 at 8:26 AM Jann Horn wrote: > > > > > > > > Hi! > > > > > > > > Here's a project idea for the kernel-hardening folks: > > > > > > > > The slab allocator interface has two features that are problematic = for > > > > security testing and/or hardening: > > > > > > > > - constructor slabs: These things come with an object constructor > > > > that doesn't run when an object is allocated, but instead when the > > > > slab allocator grabs a new page from the page allocator. This is > > > > problematic for use-after-free detection mechanisms such as HWASAN = and > > > > Memory Tagging, which can only do their job properly if the address= of > > > > an object is allowed to change every time the object is > > > > freed/reallocated. (You can't change the address of an object witho= ut > > > > reinitializing the entire object because e.g. an empty list_head > > > > points to itself.) > > > > > > > > - RCU slabs: These things basically permit use-after-frees by desi= gn, > > > > and stuff like ASAN/HWASAN/Memory Tagging essentially doesn't work = on > > > > them. > > > > > > > > > > > > It would be nice to have a config flag or so that changes the SLUB > > > > allocator's behavior such that these slabs can be instrumented > > > > properly. Something like: > > > > > > > > - Let calculate_sizes() reserve space for an rcu_head on each obje= ct > > > > in TYPESAFE_BY_RCU slabs, make kmem_cache_free() redirect to > > > > call_rcu() for these slabs, and remove most of the other > > > > special-casing, so that KASAN can instrument these slabs. > > > > - For all constructor slabs, let slab_post_alloc_hook() call the > > > > ->ctor() function on each allocated object, so that Memory Tagging = and > > > > HWASAN will work on them. > > > > > > Hi Jann, > > > > > > Both things sound good to me. I think we considered doing the ctor's > > > change with KASAN, but we did not get anywhere. The only argument > > > against it I remember now was "performance", but it's not that > > > important if this mode is enabled only with KASAN and other debugging > > > tools. Performance is definitely not as important as missing bugs. Th= e > > > additional code complexity for ctors change should be minimal. > > > The rcu change would also be useful, but I would assume it will be la= rger. > > > Please add them to [1], that's KASAN laundry list. > > > > > > +Alex, Marco, will it be useful for KFENCE [2] as well? Do ctors/rcu > > > affect KFENCE? Will we need any special handling for KFENCE? > > > I assume it will also be useful for KMSAN b/c we can re-mark objects > > > as uninitialized only after they have been reallocated. > > > > Yes, we definitely need to handle TYPESAFE_BY_RCU. > > > > > [1] https://bugzilla.kernel.org/buglist.cgi?bug_status=3D__open__&com= ponent=3DSanitizers&list_id=3D1063981&product=3DMemory%20Management > > > [2] https://github.com/google/kasan/commits/kfence > > > > -- > Alexander Potapenko > Software Engineer > > Google Germany GmbH > Erika-Mann-Stra=C3=9Fe, 33 > 80636 M=C3=BCnchen > > Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg