From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D028C433E0 for ; Tue, 23 Jun 2020 09:14:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50A2A20768 for ; Tue, 23 Jun 2020 09:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RgLw0dY+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A2A20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF3F46B0006; Tue, 23 Jun 2020 05:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA41A6B0007; Tue, 23 Jun 2020 05:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C937F6B0008; Tue, 23 Jun 2020 05:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B123F6B0006 for ; Tue, 23 Jun 2020 05:14:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5611C8248047 for ; Tue, 23 Jun 2020 09:14:32 +0000 (UTC) X-FDA: 76959915984.04.wax51_4e1813326e3a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 311C280127D9 for ; Tue, 23 Jun 2020 09:14:32 +0000 (UTC) X-HE-Tag: wax51_4e1813326e3a X-Filterd-Recvd-Size: 8850 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 09:14:31 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id i3so5323043qtq.13 for ; Tue, 23 Jun 2020 02:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vtk9OVdWBIKNADV6/am2r3iuDJGvWTfkOXH+NORoJEE=; b=RgLw0dY+wWISAydHPK1RYGzh3Bjgq0QwQQs7ehEo8gD0wtFC6bD8909xWC9iubTGU6 Ot2GJzARHtbNM9kLmcTlJQ0IaxTft/Sv2rp+iuRyXLAIp3ZvRF2qil7WlFTJREO9DIr5 N3GNbVCjwJcHU2PhTFOqc9+KceSqWuGbCPH5LyLz0eWu6yMTZROfUZkDzTI7CQp2HIUy fbwNn7uR2iy8sCamgOMmPsT0oEAjXGZMauAb/COtOG8MbkcgGxjdMdcjRA23073rPE2t 4XD81PuEK6y3l96QU06CVvFojD0UITYexMMJdZFfwUcBarL9zwSwxcu5BabhmaKA0+4I S5Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vtk9OVdWBIKNADV6/am2r3iuDJGvWTfkOXH+NORoJEE=; b=nI0P3c4/Cb4S1LrS19DIJaHVt12LdXKQiUxoWtliHFoqB/Zi+ZBDxI0iaq0MP3864w WYtG2Ud3v8j2FlCe+YS5ptA86NrGOTtpUQbog7WZc67q/j1fqkd7iB9H+iD6TWwubtFC /onxvheqvVtDcZ6mDu5FthmfkcMwXiZ5m/FGLotZtZs8U+UPk5C/S1XfXHLj9LhJ1Pp/ 5sSrWEZyj4U0WqCKbarCPUET7irmWaoY63mG4dxAWDFu5hzByJ+cBQVky/dIY6CY9rCi vkE589dMqJ6QRUC8lIpj5OGAI0E7kxCUdGoVXGASSL/wxQStopptRirmgmq4wjn07nwQ kqHg== X-Gm-Message-State: AOAM530W11dN54FRtjxsz0IkGXjC5f0VSFuQ08kismkKoorDhYnMKrRV qIOJDFoNkOajcMEGorzeFl1QxlIiqAnNyDdjzysoJw== X-Google-Smtp-Source: ABdhPJxfyAmn2d6xfjHDJdxmr4+T63Km5W4JYizPwK9Hiwq64yvYr+vS6olV/+jrwG3o8UDH4bxdMNxFAok2munPYi4= X-Received: by 2002:ac8:41c7:: with SMTP id o7mr110428qtm.257.1592903670569; Tue, 23 Jun 2020 02:14:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dmitry Vyukov Date: Tue, 23 Jun 2020 11:14:19 +0200 Message-ID: Subject: Re: Kernel hardening project suggestion: Normalizing ->ctor slabs and TYPESAFE_BY_RCU slabs To: Alexander Potapenko Cc: Marco Elver , Jann Horn , Kernel Hardening , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux-MM , Andrey Konovalov , Will Deacon , kasan-dev , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 311C280127D9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 23, 2020 at 10:38 AM Alexander Potapenko wr= ote: > > > KFENCE also has to ignore both TYPESAFE_BY_RCU and ctors. > > > For ctors it should be pretty straightforward to fix (and won't > > > require any changes to SL[AU]B). Not sure if your proposal for RCU > > > will also work for KFENCE. > > > > Does it work for objects freed by call_rcu in normal slabs? > > If yes, then I would assume it will work for TYPESAFE_BY_RCU after > > this change, or is there a difference? > > If my understanding is correct, TYPESAFE_BY_RCU means that the object > may be used after it has been freed, that's why we cannot further > reuse or wipe it before ensuring they aren't used anymore. Yes, but only within an rcu grace period. And this proposal will take care of this: from the point of view of slab, the object is freed after an additional rcu grace period. So when it reaches slab free, it must not be used anymore. > Objects allocated from normal slabs cannot be used after they've been > freed, so I don't see how this change applies to them. > > > > Another beneficiary of RCU/ctor normalization would be > > > init_on_alloc/init_on_free, which also ignore such slabs. > > > > > > On Tue, Jun 23, 2020 at 9:18 AM Marco Elver wrote: > > > > > > > > On Tue, 23 Jun 2020 at 08:45, Dmitry Vyukov wr= ote: > > > > > > > > > > On Tue, Jun 23, 2020 at 8:26 AM Jann Horn wrot= e: > > > > > > > > > > > > Hi! > > > > > > > > > > > > Here's a project idea for the kernel-hardening folks: > > > > > > > > > > > > The slab allocator interface has two features that are problema= tic for > > > > > > security testing and/or hardening: > > > > > > > > > > > > - constructor slabs: These things come with an object construc= tor > > > > > > that doesn't run when an object is allocated, but instead when = the > > > > > > slab allocator grabs a new page from the page allocator. This i= s > > > > > > problematic for use-after-free detection mechanisms such as HWA= SAN and > > > > > > Memory Tagging, which can only do their job properly if the add= ress of > > > > > > an object is allowed to change every time the object is > > > > > > freed/reallocated. (You can't change the address of an object w= ithout > > > > > > reinitializing the entire object because e.g. an empty list_hea= d > > > > > > points to itself.) > > > > > > > > > > > > - RCU slabs: These things basically permit use-after-frees by = design, > > > > > > and stuff like ASAN/HWASAN/Memory Tagging essentially doesn't w= ork on > > > > > > them. > > > > > > > > > > > > > > > > > > It would be nice to have a config flag or so that changes the S= LUB > > > > > > allocator's behavior such that these slabs can be instrumented > > > > > > properly. Something like: > > > > > > > > > > > > - Let calculate_sizes() reserve space for an rcu_head on each = object > > > > > > in TYPESAFE_BY_RCU slabs, make kmem_cache_free() redirect to > > > > > > call_rcu() for these slabs, and remove most of the other > > > > > > special-casing, so that KASAN can instrument these slabs. > > > > > > - For all constructor slabs, let slab_post_alloc_hook() call t= he > > > > > > ->ctor() function on each allocated object, so that Memory Tagg= ing and > > > > > > HWASAN will work on them. > > > > > > > > > > Hi Jann, > > > > > > > > > > Both things sound good to me. I think we considered doing the cto= r's > > > > > change with KASAN, but we did not get anywhere. The only argument > > > > > against it I remember now was "performance", but it's not that > > > > > important if this mode is enabled only with KASAN and other debug= ging > > > > > tools. Performance is definitely not as important as missing bugs= . The > > > > > additional code complexity for ctors change should be minimal. > > > > > The rcu change would also be useful, but I would assume it will b= e larger. > > > > > Please add them to [1], that's KASAN laundry list. > > > > > > > > > > +Alex, Marco, will it be useful for KFENCE [2] as well? Do ctors/= rcu > > > > > affect KFENCE? Will we need any special handling for KFENCE? > > > > > I assume it will also be useful for KMSAN b/c we can re-mark obje= cts > > > > > as uninitialized only after they have been reallocated. > > > > > > > > Yes, we definitely need to handle TYPESAFE_BY_RCU. > > > > > > > > > [1] https://bugzilla.kernel.org/buglist.cgi?bug_status=3D__open__= &component=3DSanitizers&list_id=3D1063981&product=3DMemory%20Management > > > > > [2] https://github.com/google/kasan/commits/kfence > > > > > > > > > > > > -- > > > Alexander Potapenko > > > Software Engineer > > > > > > Google Germany GmbH > > > Erika-Mann-Stra=C3=9Fe, 33 > > > 80636 M=C3=BCnchen > > > > > > Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado > > > Registergericht und -nummer: Hamburg, HRB 86891 > > > Sitz der Gesellschaft: Hamburg > > > > -- > Alexander Potapenko > Software Engineer > > Google Germany GmbH > Erika-Mann-Stra=C3=9Fe, 33 > 80636 M=C3=BCnchen > > Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg