From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2D3C02194 for ; Thu, 6 Feb 2025 18:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B348E6B0083; Thu, 6 Feb 2025 13:36:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3526B0085; Thu, 6 Feb 2025 13:36:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AAA06B0089; Thu, 6 Feb 2025 13:36:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 819346B0083 for ; Thu, 6 Feb 2025 13:36:12 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 50B6D4BD4F for ; Thu, 6 Feb 2025 18:36:11 +0000 (UTC) X-FDA: 83090374542.21.8F0EFB0 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf22.hostedemail.com (Postfix) with ESMTP id 5855BC0017 for ; Thu, 6 Feb 2025 18:36:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DgjoGnAc; spf=pass (imf22.hostedemail.com: domain of dvyukov@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738866968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jXKzpsp2HF6ajtmLJiPFASdUjXub2sfdmB41yGqFJD4=; b=NQBg9Ar5tf7EarwXn+V8iBq7qlh+8zfvhrlD7/AMte6fObMHmOTSbr+2X5Djx11e70gNul nbx+4By6ecBtpW3bFq+bYkaFGfj5Gj1FcnA+tjCMKA0uES/4IUtF4eZaFVNWzMlvuXRNYg sKsR2yikLnYEzSYurN+7P6XB4cnoINM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=DgjoGnAc; spf=pass (imf22.hostedemail.com: domain of dvyukov@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738866968; a=rsa-sha256; cv=none; b=Tb1SEbo2tTSGcAVzSL+REHDz0AQ5m4iE0AafK+IZFITnaWnKZnj2kfDgg3i+ZtxofkEdSn SwXYkcqASKGo7Io+gpgH6anTJWUrFfexpyrwpgnzTvwV686qGFHkMwiWpEvEt6GKe6rc2x QIzCHAW6wY2DpuRbUvOvXF0/9rGx8A4= Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-30762598511so12457191fa.0 for ; Thu, 06 Feb 2025 10:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738866966; x=1739471766; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jXKzpsp2HF6ajtmLJiPFASdUjXub2sfdmB41yGqFJD4=; b=DgjoGnAc6npzQaHcIG0JxkyUn+2Di6QEI2hvXnS25GksRksaZsYEP0Lyel+FOC6miC B53DjHsL0gi0Nc65YszB/QkGu9lEAE63UkMXDSuYhSUEPmtvm7CaobEgjUgF5UWGlFLh ow7KLNShL9vJzk0e4k9HjVC1Pkq8w2Ko2FrW3Hht6zNyfDsiKSW9wrS0QG8v0UJYEOkB T9QDNXS/JplRnJ7rDxaWqrTTGPiaFtJU1f6TAFyJRazLD6ph2LkHn2rIg8UbwTlfLCR5 biSSp5Qo23PEzvnqszwjMY9gVfm2ptbGC71hLL3epnPtuhcvj95kgUOyPEx9Qj8m23++ 1EZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738866966; x=1739471766; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jXKzpsp2HF6ajtmLJiPFASdUjXub2sfdmB41yGqFJD4=; b=eNVf5aziXEkfZAl54WCBviKTaykZVHijmynnA1Acj+1yO8AC5HyxoeZuXe0hICPujD e8XyHSy6ORel4Q5yKfAbr7HNMqR9HFNk0yk20soYKsgJdr93q7wpEq0+oh694AFk8piB 3U2/ckLWqChvhBOX7rz2dpgw7I+TzpwL7gl1xHpSl7BRMHBJ+RvlrdffOMXCPhzVJqoB cK8Lvhfsewrb9lhxBHHpUbuGd7RS2Ch+E1asqu1AGTPyExukBSFyHMjziYfCIhy7byHo LGSTaJjJGaHApJBaNNdmrgoZKv0tDZ007RCZ7oCBtSQoFaqdofriy0ohFGTcKEszHO1T nxqw== X-Forwarded-Encrypted: i=1; AJvYcCUi7PuWu/Gpt5JE6V+/LrQK/7Vav0J7qmrLe3lCFIen0Px9Qm/+rjaqWnnzs2hA8tUaq2mMGYbvRg==@kvack.org X-Gm-Message-State: AOJu0Yytzg2nAdmuxMtb6Aj/JU+JOykaoeZD4yFrAxk2uNR7gNBtr/o8 l4z5mPqw4wJIHBZwzJDW0TdUXJnJI5W5m69Ul9FQ5UTITxSW3kLQ/TTtAqlCE63h9vehyKRSpN7 Me/4Uzqc1wiBh84teTARm0zpMBIfbo73IXmqo X-Gm-Gg: ASbGncuLWyuDDIvvNG5D3UQ6TzYMOkd1e4xP08ySOgtO8Ipc0c16Iz9JnnMaC684HUN zldTlyQHLLDiukQDvTj3wM8kcar8hy/ahSHCQCNO/AY5mG4h5TTM71GnJcLcSQMN9CUq0uayyBa eLeg77hKk3RDlj2B/AKK0iowi/xmOW1w== X-Google-Smtp-Source: AGHT+IF6lI/Eg3OSfG7pW/gQ3oXRIZZ1DQEAknZZLXJRRkowGwOsYuzILwOw7DMrSQ2+uCTp6edKb6GT4vo8jpJvOlI= X-Received: by 2002:a2e:a54c:0:b0:307:e031:15a8 with SMTP id 38308e7fff4ca-307e57c7394mr175171fa.8.1738866966472; Thu, 06 Feb 2025 10:36:06 -0800 (PST) MIME-Version: 1.0 References: <20240802061318.2140081-4-aruna.ramakrishna@oracle.com> <20250204100134.1843654-1-dvyukov@google.com> <1f3f60b3-1741-4ced-951c-8e103970170f@intel.com> In-Reply-To: <1f3f60b3-1741-4ced-951c-8e103970170f@intel.com> From: Dmitry Vyukov Date: Thu, 6 Feb 2025 19:35:54 +0100 X-Gm-Features: AWEUYZkCOGJgbp7k-P-q94mw0_xDb9OMqgvWZyjn7YegC2xWnPKR2iigco-uvuQ Message-ID: Subject: Re: [PATCH v8 3/5] x86/pkeys: Update PKRU to enable all pkeys before XSAVE To: Dave Hansen Cc: aruna.ramakrishna@oracle.com, mathieu.desnoyers@efficios.com, peterz@infradead.org, paulmck@kernel.org, boqun.feng@gmail.com, dave.hansen@linux.intel.com, jannh@google.com, jeffxu@chromium.org, jorgelo@chromium.org, keescook@chromium.org, keith.lucas@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@kernel.org, rick.p.edgecombe@intel.com, sroettger@google.com, tglx@linutronix.de, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5855BC0017 X-Stat-Signature: 4usa6img6y1o1cfe1ksphab95saqsa1g X-HE-Tag: 1738866968-804170 X-HE-Meta: U2FsdGVkX19weSYcOZyq2TQwh17LTJvDr/Jleh1R3V1vhPE8RcQEBVqaf+hX5MweK+HhnKPMXU7ZSLUviwtU6pvRriaeeJ4eyz3TSaubpPSnmSyh2iio1fJoZYspMEcgCQSq6Hw62EYAxe8LLZkirf7fmrXQXChMsWI0TMytOujgt0wrks3wlseJp4wxlynR15QaNiBHzbgY9+MM/H7EeG/o5/4cwrkH3+SoZ64AdJzXx25FO1S+HUwcLBvG9BUkwyf0zM9BFz3Rq+k7PaLkalUwCGK1EzQPsvDTeFiboSHi1K5JfUpBp9j0Azi3PVt4hZalF53++XWqqHhHpxMdhQWpu9YCau2KFvVOpeMxCjQLsO6ZyKcgSfLSlbukmeZlwF3wM+APAinGNxUCMXOu2//MmNBhYgBgQhP3Au1B7vKLKYRPIR7GQFRQHvj4l95iapmRxgBXXIdCgWBMt9SbO3Anp43FqIIj1Eajsx2Savmnfbp2cOnRXx5z8aMcneGPVWCmxn4o6e2J+GE46Ic30d0v2/Q8si0vtSB2JKCv3fOGr5o6WlN5QPTk+kH9o6jy4MthhyQ/FNBnxTT8dGb1JMxYEy4HUFCLaNWamon8SNiZEJw2lR62900jRLmCjoNWPTJTkmTxPD479CaqjX9oD6pj6mbcw4XS5ftWvjcg32ASRTPSAzcx6x/3EZ/T7VP+y60c0UpRilNePBMHOdqzfpPH70M8BGbtrvcu4VnVX80RmQbzkYylff9D27PQny3hRw84yALi508jsykFq7sYNwJhk3M/VkxRa8kJJflACOrgbzzaTZodSaWYo5pwqzKs2SnjRgijAFjdforFjYT7JFxcrfswyzxCWIOoDdefFZBHv6NqdIGE87/FRPMSKVg7VElGz9rvGCpF6/ypotmg5vR6P0kbZunvsjpVD6ZOGn+w5iGaKtzVRgY2xAO9BVYVB04vqxKEpwQM8tmhdTg Au12/nfU eI9xsPqauClhvsDtAwh1ls1x3bGmHz4wOzHWVLFxQHZoHWT6A4R1mM1v0cUWhDXsPc2W0Fzz9Bwsnf6AgYjByUTkE+gn1eIK2u/bse6vh49Zt26TyhVgv9PvWwmt5MbMHOUD0RKEn6EYYLHx5TUNYclKCaKpHOE+TjAjyMEnRmqGtGMDlBNAzR06+vN5HWD7dAM0olgeTZvQmuucf1FUChyQ6lvNXnPChtJ5ExXQdzCGHEbQ+7yAY3wBUbaUizpWeFkWAaVVPb0Limq96gS2cwzaGiBF7zc3iPbb2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 6 Feb 2025 at 19:21, Dave Hansen wrote: > > On 2/4/25 02:01, Dmitry Vyukov wrote: > >> But this updated PKRU value is also pushed onto the sigframe, which > >> means the register value restored from sigcontext will be different from > >> the user-defined one, which is unexpected. Fix that by overwriting the > >> PKRU value on the sigframe with the original, user-defined PKRU. > > > > This unfortunatly seems to be broken for rseq user-space writes. > > Hi Dmitry, > > Are you saying that Aruna's patch caused a regression in the rseq code? > Or that the rseq code has a separate but similar issue to the one that > Aruna's patch fixed? No, no regression. Just another issue for real PKEY uses.