From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3188EC43381 for ; Tue, 12 Mar 2019 14:45:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7C102087C for ; Tue, 12 Mar 2019 14:45:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="j2Ny9Whd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7C102087C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84BFD8E0003; Tue, 12 Mar 2019 10:45:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FBCF8E0002; Tue, 12 Mar 2019 10:45:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8E88E0003; Tue, 12 Mar 2019 10:45:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by kanga.kvack.org (Postfix) with ESMTP id 5132E8E0002 for ; Tue, 12 Mar 2019 10:45:10 -0400 (EDT) Received: by mail-io1-f72.google.com with SMTP id r21so1934486iod.12 for ; Tue, 12 Mar 2019 07:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=W8tjD9g6ECFtj58bueXZfoseG7B0ylHDzFv2iAyv4fM=; b=eBmbfTb7c5ELU66WHxxBjWIKO3miTddtGVuyINVpocR6aFOn4qKFd5MpOE6KCY9r0c jKoXNMaurI3Rt3PhU+5d2pbfF+wGt0BsPvfioHr22sHxKO1hfNRcSZUgmBprlZR/4zmm MarwWufg9yaJs0oF/8XLHEkDk3pQlhsEq21+HBHWrh/4SXOdpnkq2GVnNd/P1M5IMCpK VycoQJqJAxQCgwQL4nMJpsDseKUdhtQleOgqn9H4uxGX/IQXmmbHvdnpkpjjAY5z13ph RG84wFO7LUsZEOYa5cuQpndnL/K6GSnpB21rAz3b6aCck1fsFyQZiiX0UYQDJOylHsao lY8g== X-Gm-Message-State: APjAAAWjhDRwAlLFhWVKDkcAVEzA6WBLWkTsL/6thikuEpHUOVeCJNvV d2uCrs0Ydy7+hw+DZE29WMTCGUMnhg0mSQUtoUw4WmWWHhEQ0/ApquhY3u2gXm97UWhu/HREFSK cUBW3XRt4e42Cg0eoZXKAApdsO7EYjYRqWETEab8GsTzdtmF0FN4pTKQRY3hStgUks5cpi2KsN/ eReWDj8ps5JTOlQjngo+qu38m9hW6bu87IpEnm4fM3Ox+Y//0DmhMvcOmnC/zb0uayc/sVKT5OQ LIH7unLVy+vrBNT1oEacVHxvz5I2hkE3XyF4MICQWMJIcH15XyFLx2PFb0Ome9YrjlaRgplzKTC VEziTXWbiHp5QrcrY0R5r4bxV9jgz79mxeGMIwHe3pualI4zU1vYMEh5vuc/MMZ9CwnlkkvSUDB H X-Received: by 2002:a24:2405:: with SMTP id f5mr2472383ita.130.1552401909973; Tue, 12 Mar 2019 07:45:09 -0700 (PDT) X-Received: by 2002:a24:2405:: with SMTP id f5mr2472322ita.130.1552401908961; Tue, 12 Mar 2019 07:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552401908; cv=none; d=google.com; s=arc-20160816; b=0QTxdbN/oYTr8TpSDTKy7JEa8yJJMPaBsT31we7GMBget4BvrYAk5ZPjuZZ4MkPamM rWqdhFDb42uSrewTUwI9gtG5IDVoou/V1NN7Sa10s3SvrCCIkbxybyZ0Q/RHd55XOdQS IltXRYh00RPfX0xOjanhJChO4dIId8VnqlsrK8MNl+tR3aOxpvF7siQdmRjQlokQVQaw 0SfbqsPk62dJjjzPlaD4X7Ssz6FBO8pUqp+S9zGo66MDE9rPTLLl434+J5BgL+jn99OH hXje1aCN+lYIvHkLaeZ9yoGAl4g6mOzCpFwVleVsayIDfyOFo5NTcVI/uoNC/eq5gi+L bizQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=W8tjD9g6ECFtj58bueXZfoseG7B0ylHDzFv2iAyv4fM=; b=GbTqK5QQNnNwJ/+FdtZF99jpuIKzrDJqBhxAFfnyWyXnmPPqKrrTZd9u/EiYtyaknI 1TwEiUwonNnzbkKTJV70yZ98HrdLVmRIUYbEl5e0oMZi//F/JqevtwkUhrTUwsUZ5u4V 22TiQytzmIliWMr6fS+xB2l7UPQQWjORrBePoGC7nH6vzinLASx1FRjY626TWmHPe+vR 5bh/xEsNhj3yzAOKtw0+hXkZaXCZn3dFyXspyHXRtY/KcXZ1k5U1tukdRzcawHJWWJ/2 AWUyr0VqgGzexvGDwoaXOQK4fddKd2a8Iyn9oqiHWpRXCPTxUPZ92hWf0fIeUZG7t0zc 5btw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=j2Ny9Whd; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id t30sor2397574iob.63.2019.03.12.07.45.08 for (Google Transport Security); Tue, 12 Mar 2019 07:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=j2Ny9Whd; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W8tjD9g6ECFtj58bueXZfoseG7B0ylHDzFv2iAyv4fM=; b=j2Ny9WhdjH/22/DqO/hEcrrNdeC8IgVny+r24d46gGtY/Fm2CDh5flqhM2XUvDP2cc O0/SeF03zZUQTibfHaFryMyd265qsta+lMBuWrO5I01JnDD4sYClYXE+QWIB81qSK3e6 RByTEQ1GO54xIYlZO7FV/Qqh9M935IIvNcgFwd5NRmFN8UPqj8PhPUoNXIodn1HFOexQ y4+7ZgFbBH+E5jDMwn5wkKOysvpvAUPoknnYCpDAJj+2fjt5EJGzvcetGWEjp5gqcrPN 41Lzq6pI5ALOxue4zvznNe2HwNJcRnrvp/rphZiwsVS2LbBe3ujyxdF3JWsA98wMhtw4 RgwQ== X-Google-Smtp-Source: APXvYqwmmu1BcEEiUW24WYGARs5ONMR3C5EQpLCqXyb/yQY1Irh1d5Z8g0Uhd54vJrGiSrIFZtGCNm5UACGj8tHWeVA= X-Received: by 2002:a6b:3709:: with SMTP id e9mr10669215ioa.282.1552401908362; Tue, 12 Mar 2019 07:45:08 -0700 (PDT) MIME-Version: 1.0 References: <0000000000001fd5780583d1433f@google.com> <20190311163747.f56cceebd9c2661e4519bdfc@linux-foundation.org> <20190311232541.db8571d2e3e0ca636785f31f@linux-foundation.org> In-Reply-To: From: Dmitry Vyukov Date: Tue, 12 Mar 2019 15:44:57 +0100 Message-ID: Subject: Re: KASAN: null-ptr-deref Read in reclaim_high To: Shakeel Butt Cc: Andrew Morton , syzbot , Cgroups , Johannes Weiner , LKML , Linux-MM , Michal Hocko , Michal Hocko , Stephen Rothwell , syzkaller-bugs , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 12, 2019 at 2:46 PM Shakeel Butt wrote: > > On Tue, Mar 12, 2019 at 1:33 AM Dmitry Vyukov wrote: > > > > On Tue, Mar 12, 2019 at 7:25 AM Andrew Morton wrote: > > > > > > On Tue, 12 Mar 2019 07:08:38 +0100 Dmitry Vyukov wrote: > > > > > > > On Tue, Mar 12, 2019 at 12:37 AM Andrew Morton > > > > wrote: > > > > > > > > > > On Mon, 11 Mar 2019 06:08:01 -0700 syzbot wrote: > > > > > > > > > > > syzbot has bisected this bug to: > > > > > > > > > > > > commit 29a4b8e275d1f10c51c7891362877ef6cffae9e7 > > > > > > Author: Shakeel Butt > > > > > > Date: Wed Jan 9 22:02:21 2019 +0000 > > > > > > > > > > > > memcg: schedule high reclaim for remote memcgs on high_work > > > > > > > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=155bf5db200000 > > > > > > start commit: 29a4b8e2 memcg: schedule high reclaim for remote memcgs on.. > > > > > > git tree: linux-next > > > > > > final crash: https://syzkaller.appspot.com/x/report.txt?x=175bf5db200000 > > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=135bf5db200000 > > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=611f89e5b6868db > > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=fa11f9da42b46cea3b4a > > > > > > userspace arch: amd64 > > > > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14259017400000 > > > > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=141630a0c00000 > > > > > > > > > > > > Reported-by: syzbot+fa11f9da42b46cea3b4a@syzkaller.appspotmail.com > > > > > > Fixes: 29a4b8e2 ("memcg: schedule high reclaim for remote memcgs on > > > > > > high_work") > > > > > > > > > > The following patch > > > > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch > > > > > might have fixed this. Was it applied? > > > > > > > > Hi Andrew, > > > > > > > > You mean if the patch was applied during the bisection? > > > > No, it wasn't. Bisection is very specifically done on the same tree > > > > where the bug was hit. There are already too many factors that make > > > > the result flaky/wrong/inconclusive without changing the tree state. > > > > Now, if syzbot would know about any pending fix for this bug, then it > > > > would not do the bisection at all. But it have not seen any patch in > > > > upstream/linux-next with the Reported-by tag, nor it received any syz > > > > fix commands for this bugs. Should have been it aware of the fix? How? > > > > > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch was > > > added to linux-next on Jan 10. I take it that this bug was hit when > > > testing the entire linux-next tree, so we can assume that > > > memcg-schedule-high-reclaim-for-remote-memcgs-on-high_work-v3.patch > > > does not fix it, correct? > > > In which case, over to Shakeel! > > > > Jan 10 is exactly when this bug was reported: > > https://groups.google.com/forum/#!msg/syzkaller-bugs/5YkhNUg2PFY/4-B5M7bDCAAJ > > https://syzkaller.appspot.com/bug?extid=fa11f9da42b46cea3b4a > > > > We don't know if that patch fixed the bug or not because nobody tested > > the reproducer with that patch. > > > > It seems that the problem here is that nobody associated the fix with > > the bug report. So people looking at open bug reports will spend time > > again and again debugging this just to find that this was fixed months > > ago. syzbot also doesn't have a chance to realize that this is fixed > > and bisection is not necessary anymore. It also won't confirm/disprove > > that the fix actually fixes the bug because even if the crash will > > continue to happen it will look like the old crash just continues to > > happen, so nothing to notify about. > > > > Associating fixes with bug reports solves all these problems for > > humans and bots. > > Should we add "Reported-by" for syzbot reports on linux-next patches > as well? Please note that these patches are in flux and might be > dropped or completely changed before merging into Linus tree. Reported-by will work, but may be confusing. It was discussed that for squashed fixed Tested-by tag may be more appropriate and will also work. For dropped patches we don't have a better way other than marking it as invalid for now. > Also should syzbot drop bug reports on older linux-next trees if it > can not be repro'ed in the latest linux-next tree? IMHO yes. Please file an issue for this at: https://github.com/google/syzkaller/issues So far we don't have retesting in any form. Some bugs don't have repros, so can't be retested. Any closing should probably happen after long enough timeout to avoid spam, so bisection for them will most likely happen anyway. I can't promise any ETA for linux-next-specific work. Testing of linux-next happens mostly because it's done on a rules not significantly different from everything else (other trees, forks and OSes).