From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFCBC0650F for ; Thu, 8 Aug 2019 16:34:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAF722184E for ; Thu, 8 Aug 2019 16:34:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lD8vJIwH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF722184E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6ACEA6B000E; Thu, 8 Aug 2019 12:34:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 636486B0010; Thu, 8 Aug 2019 12:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D6926B0266; Thu, 8 Aug 2019 12:34:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by kanga.kvack.org (Postfix) with ESMTP id 22FC16B000E for ; Thu, 8 Aug 2019 12:34:31 -0400 (EDT) Received: by mail-ot1-f70.google.com with SMTP id q22so62803474otl.23 for ; Thu, 08 Aug 2019 09:34:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=CevGcpRgzGYUYkY1Qufxh/t6tKVinQDXW0qs501ljWk=; b=sQUik0gkivFwTBk1Yc6Vb6quhZ6aaVEW1rnwoeXbk0G4kJeL3/L1hb57ITsSLnKgys doXjYHCUinHAaGuurzDHe615zyBwiKEdPHVRr9PJS98fanwViYjZpKL3B9KJE/C4CnW2 3971zTXgauAAJURN8z0Aqqd3KToyLXcobkeJkq8IWVhRvNvS9/F1VwRkir8mxDX24u3p Uu5+WYmqOw8cgq5CWQ04PFk8w5hDPy+4n44SOVRdS1ASMOiiIghoz2/4B+rRtctxzJ9q rE9V3gBI6cDgMD36qQiantD6/fVWDz42TKR29J5xon84yFNY+NBPhKQjjizL3l3DmpMF JQQg== X-Gm-Message-State: APjAAAVXGDMcepqNmObB2C6QqWihoNoYKWjnNGe8TYclwjMjnayo18NP FqnMub1ID7NGFDivQMCFEGLYpdi4AQvJqrA2oHguiPKZwVBWhjmM0dDPHoBJ0U979wPK6ceKLl/ t2b1pBRX2oP8JmXSC73kO7zlTPQjbNINdZGFpBbJPskuiwCZkgTZrCuSLrETA1vxGRQ== X-Received: by 2002:a6b:d809:: with SMTP id y9mr16583659iob.301.1565282070779; Thu, 08 Aug 2019 09:34:30 -0700 (PDT) X-Received: by 2002:a6b:d809:: with SMTP id y9mr16583567iob.301.1565282069693; Thu, 08 Aug 2019 09:34:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565282069; cv=none; d=google.com; s=arc-20160816; b=zNnjkvIWlHdc38UJB1yeX5LImaRzE3ap+XM5DNqkp9LqluaJvTMb+xFLsCLEjUIxQ+ cUILJ3maCJ/mpVLW9Pdm0edjgjxn9H8PqVqUdoHeYLg+o5GWOdifOdAG5UboUDkVPJSP 0Vb7vGH5JJa7Iq2xfNtfBsH5GUDhe23DhbhLIy4+hwjceqZOH8X0EGi12xAUFkYFFXic Y3fG3QyhCWi0w6q5zfhTxQzcqidCM03LOLsOPEFNDARaQTFVwh1ZmM7lNh3Sk+nZCTRu Ulqw/jlROAwkEazcHqqplPsfPdB3xrh1CBqb6I5rdNNDvTi5c1H1E3pBsYO8N1XSpFtT l5jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=CevGcpRgzGYUYkY1Qufxh/t6tKVinQDXW0qs501ljWk=; b=aM8TKxSCByyuSZ/26yjwqGdgkxquhaB7UlUg1Qd9c+UlErKmFO02u/0gRpjG3AvH89 uqQYisHeB4B7AVROcNI+grCROviK/BS9vDCa61vCLrVsjdXZgreTwA/Pi5cXIYuNsA2l Ho0opcUsAKbt4EYysppXBoyG7x6rVMsX3Iv6PRXWafx06e2WPl7R8JewSA4dtWMgbldz blMbnYN0fx2Y3oJ4qmS5V4NOC+Xhjdoq5RdbGHYvc5r81tAzMWm/3TQrZ/sAZLZL+42m mfiTvQf54tHnh7yFZD4AIOH5V3DGm7uqh/gl9+ZvLPsZletHzAmjaw2aqTjqVrPZf/oW GILQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lD8vJIwH; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c8sor3439443ioi.2.2019.08.08.09.34.29 for (Google Transport Security); Thu, 08 Aug 2019 09:34:29 -0700 (PDT) Received-SPF: pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lD8vJIwH; spf=pass (google.com: domain of dvyukov@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CevGcpRgzGYUYkY1Qufxh/t6tKVinQDXW0qs501ljWk=; b=lD8vJIwHU04brpVPsZuuc+sFApJtNJOJioUN1Ziqb96dgduPrr0GvZe9PS+KzkQK9g IeV2c9HRN34L70pR84OQ6J9VZb2WYp1xdN/vb+dFw9loWSb3l7bp1EI9iqQCmG/6dZ4J pyj64xb6Db1gr7Yq1Y1T/ENGkkWoekSVRNl3JkGWoSiG1qGAK0JeCKltUbqtWZGDTTdL lsKG09Qsh5dZDb0VHMYZifVnVGaHGfQvy9Ce7V5bRVhhmLElXSO/gAy2u9CeZAOB+5tv svtTlFDgWO1Z5XxZBg/gO6/saSDQzejeQT/b5EB97OaOf1t0HhIDhMmnaA+CjTFaGl8c FuFw== X-Google-Smtp-Source: APXvYqwcaNv0vzSVHagDyKD6rdlm96zsQZQ+/87RoINSAJesPxeFTIHAQRVZJ8CKRQBUYPYq+aWWwmWKc3gf5SmW5kE= X-Received: by 2002:a5e:c241:: with SMTP id w1mr14839283iop.58.1565282068876; Thu, 08 Aug 2019 09:34:28 -0700 (PDT) MIME-Version: 1.0 References: <000000000000a9694d058f261963@google.com> <20190802200643.GA181880@google.com> <20190806082907.GI11812@dhcp22.suse.cz> In-Reply-To: <20190806082907.GI11812@dhcp22.suse.cz> From: Dmitry Vyukov Date: Thu, 8 Aug 2019 18:34:16 +0200 Message-ID: Subject: Re: kernel BUG at mm/vmscan.c:LINE! (2) To: Michal Hocko Cc: Minchan Kim , syzbot , Andrew Morton , Chris Down , chris@zankel.net, dancol@google.com, Dave Hansen , Johannes Weiner , Hillf Danton , James Bottomley , "Kirill A. Shutemov" , Kirill Tkhai , laoar.shao@gmail.com, LKML , Linux-MM , Mel Gorman , oleksandr@redhat.com, Ralf Baechle , rth@twiddle.net, Stephen Rothwell , Shakeel Butt , Sonny Rao , surenb@google.com, syzkaller-bugs , Tim Murray , yang.shi@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 6, 2019 at 10:29 AM Michal Hocko wrote: > > On Sat 03-08-19 05:06:43, Minchan Kim wrote: > > On Fri, Aug 02, 2019 at 10:58:05AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit: 0d8b3265 Add linux-next specific files for 20190729 > > > git tree: linux-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=1663c7d0600000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=ae96f3b8a7e885f7 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=8e6326965378936537c3 > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=133c437c600000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15645854600000 > > > > > > The bug was bisected to: > > > > > > commit 06a833a1167e9cbb43a9a4317ec24585c6ec85cb > > > Author: Minchan Kim > > > Date: Sat Jul 27 05:12:38 2019 +0000 > > > > > > mm: introduce MADV_PAGEOUT > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1545f764600000 > > > final crash: https://syzkaller.appspot.com/x/report.txt?x=1745f764600000 > > > console output: https://syzkaller.appspot.com/x/log.txt?x=1345f764600000 > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > Reported-by: syzbot+8e6326965378936537c3@syzkaller.appspotmail.com > > > Fixes: 06a833a1167e ("mm: introduce MADV_PAGEOUT") > > > > > > raw: 01fffc0000090025 dead000000000100 dead000000000122 ffff88809c49f741 > > > raw: 0000000000020000 0000000000000000 00000002ffffffff ffff88821b6eaac0 > > > page dumped because: VM_BUG_ON_PAGE(PageActive(page)) > > > page->mem_cgroup:ffff88821b6eaac0 > > > ------------[ cut here ]------------ > > > kernel BUG at mm/vmscan.c:1156! > > > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > > > CPU: 1 PID: 9846 Comm: syz-executor110 Not tainted 5.3.0-rc2-next-20190729 > > > #54 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > > Google 01/01/2011 > > > RIP: 0010:shrink_page_list+0x2872/0x5430 mm/vmscan.c:1156 > > > > My old version had PG_active flag clear but it seems to lose it with revising > > patchsets. Thanks, Sizbot! > > > > >From 66d64988619ef7e86b0002b2fc20fdf5b84ad49c Mon Sep 17 00:00:00 2001 > > From: Minchan Kim > > Date: Sat, 3 Aug 2019 04:54:02 +0900 > > Subject: [PATCH] mm: Clear PG_active on MADV_PAGEOUT > > > > shrink_page_list expects every pages as argument should be no active > > LRU pages so we need to clear PG_active. > > Ups, missed that during review. > > > > > Reported-by: syzbot+8e6326965378936537c3@syzkaller.appspotmail.com > > Fixes: 06a833a1167e ("mm: introduce MADV_PAGEOUT") > > This is not a valid sha1 because it likely comes from linux-next. I > guess Andrew will squash it into mm-introduce-madv_pageout.patch > > Just for the record > Acked-by: Michal Hocko > > And thanks for syzkaller to exercise the new interface so quickly! syzkaller don't have any new descriptions for MADV_PAGEOUT. It's just the power of rand. If there is something more complex than just a single flag, then it may benefit from explicit interface descriptions. > > Signed-off-by: Minchan Kim > > --- > > mm/vmscan.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 47aa2158cfac2..e2a8d3f5bbe48 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2181,6 +2181,7 @@ unsigned long reclaim_pages(struct list_head *page_list) > > } > > > > if (nid == page_to_nid(page)) { > > + ClearPageActive(page); > > list_move(&page->lru, &node_page_list); > > continue; > > } > > -- > > 2.22.0.770.g0f2c4a37fd-goog > > -- > Michal Hocko > SUSE Labs > > -- > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/20190806082907.GI11812%40dhcp22.suse.cz.