From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8514EC55178 for ; Wed, 28 Oct 2020 17:04:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F2E6624798 for ; Wed, 28 Oct 2020 17:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="C3K8jt2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2E6624798 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7ADFB6B005C; Wed, 28 Oct 2020 13:04:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75FD86B006C; Wed, 28 Oct 2020 13:04:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69D556B0071; Wed, 28 Oct 2020 13:04:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 415D76B005C for ; Wed, 28 Oct 2020 13:04:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B97738249980 for ; Wed, 28 Oct 2020 17:04:29 +0000 (UTC) X-FDA: 77421957858.23.grain91_4b1058227286 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9618637604 for ; Wed, 28 Oct 2020 17:04:29 +0000 (UTC) X-HE-Tag: grain91_4b1058227286 X-Filterd-Recvd-Size: 4428 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 17:04:28 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id m14so24409qtc.12 for ; Wed, 28 Oct 2020 10:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AG7fb7d0C8MAPzIXBnKbPS8VY0VZhAzE0h3g8JJD9l8=; b=C3K8jt2EESSq9VBTNlezdB5lhUxguZOUeT8DjBvyG9TszljClDzOfG9DwkqrQSgiD7 TdYSZRXFVXdRK/2xcEgpMnOCr8pKQySnqXpr+6yWakTPSBKVaIyOgjz63BpmBDc1l6n/ oc3RCyWLuwsp8oo7N1h4IgYsKQRuTOUkgfdMjmVTJZeMDRNN8phA44WY8oAON1PE1cMP BAbHBlLZM5jUcM1Ao2QLQJTOwhNnrr/gyHpiRepcpk0VVVUcmlKrh7FE8sh4SrEjgKJz +ysNTbhkEbg/e6PDlHO25ydv/+rlaEHf2lCQqiXu7NSafJ/zd2YFqCLEUxXtZHd6J/3w wuYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AG7fb7d0C8MAPzIXBnKbPS8VY0VZhAzE0h3g8JJD9l8=; b=gKn9KQ0pcxX+gjHZ40oapywLFFw0B4vWH3YP7GRZD+l/TTtKyDFEp35Elz2Qb6K7Rm gEiy+VxEKfV2CQu8LJ1LtdjJkOoOuOhIrjLQum+n070mOoJbnVPSwLlZdJ1diPbQv9a2 6lmhgOpwPGyUBcAmR/OVpgRYJewFyQXBApku2YPUnseI0Fp9gAAUc3tR1p4nBk/0FK1E epNlhcxcM20qktSX/PhFwYFTHHJUzRpH7JUECbYkC9r2TYrbWpYbPNOOQ+8RHhMhT42R SUAgNbIJDZpsSzqed6yD33KvyPXwdy5fSNCSKQ0/j7dmn4DSdZDNDib4773QV7btv+VK R05A== X-Gm-Message-State: AOAM533XZIytG5MW8sFfWngyMbBlF3DLAHQSIiMXCQsr8A6DT28tsksf GJsjOtit8hjDVvLmed6jr5uyY8Eobs6OoGhisEo9aw== X-Google-Smtp-Source: ABdhPJz1pGv64k+Jss9JKkY2ROsSjCftXLL5fqnH7sCV0rYWTeW7P4EWOFLz8h+PPFPgRTWwgCdIeRM/Iw+SD1q3zig= X-Received: by 2002:ac8:44ae:: with SMTP id a14mr8224570qto.67.1603904668207; Wed, 28 Oct 2020 10:04:28 -0700 (PDT) MIME-Version: 1.0 References: <6ed65cca58736301a1cacb539a6e672aecd7859d.1603372719.git.andreyknvl@google.com> In-Reply-To: <6ed65cca58736301a1cacb539a6e672aecd7859d.1603372719.git.andreyknvl@google.com> From: Dmitry Vyukov Date: Wed, 28 Oct 2020 18:04:16 +0100 Message-ID: Subject: Re: [PATCH RFC v2 21/21] kasan: clarify comment in __kasan_kfree_large To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 3:20 PM Andrey Konovalov wrote: > > Currently it says that the memory gets poisoned by page_alloc code. > Clarify this by mentioning the specific callback that poisons the > memory. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I1334dffb69b87d7986fab88a1a039cc3ea764725 Reviewed-by: Dmitry Vyukov > --- > mm/kasan/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 3cd56861eb11..54af79aa8d3f 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -445,5 +445,5 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) > { > if (ptr != page_address(virt_to_head_page(ptr))) > kasan_report_invalid_free(ptr, ip); > - /* The object will be poisoned by page_alloc. */ > + /* The object will be poisoned by kasan_free_pages(). */ > } > -- > 2.29.0.rc1.297.gfa9743e501-goog >