From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ECDDC433C1 for ; Thu, 25 Mar 2021 19:25:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07A6361A26 for ; Thu, 25 Mar 2021 19:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07A6361A26 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B33B6B006C; Thu, 25 Mar 2021 15:25:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863536B006E; Thu, 25 Mar 2021 15:25:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E09F6B0070; Thu, 25 Mar 2021 15:25:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 4D8466B006C for ; Thu, 25 Mar 2021 15:25:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 02647F02C for ; Thu, 25 Mar 2021 19:25:07 +0000 (UTC) X-FDA: 77959374654.04.F45630F Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 3BC676000113 for ; Thu, 25 Mar 2021 19:25:05 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id c6so2569735qtc.1 for ; Thu, 25 Mar 2021 12:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BH1rH6caE39g0jiGK70AFedQ5v5dokTeZNKhqTkmX2s=; b=IRyc9FFAqElCbGemY1KCq9/RoV8KmD7cggTOOPBanhNENLNuJHxLEB42OGsXSGwdD/ BvuKH+lQqy/5wxBzh/CwNBLPveUQdXHulwbst0Y2ogYm3pE91nBpp1gQJsee3ODCkAdc atYaTp8GtEi7tjFyTGnyAi/ZBWyvjDi4rd/e3mNzNk5LhSANV5mD75BTXCMRYXYl0xIq kzIso6ezn8Xs8+cPakmGFeF/3NN4LHE8C1TvDcIK34eX2IFqDEAuFY7MP2eqivwl6cYP r0yH4fRkAM4JzQME8N/kYAY5s6JMvmMMhVz1Cr4zaInWdxqTQ3SP/TI2Nwe9PGgbT3c6 UJVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BH1rH6caE39g0jiGK70AFedQ5v5dokTeZNKhqTkmX2s=; b=o26u5C3F3iJmoDf4NoVt8N5ALABXZ3HZrJexeV54aJpjyOQ1Z9igatM8rmIUotuHHY QqFv/a03J1U6z6TpDgNx8vblklkfUafIxRoqDDowlsw0jO/wMIGrY8wfrMMFj2QozOwq FnjPIimM9OMwhx4I4aa8lQWedIUsV7S+frdDL4J5qC4eUtnu/IlVL0Iy24pcMKnHF9to HfxSzwRrnSNGTec/BJ7L98X2g9czhv1hsxQPPGnyUVQnLFSKfcmjT0p+15b9Ma+9ft85 wjMpVRAD5XAxib58bR3YdmGai72GOI+Lw5TNWqmkKqtDhKZtYqWZOz4swON9ZLH6ZekD OWAw== X-Gm-Message-State: AOAM530cqY8diI3CoVo+4DRpWzlBD/Dt4Uub5F9IgQfJKfPzncKqVcqm wxk2kIITfVrzfc1zSw9lvnRuFFhD64yp6MTJI0yV9A== X-Google-Smtp-Source: ABdhPJzaaXwX20v3NiqHfohJ32Zo0GA4QEkkDe8IObPTlCwdXwL/E9UZWjDpgXw6Zg/5DXDYCK+x5Rl4DXsDf6eh7Dw= X-Received: by 2002:ac8:4558:: with SMTP id z24mr9125555qtn.66.1616700305523; Thu, 25 Mar 2021 12:25:05 -0700 (PDT) MIME-Version: 1.0 References: <000000000000ce4c9505bdd4a48f@google.com> <20210325182046.GA15860@willie-the-truck> <20210325191006.GE15860@willie-the-truck> In-Reply-To: <20210325191006.GE15860@willie-the-truck> From: Dmitry Vyukov Date: Thu, 25 Mar 2021 20:24:53 +0100 Message-ID: Subject: Re: [syzbot] BUG: soft lockup in do_wp_page (4) To: Will Deacon Cc: syzbot , kernel-team@android.com, Andrew Morton , LKML , Linux-MM , syzkaller-bugs , Linux ARM , syzkaller Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: x95mk1rps3xaxmgtzo7n5dix4j11gw35 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3BC676000113 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail-qt1-f179.google.com; client-ip=209.85.160.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616700305-576573 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 8:10 PM Will Deacon wrote: > > On Thu, Mar 25, 2021 at 07:34:54PM +0100, Dmitry Vyukov wrote: > > On Thu, Mar 25, 2021 at 7:20 PM Will Deacon wrote: > > > > > > On Thu, Mar 18, 2021 at 08:34:16PM +0100, Dmitry Vyukov wrote: > > > > On Thu, Mar 18, 2021 at 8:31 PM syzbot > > > > wrote: > > > > > > > > > > Hello, > > > > > > > > > > syzbot found the following issue on: > > > > > > > > > > HEAD commit: bf152b0b Merge tag 'for_linus' of git://git.kernel.org/pub.. > > > > > git tree: upstream > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=17d5264ed00000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=2c9917c41f0bc04b > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=0b036374a865ba0efa8e > > > > > userspace arch: arm64 > > > > > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > > > Reported-by: syzbot+0b036374a865ba0efa8e@syzkaller.appspotmail.com > > > > > > > > > > watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [syz-executor.1:3684] > > > > > > > > +Will, arm > > > > > > > > If I am reading this commit correctly, this is caused by: > > > > > > > > commit cae118b6acc309539b33339e846cbb19187c164c > > > > Author: Will Deacon > > > > Date: Wed Mar 3 13:49:27 2021 +0000 > > > > arm64: Drop support for CMDLINE_EXTEND > > > > > > > > syzbot passes lots of critical things in CONFIG_CMDLINE: > > > > https://github.com/google/syzkaller/blob/c3c81c94865791469d376eba84f4a2d7763d3f71/dashboard/config/linux/upstream-arm64-kasan.config#L495 > > > > but also wants the bootloader args to be appended. > > > > What is the way to do it now? > > > > > > For now, there isn't a way to do it with CONFIG_CMDLINE, so I think you can > > > either: > > > > > > * Revert my patch for your kernels > > > * Pass the arguments via QEMU's -append option > > > * Take a look at one of the series which should hopefully add this > > > functionality back (but with well-defined semantics) [1] [2] > > > > Unfortunately none of these work for syzbot (and I assume other > > testing environments). > > > > syzbot does not support custom patches by design: > > http://bit.do/syzbot#no-custom-patches > > As any testing system, it tests the official trees. > > > > It's not humans who start these VMs, so it's not as easy as changing > > the command line after typing... > > There is no support for passing args specifically to qemu, syzkaller > > support not just qemu, so these things are specifically localized in > > the config. Additionally there is an issue of communicating all these > > scattered details to developers in bug reports. Currently syzbot > > reports the kernel config and it as well captures command line. > > > > Could you revert the patch? Is there any point in removing the > > currently supported feature before the new feature lands? > > Well, we only just merged it (in 5.10 I think?), and the semantics of the > new version will be different, so I really don't see the value in supporting > both (even worse, Android has its own implementation which is different > again). The timeline was: we merged CMDLINE_EXTEND, then we noticed it was > broken, my fixes were rejected, so we removed the feature rather than > support the broken version. In the relatively small window while it was > merged, syzbot started using it :( I didn't realize it was just introduced :) We used CMDLINE_EXTEND on x86, and I looked for a similar option for arm64 and found it. > So I really think the best bet is to wait until the patches are sorted out. > I think Christophe is about to spin a new version, and I reviewed his last > copy, so I don't see this being far off, If it's expected to be merged soon, let's wait.