From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7E4C433DB for ; Wed, 17 Mar 2021 08:50:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B119264E28 for ; Wed, 17 Mar 2021 08:50:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B119264E28 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E4EA6B006E; Wed, 17 Mar 2021 04:50:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2945E6B0070; Wed, 17 Mar 2021 04:50:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E74F6B0071; Wed, 17 Mar 2021 04:50:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id EA0466B006E for ; Wed, 17 Mar 2021 04:50:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A59D0181AF5CA for ; Wed, 17 Mar 2021 08:50:33 +0000 (UTC) X-FDA: 77928745146.21.413B27D Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 1AA962000381 for ; Wed, 17 Mar 2021 08:50:32 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id t16so988262qvr.12 for ; Wed, 17 Mar 2021 01:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PXKpgD8S0tpfF/4Jl42if8dBS2c84WD9R/ZEPqRwZqw=; b=Cyp4O4UBuKuRaZgByLxhrwpPMaWHFFb0EOD2eak0VGOkqSzdtZZjavXFfYxFv65j5Q Ii9UYCYGe3D34How2UtG4DECdWJLIdkgvbNPsDFMOqc9JqvkAMmEpSD7qbklrI9u2l+k DD3Xbpd4DV2kzt99QVluZdvlDPaoJL+oRQ+jeJf5x2mVkBVYR5NtTjhbKdbAE2tqhydN voh+Nuav3DagG7xs8bjp1gB59j9YBEFngNV3TK/Eq/EvKxSJWBlGYMR88/tNYPdDl6cR UCpAHQyUjJLLoREOtLr031OlbQ3Dz7ROz8FcwoT3jwyqnB9ZFsrmv4gmneVZgIEPCxkQ YmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXKpgD8S0tpfF/4Jl42if8dBS2c84WD9R/ZEPqRwZqw=; b=i+cHjOZvfNrl8mGwDQPCZpG18OKuc077bl3CyhTEhOgPP70aXwBL8b4yeyEnDOoaLx Sgslw1L3V3wzUa2z7dx/fFki8LXEm0ZvM+aEoa2d/9VaWliPWsiDSadSBNjm3EEn+aCa zFl2lkQ/bBeuoUmu4JgcHVfYrOg/Lap7XF/8RverLSyop//syfAzgXnff9RT2rZzS44o V7pcZJqrzzob+ZxLT7UlNzXB54TUNKFx/hAUYO5+LoNF/yVsNpaUzoIXnrSjWmqtvsYm k04E6qGDPmPY1RKroOEWEx0ioTuP2QklW+MMDYqkzT7E5kHmPoWfX2xDb/5CBxgf7JAq 3tNw== X-Gm-Message-State: AOAM5322oglTATSUTUNnSTSqj4KgHsYPuGtfBxm5LKtTnfQ/oUvM4Rsh V/pQ/iagMKaK9vouLnEQalqORN8jtKMDPJEzrBrWmQ== X-Google-Smtp-Source: ABdhPJw3MvrVFRDb5uadNU8fguI0OEoyzAIb8cGdqhM4lMMYb67TEvNwJKTW5/8us9UzH1Z/T0qce0OV+S/oY02V9zY= X-Received: by 2002:a0c:8304:: with SMTP id j4mr4356484qva.18.1615971032019; Wed, 17 Mar 2021 01:50:32 -0700 (PDT) MIME-Version: 1.0 References: <00000000000069802205bda22b7f@google.com> <20210316155102.GP1463@shell.armlinux.org.uk> In-Reply-To: From: Dmitry Vyukov Date: Wed, 17 Mar 2021 09:50:20 +0100 Message-ID: Subject: Re: [syzbot] kernel panic: corrupted stack end in openat To: Arnd Bergmann Cc: Russell King - ARM Linux admin , syzbot , Linus Walleij , Linux ARM , Andrew Morton , LKML , Linux-MM , syzkaller-bugs , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1AA962000381 X-Stat-Signature: enz788s5y1fa8i4g6d4qmcje96xaqnx4 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-qv1-f50.google.com; client-ip=209.85.219.50 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615971032-562295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 17, 2021 at 9:32 AM Arnd Bergmann wrote: > > > > > wrote: > > > > > > On Tue, Mar 16, 2021 at 04:44:45PM +0100, Arnd Bergmann wrote: > > > > > > > On Tue, Mar 16, 2021 at 11:17 AM Dmitry Vyukov wrote: > > > > > > > > The compiler is gcc version 10.2.1 20210110 (Debian 10.2.1-6) > > > > > > > > > > > > > > Ok, building with Ubuntu 10.2.1-1ubuntu1 20201207 locally, that's > > > > > > > the closest I have installed, and I think the Debian and Ubuntu versions > > > > > > > are generally quite close in case of gcc since they are maintained by > > > > > > > the same packagers. > > > > > > > > > > > > ... which shouldn't be a problem - that's just over 1/4 of the stack > > > > > > space. Could it be the syzbot's gcc is doing something weird and > > > > > > inflating the stack frames? > > > > > > > > > > It's possible, I think that's really unlikely given that it's just Debian's > > > > > gcc, which is as close to mainline as the version I was using. > > > > > > > > > > Uwe's DEBUG_STACKOVERFLOW patch from a while ago might > > > > > help if this was the problem though: > > > > > https://lore.kernel.org/linux-arm-kernel/20200108082913.29710-1-u.kleine-koenig@pengutronix.de/ > > > > > > > > > > My best guess is something going wrong in the interrupt > > > > > that triggered the preempt_schedule() which ended up calling > > > > > task_stack_end_corrupted() in schedule_debug(), as you suggested > > > > > earlier. > > > > > > > > FWIW I see slightly larger frames with the config: > > > > > > > > 073ab64 : > > > > 8073ab64: e1a0c00d mov ip, sp > > > > 8073ab68: e92ddff0 push {r4, r5, r6, r7, r8, r9, sl, > > > > fp, ip, lr, pc} > > > > 8073ab6c: e24cb004 sub fp, ip, #4 > > > > 8073ab70: e24ddfa7 sub sp, sp, #668 ; 0x29c > > > > > > Yes, this is the one that the compiler complained about when warning > > > for stack over 600 bytes. It's not called in this call chain though. > > > > > > > page_alloc can also do reclaim, I had the impression that reclaim can > > > > be quite heavy-weight in all respects. > > > > > > Yes, that is another possibility. What writable file systems or swap > > > do you normally have mounted that it could be writing to, and on > > > what storage device? > > > > The root fs is ext4 on virtio-blk. > > > > There are also several dozens of shrinkers that can be called during reclaim: > > https://elixir.bootlin.com/linux/latest/C/ident/unregister_shrinker > > Right, unfortunately I don't see a smoking gun there either, unless you are > also using NFS or devicemapper. > > Implementing VMAP_STACK as you suggested earlier is probably the > best way to figure out if there is an actual overrun of the stack. > Alternatively, adding support for GCC_PLUGIN_STACKLEAK might > also help find out if we ever get close to the limit. This is probably > less work, but it might not actually help in this case. VMAP_STACK is quite intrusive as far as I understand. For KASAN I considered a simpler option: have a debug config that allocates an extra page after the stack and mprotect's it. It wastes a physical page per task (fine for a debug config), but I would assume should be radically simpler to implement. In the end somebody implemented proper VMAP_STACK support for KASAN, but I still think it may be a reasonable compromise between time investment and value.