From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A466EEB64D9 for ; Thu, 15 Jun 2023 11:58:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9ADF8E0001; Thu, 15 Jun 2023 07:58:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4B346B0074; Thu, 15 Jun 2023 07:58:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D12A28E0001; Thu, 15 Jun 2023 07:58:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C1DE66B0072 for ; Thu, 15 Jun 2023 07:58:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 92874160BFB for ; Thu, 15 Jun 2023 11:58:53 +0000 (UTC) X-FDA: 80904835746.28.5B3972E Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf03.hostedemail.com (Postfix) with ESMTP id D0B2B2000B for ; Thu, 15 Jun 2023 11:58:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WV1XjiHE; spf=pass (imf03.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686830331; a=rsa-sha256; cv=none; b=TaZym1YYgX5lGexbmvtLjat1mmfDHY/wIH17xae/j/CrO2OOOp+z0a6NZdUA0LY91fVEXD 47Xtmpt7AWRcr1ooevHcX2l8VKLupO0VzBPIFiFgT6jBMmsWzdtqzUSWM2CClMC6cxASE4 Ntzr6PcalNZm1bA6o7sgkw8QiN8ra+k= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WV1XjiHE; spf=pass (imf03.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686830331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bNHs/NR0g3CX4rW6Ho5JPY5yd2snM7LkZeKUoyaN2ks=; b=6gT894/40aZk4WNGJOEGfwBDSLWvYKfFsrWVP5kbysm6v/ls5Oy/wMv9kX3Nfb+F3VF7vE auu5Tzq7r0tQ4zk7AGHOXFRBtUFZSMC8kDzWEelsoYMd3MAQ3nJwnNwcblSQgbcpLTxo5B 69thWsN5mdBiNfa/ZWHM1Iv/54GmXQw= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-25ea4c913bfso103646a91.0 for ; Thu, 15 Jun 2023 04:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686830329; x=1689422329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bNHs/NR0g3CX4rW6Ho5JPY5yd2snM7LkZeKUoyaN2ks=; b=WV1XjiHElJw1Dt3NqHZK44RMlOQSXYmk9mEYfzgObb3VsK8oAGUb+OAM2MLVaU/tg5 G12vn9VD7ij3vcUmK9wtMNlp19C8vMlDfkHAdmGbI5YMONVbhGcoLpUvuaoRh7kF6PNv A9UoEHfRvVPVitjoMsuGncjnAgkyACv525U31JYBkMmqLXMnEZOhxNI4pYU6RZHmPAPZ LHPdfQ+b1e+Y/Q5lQ4p+kstmmpl+B13kTv/ai8ePLcHL997uUqAmbOoULuIuHiW7vqRs opzj5nFbzlgGlKw6+IbURjL+8S0ZuwCUtZl5eLxeMSBDX+DqSM1Yeyn7O0veq6KqDhQs zq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686830329; x=1689422329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNHs/NR0g3CX4rW6Ho5JPY5yd2snM7LkZeKUoyaN2ks=; b=NVyiHMvVsvFCce7UyXb1FEdmCR2CYKYehWFG/LkK654D4tu1AA/77k8DsSsCHj40wh TSvMD/ZW0vP3f21ZQ5gKzjPyBwFlEbFuO0npH3c2VmeRtIHybwghhAv/ruOtOQx0ITPQ jKDJadpH2SL0T/1sMGQFwPueBxc03Yw2YzJu+vDx77gNXxuTzIfBK+qprcG9iRzPWbGo upFli95jCSRv0tSNNwTUmAkcsgIu62rNBNSHGlglGigakF7QhZj/7IXENgjmYMurTKXo vaIlQCYllsyGyt1ZxHkhslv8w14mQevfGpP/9GtYNr0airmZyhey4xt4g8MyNHiy+jUK Q0fA== X-Gm-Message-State: AC+VfDyvV9h4ONXSkxkw2Pu2i5pTZjfot+oUEhfr6zXz6MEuoFuoC8I7 LTJ0wEHqq3IGS4+JVFU5N1FE0EgqVCHyX6juyq+S6w== X-Google-Smtp-Source: ACHHUZ7H84huBYjF2DEKDb9mSSjBrZREUPgUPr4YGUukPXUxSgt0KbpwnJnKEx26CCSb63p91mc7xHdbX27D8ZU26X0= X-Received: by 2002:a17:90a:804a:b0:25c:7f2:2e5d with SMTP id e10-20020a17090a804a00b0025c07f22e5dmr4083701pjw.13.1686830329333; Thu, 15 Jun 2023 04:58:49 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Thu, 15 Jun 2023 19:58:37 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: Michal Hocko Cc: minchan@kernel.org, senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D0B2B2000B X-Stat-Signature: nsuseoabf67eifsg5z44xjktbmnzwypq X-Rspam-User: X-HE-Tag: 1686830330-25724 X-HE-Meta: U2FsdGVkX196c6sTvW0vSVytiqrKFslHDe2LNiti4C9E7JpF0HP/02DXL7Tl9rmdSIcZOeQJYODX1sA8uyfZTsFYAG8Env6B9ZYV+3KzByF6HSrroA9q2cdc/NcKHNcU3nsIEaTb/Yi9rnPSNPEye86zKi21DYBfBBtNRYyrk9cy105KUhPN8jukLfMSFC/DsIMiCHulX6oworfS0LSvNs8W0ZT4YMI49BG37araFBEXsPorX4gaFC/xLCb1qXKHR6qG11/PJZmtRVyDBp2Ns1L4ztKAfabSJXuYxn+nRyD8iisu+XcmFBYDLMT2CkFxji50Uq7dtJuUUaODW+zKrWoMmA9tu2+3U9DXRuJgPDkdTDhwv8YrR2pllRCyOFlrEhFpRaEVDQmDCKfWhjmfhIZT/XfycMVsVpcuLAdY/ODKSCY802zRIw/siZxN9xYNbE6bj4F4fHsOSpvqlIhDLEBpqxdkU+ANJ4/I+soeXBn8fAJEQKOtDFP5EABgqAuYsu0IyNNcBSQ2QuLIkNha7zW2yYUeo60ZBSUOaLCJYoIXY3z828cWij5N0ctt446Oxe8WSnCPM86n0FUCKYRpLX12dF2+fUsXuVnz8f+XAQGCNFBPTZx+MpAW6QPdPeTLrmDncnaMjou6IKiO9VXBUReF8jcq6TEJN8aIybqgFPwF/sPiytKZfSSdnWvXp+5/BEP01svyOPVni4buSjCcWLH2Df/mEWsYfx3/3RvhG7KYAbEVQqIpQdvDKU2EvMu4tPm4XRPMtS7ZmKphiEUIRIY58co2Z45ye2eqYznfIs4KA/2e4BZZI0Vxntsk2LaonxOOJ5wlZVy99o6YANt+tmWGhxYXsMy0T2Ko/WfgOvZUEmEMHODqM1Ea4Et37FdiDrZAF4Vox3WRLkYI4CcZ5KNSsU9gTpMWpfN7rDC5zxTbZuFy79MduEUm/1g10o2Rb/r68JaEd0IxdNXyeim iNFgybDH EAbuSmytBhHevKkdthva/bN5QAkQvGoekcyDQSh8gpnHq4Fk1j+1UCPHvnVVJY6q5V4HduKGvbGMk6dKbcDboeUo7AkWW13GXPm4DkEt40KfQvv15L+6DCDuJgOp+fQMO4mypDBj238bobRvmK0JO3rSfiZIlXtf9vyP/8ACKUfIEhAEOAog4d6BcJp6/JduBNdj6v+L4eJX3e+yyHXl55SKx4UbkMOSJe35WK4UJ40sAvu7luGDnvfblbv7kqtWhJ/W+Hif/6vZ2IYfh6ZJcl6JAus7ID7220x9k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi michal, glad to hear from you. > I am not really deeply familiar with zram implementation nor usage but > how is the above allocation going to be charged without __GFP_ACCOUNT in > the gfp mask? Yes=EF=BC=8Czs_malloc() did not charge compressed memory, even if we add th= is gfp. so we need to implement this function in this patchset. But this flag shoul= d be used to enable this feature. > Also what exactly is going to happen for the swap backed by the zram > device? Your memcg might be hitting the hard limit and therefore > swapping out. Wouldn't zs_malloc fail very likely under that condition > making the swap effectively unusable? This is the key point, as i said above, zs_malloc() did not charge compressed memory, so zs_malloc will not fail under that condition. if the zram swap is large enough, zs_malloc never fails unless system OOM. so memory.max will be invalidated. > -- > Michal Hocko > SUSE Labs