From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFA3C47258 for ; Wed, 17 Jan 2024 10:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 142E16B00BA; Wed, 17 Jan 2024 05:42:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F5D26B00BB; Wed, 17 Jan 2024 05:42:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFD4D6B00BE; Wed, 17 Jan 2024 05:42:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E39AA6B00BA for ; Wed, 17 Jan 2024 05:42:00 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A13C8A21DC for ; Wed, 17 Jan 2024 10:42:00 +0000 (UTC) X-FDA: 81688462800.01.07E28C3 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf27.hostedemail.com (Postfix) with ESMTP id 0691140003 for ; Wed, 17 Jan 2024 10:41:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=EnRYKGW7; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705488118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ml/MfLxZA9QQVAxJtw3+x9j+f1i/P0GKune3jqkXEnM=; b=bG4xBZYPJ8as6kPyMfXMeip66mbkmMkzg2E+OdKdPgs+Odu0HzJ0VS00ECHaTsB7khazj6 E3ayuEG9vAhHadQZ9WLv/zxfSNYZtHttxhR0N9eD4aF/x93y+S+qdusD8rRjgJzjeth5qK xfqdXHi7zKM4V2zzWF/G3luJuoV9FMs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=EnRYKGW7; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705488118; a=rsa-sha256; cv=none; b=T04ZXUvch/17ZJDwIbRMm7FcWU4j1wtFIPffMP2j8YC2KHXyy8hgdJitmliIIO5rJW8cra 9MoUPL7SCUc/gdnLzDNWUIxHs4agpicVtrsFWOJofdqwkyJ9gbv0qi6UbX1yPsRt6SX25M ioRjbEaJziqU4ZelAVuR3xxwQn80LmE= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50e759ece35so12883478e87.3 for ; Wed, 17 Jan 2024 02:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1705488116; x=1706092916; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ml/MfLxZA9QQVAxJtw3+x9j+f1i/P0GKune3jqkXEnM=; b=EnRYKGW7nXDcvRnK3+tgO2Gy/g5A75D661VF9GjxfxdSdouvWlTDKsZX5S3M4eMlkH xRPBCFcVbWxbc+rpu3/0oRdCTFCtegOAditaz3OmEohvgat2QK1ATfjkO6WGSoTQBzdC fwSgd90U+W2Iou/bGk4vhmZ/YcHnunfLFvmJ54J+Tpp/l1I5gs+VDHB6nPtzWVHEeYuZ 3hspwba0uO7NrQ8yQ0EHbGWEtrbnJJp4424KS8QjtHE4OY6Xeem8HCtasfL0nYMJiLfR fGvumBvscHC+uQfvwUEjO6lI7HkkLFR/aG4z5yjbZj7/t1naWhZ9UKv9HL8UuEjF7E5e 8ANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705488116; x=1706092916; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ml/MfLxZA9QQVAxJtw3+x9j+f1i/P0GKune3jqkXEnM=; b=RUUHrNf/9MrFZsRCCw05LlrZ44Y1j2iz1IjJrlQ7bsV6LaY34/yw6HQ9LJS7nfbHMX 4s5gfrRpeOhiBdXaub+VE+4m3ZFSB9yM3qSrm9m/UquDzNC4/2guLDdlDcHbfLQT1sgx 8uWxgrLoXSJWiSDdjUzHwy3NxaUjoPOUPxfE+i7J2byERDwK3aCfR9OPOlK6Ucy1yEYj wFljGMl+BIX5k7E/PtKSNOu8tYHKIbqsumhAYdSg7KehjPzdC5faQcmayHj9GZ9FrrTu ZYVjR5EuVjd1Ud2Hv0hA5xGr8WEwIpkX6GvaJzPqkqsIpmYXtqnLsxLUcCk//tmsQPUd Bxwg== X-Gm-Message-State: AOJu0YxxyP7QlWwTXhH30F+/WE6ROG1ihFRtX6PAFLNa/IpVcnMQ/ety GX2vjY6jvVa94iSzPK/pi74dI74cbDn4LSKXZbc8gArSLfRqpQ== X-Google-Smtp-Source: AGHT+IHn7NoY0mFLYqrNPCg6GN+AmYgIAkxTkpLvX3vOr34ct/gxyyER7E3vRvM/PloFq3rJzA17vTgMsnHIRM879+4= X-Received: by 2002:ac2:4c41:0:b0:50e:771b:9a9a with SMTP id o1-20020ac24c41000000b0050e771b9a9amr4543582lfk.73.1705488116076; Wed, 17 Jan 2024 02:41:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Zhongkun He Date: Wed, 17 Jan 2024 18:41:44 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm: zswap: fix the lack of page lru flag in zswap_writeback_entry To: Matthew Wilcox Cc: Nhat Pham , Yosry Ahmed , akpm@linux-foundation.org, hannes@cmpxchg.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0691140003 X-Stat-Signature: m54tc9fson8r4rdxkxpdb99gx3b6puf8 X-HE-Tag: 1705488117-920413 X-HE-Meta: U2FsdGVkX19wsTTTCQryNxizULSTA/cKzHYkjMnkm3fcEEdRLfdg2sdZbMApy6kY/UrA4eepeS6b+d9jes69MYQLkIGDOUE3G852woYZ2k0XMGw8Tmb+hf4hOcv/DpMUE1Q3B2F60cl99dAwsOMSI7AmLx1CV7sm4F1HHMRB4xpNerU7YAT/CmcDcUFQ6+fX9dnMZi4qfMsV3D/1yiKd2YoiCu2grr6410u61kSofucZnz/Hin5kxbql28Io7nGT8x0mwU1qhz4CyHsG+YDVK/IXpAY9TKhzIBqu+tcblb8Ozocr3PLtEnB/OQNWTjaIGyD1Lq9+EdyibsaHA8uHikod+ZYl6FoPJBQj+p0kpMoN/dHc8K6n39ZF+zsxd0Sxqgjly3/ce1kvJucKDzUkllLGafk21JT1CG7LmPfm7V5rFJ1guaPO5Zn/GNY1lsXaXhhF3TRt/TjRp5FBQ4MkEtdmi6DfJNmMW8ViUW15jKGlnNWDgxLxRCAtrccg93N6QaoiBiwxbRpbdLclA5LY6E4TFjjvMH0rrgldfs9m/l0zKy5O6OAs9YBxgnG3RoPzU8hl4I2+njWJgqesWo1L/6+z4n0dN/LiQF4YdL+zk3KBqx7mTjLnpmDa6Q0ac91lYHYelYztGiojWOGygDJnjBUySk9vmoDzGaNfALfEOQgfH4Vyoowt5fXstbFuMzcworuFntL7Vu2WPIzUnwvR5ayfhpZ7nYnLJ0jlNNTPQWv52n7YSy+LYtbSf5AIrFmBMHiePMjVg0YS2+PedvUJbPP/kTrqIUX6X+VVs1rV2pk7315afEvVtsEyPtxlF3NbHuy62yvXvs1TH1kLFlGNvPAkkmhjdxd1gFi+LBDVDrOe/7vRde766VuN4tNnxIEwbE8M/D7x+v5fYVHFWBWOoK1mqjd1ToLxzKeTzbqGtZPP/pgRNg+ubZPTBfvp0TZ2OzPkdB3y+E0VhA5kiKO ntml9Z0h ZOtE+I2WXZzh6ylnWtu7M0gSh/+R5YuJVaciLh8xq7U93EHbkaQHNJte1PV603klgf4bBNwpSD2tCJTW/tyCjVjDwvhTTM7GEbl9wsxa3cB144VNCpjyhusmUuvjraDaR5Lvtv7TLUdAXViqjOyp2HRapfyZNgCBAwqXRtlO1IeXXHSTNAUuYrP0ei5D/kIuKch26o6Z+9m8O3ylETcuIgcoquyqAe6Pfs19bYKP3ndj3SGzI/JWoaljPDCUBWqghWA9HqTZ8SB0kZ1FxBUYt9ziVr1e7gqsPxM2RBtq54YjCjkyeOufwsv3EokmMNbBAA2BC/njMVvzQ3sETfP9Bfb9ij5Z5ruC6BqAUEi/6UTNjgIfochk5wnuVQu97ZeK5mfzTMgkbfAcMYhQ36FoaYzh+487abd1YjkmS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 5:04=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Jan 16, 2024 at 09:40:05PM +0800, Zhongkun He wrote: > > 2) __read_swap_cache_async has six parameters, so there is no space to > > add a new one, add_to_lru_head. > > That's easy enough. Define a new set of flags, make one of them the > equivalent of skip_if_exists. Something like: > > typedef unsigned int __bitwise read_swap_t; > > #define READ_SWAP_SKIP_EXISTING ((__force read_swap_t)0x00000001) > #define READ_SWAP_ADD_TAIL ((__force read_swap_t)0x00000002) > > There's only six callers of __read_swap_cache_async() to convert, so not > really a big deal. > Yes, thanks for your suggestion. The major problem is not the parameters, but the need to add three function= s to deal with a special case. Thanks again.