From: Zhongkun He <hezhongkun.hzk@bytedance.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosryahmed@google.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org,
sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Chris Li <chrisl@kernel.org>
Subject: Re: [External] Re: [PATCH] mm: zswap: fix the lack of page lru flag in zswap_writeback_entry
Date: Wed, 17 Jan 2024 18:41:44 +0800 [thread overview]
Message-ID: <CACSyD1PYm4wwQvOjkHZVcfuo-Voa4ABZ--n3K70i+s5ag9KnfA@mail.gmail.com> (raw)
In-Reply-To: <ZabvMpeoKzTMUS2U@casper.infradead.org>
On Wed, Jan 17, 2024 at 5:04 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Tue, Jan 16, 2024 at 09:40:05PM +0800, Zhongkun He wrote:
> > 2) __read_swap_cache_async has six parameters, so there is no space to
> > add a new one, add_to_lru_head.
>
> That's easy enough. Define a new set of flags, make one of them the
> equivalent of skip_if_exists. Something like:
>
> typedef unsigned int __bitwise read_swap_t;
>
> #define READ_SWAP_SKIP_EXISTING ((__force read_swap_t)0x00000001)
> #define READ_SWAP_ADD_TAIL ((__force read_swap_t)0x00000002)
>
> There's only six callers of __read_swap_cache_async() to convert, so not
> really a big deal.
>
Yes, thanks for your suggestion.
The major problem is not the parameters, but the need to add three functions
to deal with a special case. Thanks again.
next prev parent reply other threads:[~2024-01-17 10:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:27 Zhongkun He
2023-12-29 19:44 ` Andrew Morton
2023-12-30 2:09 ` Nhat Pham
2024-01-02 11:39 ` [External] " Zhongkun He
2024-01-02 14:09 ` Zhongkun He
2024-01-02 23:27 ` Nhat Pham
2024-01-03 14:12 ` Zhongkun He
2024-01-04 19:42 ` Nhat Pham
2024-01-05 14:10 ` Zhongkun He
2024-01-07 18:53 ` Nhat Pham
2024-01-07 21:29 ` Nhat Pham
2024-01-07 21:59 ` Nhat Pham
2024-01-08 23:12 ` Yosry Ahmed
2024-01-09 3:13 ` Zhongkun He
2024-01-09 16:29 ` Yosry Ahmed
2024-01-10 1:32 ` Nhat Pham
2024-01-11 3:48 ` Zhongkun He
2024-01-11 11:27 ` Yosry Ahmed
2024-01-11 19:25 ` Nhat Pham
2024-01-12 7:08 ` Zhongkun He
2024-01-16 13:40 ` Zhongkun He
2024-01-16 20:28 ` Yosry Ahmed
2024-01-17 9:52 ` Zhongkun He
2024-01-17 17:53 ` Yosry Ahmed
2024-01-17 19:29 ` Nhat Pham
2024-01-16 21:03 ` Matthew Wilcox
2024-01-17 10:41 ` Zhongkun He [this message]
2024-01-11 2:57 ` Zhongkun He
2024-01-09 2:43 ` Zhongkun He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSyD1PYm4wwQvOjkHZVcfuo-Voa4ABZ--n3K70i+s5ag9KnfA@mail.gmail.com \
--to=hezhongkun.hzk@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox