From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA342C71136 for ; Thu, 19 Jun 2025 03:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F1AD6B00A6; Wed, 18 Jun 2025 23:18:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B2276B00A7; Wed, 18 Jun 2025 23:18:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EEE46B00A8; Wed, 18 Jun 2025 23:18:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4DFEA6B00A6 for ; Wed, 18 Jun 2025 23:18:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A7C035FC09 for ; Thu, 19 Jun 2025 03:18:39 +0000 (UTC) X-FDA: 83570692758.13.9DF31A9 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf25.hostedemail.com (Postfix) with ESMTP id CDB46A000A for ; Thu, 19 Jun 2025 03:18:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QVjQAfuN; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750303117; a=rsa-sha256; cv=none; b=LtSLKVj9gN2Rx/qkrCoRv1x/AD6cAD2/Sm55B550j3P8dp6eJm9jBSFLLf71LuPWDsPYHI pJ2cHKektCDK4TX9hOhMvEJPJVv3NfvmcYRSMZ8BIsoPlLAGpiGFkkBW/lgjGnY+DgqECU 6SNpyfpMnNxhuBuQf459od27YLt24Ns= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QVjQAfuN; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750303117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h6NkPCHYEoZsUFSw6jIHPSK470nj4uo13JKCT/+imIM=; b=ovlp0jZhFgYChg5sCcnJnY9OCxQFY9TQUTildrMimN1AMfc7cWsoZ1J+JMauvGM0/f9whe /sm6U28OigDEOIap/EapbqrUWFEqLTK7+QbHL9w5aCa1oX7KFl9gYvhHNLeNHcgWlksnO+ spOWeXpVrQzYOiXlHGhp4TksRZesO+o= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-553b584ac96so299978e87.1 for ; Wed, 18 Jun 2025 20:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1750303115; x=1750907915; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h6NkPCHYEoZsUFSw6jIHPSK470nj4uo13JKCT/+imIM=; b=QVjQAfuNiUY12EjmlZKCV/f8TmQD7yHq1umEjLB4qMrLgTuoKmA4mrcb7YAe7fSVY7 EA7cZvB7VvxGO0g2uRUKAtg5an//tKns5UKQCFqxrKwUOrYfi4lbhRW1ypkuEzfYTVgy nfpbooVOcN6Sk2p/SM7CduiI+/8SvbxpdjS/IGT9PJyeme9DV+6WVsg7wMZ7t+fz7CdS 6ePQSVJfTteJmo8+1vrftEGuYJvWlMP2WEY7dJyFrnl/j+qMcrPpYR4wxvruC9S4zjT7 XtokoPQV6xLEj16kLsU5653+WSI8QuHf6UNmwHzEqO3QEmPLvly9b6Od5IL6OSM/icDm JQJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750303115; x=1750907915; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h6NkPCHYEoZsUFSw6jIHPSK470nj4uo13JKCT/+imIM=; b=jzuy0vTbB34nvMjbmGfdd6HlmfjBsekJ3V7+Vbzx2KfAoFdUAzYl/grsDRvi2OW/Lh tIqEvr0ritdBrjY8M2fDQgEHpP8N/oqPFhXCK7QUsTkXt1MUaNWZ/JB3xrZ/xwKu01qQ omHrpMsiyvSITG8GFzbfiwZJ40W2XJylcWwuPQ/+dL/VjdsHXR+R8k7BpR9O7ZR9wHkJ SAXlti8/XppcAxKO6tKe9+HReVpiSIfZtELpXQ5OvEaHK01euQAV2e6gbEbnE5Efo7yY E5fCNwq6jsLQsYhnocTWXXS1UZM5C/6cxYBUeLUdeAffQylxrW33U4oOtdeFuLP9t6Dg anWg== X-Forwarded-Encrypted: i=1; AJvYcCXIP8GcD2+fiW1QLt3iXLqa8+xwPeaJs4b476Ifum7ui8EeijFm92bHXqpVu+e4YskL71NSrZlrFg==@kvack.org X-Gm-Message-State: AOJu0YxHQCVTveznpTBsejIPmT3KBTgpXaT5GXtICLxIbEZnzSvbMmzg fApDXvM1XYol5K5GTtn3cQofNPGA+4p70GtKmPiFqXE0biVItfRsL2q6+RmYIIuZMo6vdWVx3jx 7u7asYE/uIAADY2rvIhrHjVOGcljvtN9GX++I9TaRKmwqCGJxeMWp+SQ= X-Gm-Gg: ASbGncvvpWY3hcN/qE3dFbUEj56UbdlXCKsqPxO24w5zRZXCDDCZTk89S55KscYz/4P PuIEqo3M7jtaib73WG3mL2YDllX8vEIllAsDDztfYeP5xRNZpwVVuD5RuFQ9COIgr+pXM0JQ5um Y3NTYBt2jBOp62UlAHUUyE3/wclTNrKtQF6YR+JHGYqk2vg0169hza/xhScw== X-Google-Smtp-Source: AGHT+IHKjrphxhIm9vilp/aQmrbgmu6S+E/zwZTB7dNpu62I00LyyEn65mgpkmnCNH5/lpGLxjtGUxJxYD0Awk5yviI= X-Received: by 2002:a05:6512:10d1:b0:550:e608:410b with SMTP id 2adb3069b0e04-553b6f1a12cmr5542468e87.33.1750303114901; Wed, 18 Jun 2025 20:18:34 -0700 (PDT) MIME-Version: 1.0 References: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> In-Reply-To: From: Zhongkun He Date: Thu, 19 Jun 2025 11:17:58 +0800 X-Gm-Features: Ac12FXz628ssSehvnNEODzLupA-PZ9JlsOYBcKOKn58kQjOASv9O20Rq0e79bOg Message-ID: Subject: Re: [External] Re: [PATCH] mm: rename the oldflags and parameter in memalloc_flags_*() To: Kent Overstreet Cc: Andrew Morton , mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: CDB46A000A X-Rspamd-Server: rspam10 X-Stat-Signature: gk7e8sxwbuopgebf8bf585hbwyd718z9 X-HE-Tag: 1750303116-737966 X-HE-Meta: U2FsdGVkX1/fbU+KEvk2KleGGSjBIq1oy+lIHiTI/1IHQn9bSmvm9iYVoLcOcBTqh4ig/+SgweUbJYvBRRblLltAa7NtaMPAlvOHm/G1pkMcTt6fua+YQRo1iiOzFb0tDoI2Dal+yCr/XFL7SXQo4tRDB3I8uI9ScEOpX9A3DHca5JKGMvMZKRNRqcXJY+nCxKAsgXopAY3EaMFRPdDPsVu8MniQEg+dkIW88QQaGl+Ces6finAt1OIOOSNgh4XU+EV/I5TFQOyGAg12VYQCBLHFW/opq5Vg37CSqvHhOIXT8503H39kvVtAM0akjCWwuqbDfw6JcsL358Q0/1EIXaC07VQEGBJZMbIel47eOtaeVGG2sz1X1Ja+TUDN0KMB1VuxJ8nWzNsPsT1syXB7UvRJtNfRr+xIPAgt7kJQ/mjEsMtRhWhDpwVANkT+Sv3AYC9XSqWi8K9somm3a5eWYO4bl46P9BrQLZ7L+NN/rlCJITKfNaUWR2plFQHky5SOugmyfJtMI7epxDHTGepO0UlCc6FokC2LpxxP7Ep9w4FeeGAXbcxj3K14oAEioxMDFymSvoLHN3hEu9v9GxVAG4Rnn4/ncJqzog6QjR6dCUXBkKBkhdtYK55YROMsrLHV9FSVQCFPyFwPPxQm0/pIFx6XMlT/0Qgq15DYX5upLdPEOw0HArnwVf8Gr6lPFSr7N6MQ87l6tEAeGH877ZUWUYc5sMhVR2BBVJIY17IHw4XWWMKWIkHnIxXa1qQ4sk4AGIw4+4wvr85u24p6DcVEOwn5X7VdPr4efKQd6/T3IyCagTVl2wNE7auSzPybgGkLE2BDfBzt1uYlNYp8vkYoKVvxw/vsrzOFVy98+2SsW0tdcF1x3iEm2PjXnyO0vJqSv+MdQmyqJ1CTYiC6JXHuxn4Mxb5ehUHjLPCfA2WQhts2fPwKXoSvt6m12FW0QKQ56GmBIK+zk06CqRC1NYA Ip2E3Z89 t4K3o4jzFXuzgDfggaeptvYTnqomdqgy+qQQDtVo9tN3AoTvubFmP0PHqb3g0opP0FVsivjDxc7XCxbCwpMuxddYDhtiBh4+bF78E5BgTumZsEgr4tsgQZFXtLmog/aSYCWDbJfpN7EeNM3tW3WO95gKOj/ft59cBRE/E06nIT7N22H4ck7TSKHBXQQ9qTbVabwWkeH7QQgVLTuLfti46AANEojZ1dSzXwStlL24z/ZusFM2pao8h9isRtuHRoDUQ8Rcpfp4mlXYCslYg1EwIFjKCcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 8:07=E2=80=AFAM Kent Overstreet wrote: > > On Wed, Jun 18, 2025 at 04:43:34PM -0700, Andrew Morton wrote: > > On Wed, 18 Jun 2025 15:03:28 +0800 Zhongkun He wrote: > > > > > The variable name oldflags can indeed be misleading, because > > > it does not store the complete original value of flags. > > > Instead, it records which flags from the given set are not > > > currently set. So rename it. > > > > > > > Your email client is mangling the patches in strange ways. Please send > > yourself a patch, figure out why it didn't apply? > > > > > --- a/include/linux/sched/mm.h > > > +++ b/include/linux/sched/mm.h > > > @@ -322,21 +322,21 @@ static inline void might_alloc(gfp_t gfp_mask) > > > } > > > > > > /** > > > - * memalloc_flags_save - Add a PF_* flag to current->flags, save old= value > > > + * memalloc_flags_save - Add a PF_* flag to current->flags, return s= aved flags mask > > > * > > > * This allows PF_* flags to be conveniently added, irrespective of = current > > > * value, and then the old version restored with memalloc_flags_rest= ore(). > > > */ > > > -static inline unsigned memalloc_flags_save(unsigned flags) > > > +static inline unsigned int memalloc_flags_save(unsigned int flags_ma= sk) > > > { > > > - unsigned oldflags =3D ~current->flags & flags; > > > - current->flags |=3D flags; > > > - return oldflags; > > > + unsigned int saved_flags_mask =3D ~current->flags & flags_mask; > > > + > > > + current->flags |=3D flags_mask; > > > + return saved_flags_mask; > > > } > > > > > > -static inline void memalloc_flags_restore(unsigned flags) > > > +static inline void memalloc_flags_restore(unsigned int flags_mask) > > > { > > > - current->flags &=3D ~flags; > > > + current->flags &=3D ~flags_mask; > > > } > > > > I guess so. Maybe. A bit. Kent, what do you think? > > Eesh, seems like pointless verbosity to me. Maybe don't change it if it > doesn't need to be changed? Hi Kent, thanks for your feedback. How about this version, only change the 'old' to 'saved'. The function does not return the old current->flags value. Instead, it returns the subset of flags that were not previously set in current->fla= gs, so they can later be cleared by memalloc_flags_restore(). The name savedfla= gs makes this behavior clearer and avoids confusion. /** - * memalloc_flags_save - Add a PF_* flag to current->flags, save old value + * memalloc_flags_save - Add a PF_* flag to current->flags, return saved f= lags * * This allows PF_* flags to be conveniently added, irrespective of curren= t * value, and then the old version restored with memalloc_flags_restore(). */ static inline unsigned memalloc_flags_save(unsigned flags) { - unsigned oldflags =3D ~current->flags & flags; + unsigned savedflags =3D ~current->flags & flags; current->flags |=3D flags; - return oldflags; + return savedflags; } Thanks, Zhongkun