From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5A9EB64D9 for ; Fri, 16 Jun 2023 03:31:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 219CC6B0074; Thu, 15 Jun 2023 23:31:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C8956B0075; Thu, 15 Jun 2023 23:31:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06A8A8E0001; Thu, 15 Jun 2023 23:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EA4AD6B0074 for ; Thu, 15 Jun 2023 23:31:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B4AB780A8C for ; Fri, 16 Jun 2023 03:31:33 +0000 (UTC) X-FDA: 80907186066.21.35F49FA Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf30.hostedemail.com (Postfix) with ESMTP id 57F1C80005 for ; Fri, 16 Jun 2023 03:31:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=USQ7+vYB; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf30.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686886292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZnVRVEex7zv96gP6Vvvr955VJfIGHw0Z5yBXSHEzL9Y=; b=XG/9VHYx6jL/6QjnOzpfdaOfB7auThj/KMdZc7ruywjOpoe2PGMfpoiVsnNh+FHXO3wBaF Y9zY9O+1LLi+ZYzKTJSTerEfpzfOMJ7Pu2zSphXgAFLbLj1/5149w8TiPiBh+LsgU2VC8I cxu0tnJVRD25cpfF73kR94h8y1TQcrM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=USQ7+vYB; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf30.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686886292; a=rsa-sha256; cv=none; b=WW5Tn2o9t9AWWOcBcv570e1jBL17xvWg3rn+NXsRYk8nI0vHgYm7H11fevojz84bQbd9Kp 3xJl57Ou8BTML1mVTzqLYSIJMJafhK5kSd5VdUCcGLOwn/Tyqs3U9mXD4GACgp4OT4GJm9 FLejxbht/p+3aTlE3y03k7OHewaQGQQ= Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-558a7faa989so159168eaf.1 for ; Thu, 15 Jun 2023 20:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686886290; x=1689478290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZnVRVEex7zv96gP6Vvvr955VJfIGHw0Z5yBXSHEzL9Y=; b=USQ7+vYBVyVXupzKlH4ARI7VEYpIak1CEUzK/eNJwX3kaZ23Wv6FaHQWUT9bfKSM2q Xo+8H2Ni4LvHVaqJi3nZELFHPCnRlHUEmPN3bGQyF3JgWU1GBgzhV1cPohpAuovFlX+r F+vSlW6RbFXYBHg3TrnYOlxOSU/I/ju70VJPWH56IblpWXr7yHYs0t5Rc1YntOFAX03Z mF7ths37qrT/YbJwh3F56fjIvyR9O68/ionTyl5lD/KvrufaM6BErU0zGu2cJiOv+Zye UzJG2FqcFJMGm6ud8usoK+G51Xf5084F1lkhxfW9NOFyMePOxzroze36oocAzHx4KH3g tOVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686886290; x=1689478290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnVRVEex7zv96gP6Vvvr955VJfIGHw0Z5yBXSHEzL9Y=; b=axa5HBIR+SlluLAe9rNfTpji2vgnJx1F/Anf15iVzGNY2DG4EduwcT7cKdavwZ340l 7jNzr992niT1eGoL2tWnDNO47cwftqAGnC3e4KdKfWDDePKuevVvhxHoRm/FoAOUVkHs p0ZkIT8gXRvmjJE7fKxXRLGcUFIkJhkIEVIjr+MgYGXZ/uleEGrHzXeNJsHhZLC6QA7X Y4mTJhn6gCz+nWPNJL4NBl6CR4JVoK11wLzzQZ/82ltYBSc7EkpYRdyf/edEwL2bglP9 dovcmp6LERc9dtV2UwXG9eantl+NqjXPScjv9NiwMvZQ2621IBEEOXtL5/vcaTBSgmFM rqZg== X-Gm-Message-State: AC+VfDzNrl0iKVgz0OEyobDz/pC50tVPbNcMs63QW04jwAi1SbHuB1xD VrGpTxtr6bMaxM7Kp8k8B6k/L0y1OiqfJsJdUV0flQ== X-Google-Smtp-Source: ACHHUZ5lTiATGTCHFxAVboCkbg2byvFYf5+kw7yI4S0FGUFwwSonU4oseJqQzzGOcZpRpMnwYQUh+Pv0eVOL03QFZH0= X-Received: by 2002:aca:c45:0:b0:39b:d6f1:36e5 with SMTP id i5-20020aca0c45000000b0039bd6f136e5mr1000182oiy.50.1686886290150; Thu, 15 Jun 2023 20:31:30 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Fri, 16 Jun 2023 11:31:18 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: Michal Hocko Cc: minchan@kernel.org, senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 57F1C80005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cdk9b4h7nwb5wfa5h6uznawpsmuk88r1 X-HE-Tag: 1686886291-828993 X-HE-Meta: U2FsdGVkX18T2jdn3XeC13lNA5jkdB+cuhOjZxuhApIFN+1USx0lzQzZXBiyBJbfux3C5pkzc98A7yJzrZEhVX+QxhNkDlEfz09EgIKIWbyN+rpbk4/a3HgK9Xn9lio9/6Q9u36fBBammMl5TyM+hzbw5i3rzFsqm/Alp2YsVdEGza4gkwnvbhufyet4xmF8N4iDzMDgrEK4G/Akv++EtMmU1xxPZadZoaVWEUW2JT18dxAPwpG61jZw1XSnAMwOISu43OJ8ZuJpkW1ACyTZd6DIe0fZu2YP3Ipl4kFflBzUaFQDx8vow0zCi6oIeFTr1rH1ng04Yk6VYzslg/3ku4Et52GwLVKrjyPZzfUEJgj3K9i7NwLb7QzeV9IaedKC680k53p5+C+9SsdAOZ+KAJo1AWK1GwFX8eHO6vA0ocpDZ1QajlfegR8Z1s9TXXcPbLjY+t+ihBTOBJJbyIypYERJy0vvbYK12V42r/fGL2b6rewi2sOiG3XRXgs+R1AI3AI1keaVPRzirS5MIWZ3q7wT44xVx8lmVdkrk70UbFERPsOd+lt0VBushIXgFMDi8JsDlJ5MfHyR6dKSInV9GLXH9vUCJBYTYbkk+jvYaHXytDeBg3L6T/yrTmcmwZ/Uj1Zbv13jOIP/foKIIjhe8GLS9NnrD6VYIKgfl0TiaiUUkEx1ltLgWB9wsyKjPzZtFo1zsYWv3EfpobzaNEPDNlRK6i018cZAe7WIkEVJjgYFePB7cmHc3EZtmsKwE7MyJ0o8e5+BkKi3inBWByh8vHpj6qgHKyvcGyVgiIqouSlOIsT/0mvSk275eJrqfotKzLDz52EKn3kJWxPcer7grNFmwyb1wXx47O3Zor2LiQ3b0ewXRkkNglL9TIAl/gv/pH0utUaQHoLwzdOvclCbjdtTp1Y5A5zBhmXkRzByx8y4cUa6HzLzC8Dfajbz2utufajaxamU9H+LTGHPjcg 66R/kWIR +MGpZHqYWX1oElZiPe7bZZ0HQMRjm5gVI1BhHD8OftSOxLJ9DK+5oi21/QThyrhDZhVofViJvGAUvy9z2mfQyERzHRZstfMld3TMMm0oGjZRX1O+0dXWJXaGpPyuqfNpZekWjqJJ9/J8VRKwKvRZ2r0dBBr61QRnpY0fGMPZIonBZHGHRkyW04heZG07nTjGwRstM4na90JXD6/9j3IcQXzNqYMTgM2EONRrWxFCWckPr/DcWTy0i9v4+Sp7spzjlejSq6WDFrhVqxaa3WZG+2o1PQ+JuFBOx/qPYO3k1bHMeDdN5+SoRBnhteuTt+sQsIDfb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 15, 2023 at 10:21=E2=80=AFPM Michal Hocko wro= te: > > On Thu 15-06-23 22:13:09, =E8=B4=BA=E4=B8=AD=E5=9D=A4 wrote: > > > This is not really answering my question though. memcg under hard lim= it > > > is not really my concern. This is a simpler case. I am not saying it > > > doesn't need to get addresses but it is the memcg hard limited case t= hat > > > is much more interested. Because your charges are going to fail very > > > likely and that would mean that swapout would fail AFAIU. If my > > > understanding is wrong then it would really help to describe that cas= e > > > much more in the changelog. > > > > > > > OK, Got it. In many cases I have tested, it will not fail because we d= id > > not charge the page directly=EF=BC=8Cbut the objects(like slab,compres= sed page), > > for the zspage may be shared by any memcg. > > That sounds like a broken design to me. > -- > Michal Hocko > SUSE Labs I will try more cases in different compression ratios and make sure that swapout will not fail.