From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B129EB64D9 for ; Thu, 15 Jun 2023 13:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DC518E0001; Thu, 15 Jun 2023 09:09:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88C506B0074; Thu, 15 Jun 2023 09:09:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752CC8E0001; Thu, 15 Jun 2023 09:09:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 693546B0072 for ; Thu, 15 Jun 2023 09:09:32 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 27E551A08D3 for ; Thu, 15 Jun 2023 13:09:32 +0000 (UTC) X-FDA: 80905013784.20.2BEC145 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf11.hostedemail.com (Postfix) with ESMTP id 5EC5F4001E for ; Thu, 15 Jun 2023 13:09:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VZ08EIE8; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686834570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sUROAgBeshgdiJp+vkELQl3KTeabw54ZXtzj3ZlDMXg=; b=n+fOhIzVmoMqZ5eGieLOuMl5lQYxSbcq83F7we5TkIGOpNZe8uGTMHI59SGBNhwZUvsOzl 0QAhzLo6/oQoGMyyAUuv9B0ECWeYLLgzzwKi7K2rDZkuZuNPzlx1D4rm4qp/DPt0hlmBjG aorgucb4tLQzpjbeTYxMdA8AF60KwJA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VZ08EIE8; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686834570; a=rsa-sha256; cv=none; b=B3ghAHhQq6NaQP3c6C3bFDKeRYQnFbc2zpM9aLJh8ni2YDQW8yQszN/YJB7wm9J0yEdYHO 7ir7caOM83L6rpkMgovJU4Ge3K/CyB+2C7+77i/vVEmT990JfNFqNLcalCu+WI1L7dJ8qG 4MlGVHr4qOb1ME+y9BXWb+466Adm1r8= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-544c0d768b9so5516558a12.0 for ; Thu, 15 Jun 2023 06:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686834568; x=1689426568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sUROAgBeshgdiJp+vkELQl3KTeabw54ZXtzj3ZlDMXg=; b=VZ08EIE86uf0kQRin3iWcQI+HTTNpM4k5NORwuVSzor+ywrVzokQPvuN90/58JG3Ky zulxC+X76nd8eOJva50s8HlOuZwlnEnp6OKIVB4woFzYJD5L39NOqAwclB/ISYfEQkk4 sK3Jp4npS99v9RsupdjO1rc9e5O7R/iwCcVq3uBNSpSga6gLNWEYdxazSZ+ptQ8kNju0 tkctVcbhN9mlpGzxfHXihAojmuujo/WVGEFOwhaIJne/m7H/jMA9oC7EcX+DUtBr0zVl tUDxMdh7YIN1/FTW3fP4M7jyGz9BBSwPsWT1SxI1rtkRGeIAl7R2sayoNZHQCkYX49u2 tqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686834568; x=1689426568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sUROAgBeshgdiJp+vkELQl3KTeabw54ZXtzj3ZlDMXg=; b=kIiIig5MLjZdH8aVOSQvEvR2Z8OckSt9yPcUvkgKRz6eNvtpDbzrRZHaQZTcwUq3kd b+v627MeFUpZkvCJxD6ypIc9+5DdD1ljZmzoapG0r0QuLc+bharTkXwmebuzhchpWrg8 A0a9YF9Ev0LP03xil6ApJMlD08RT+h8m5Ny7EnBE8GFidFVZeFBjy+2/3P6STBZJBHaU s3cwSE+XZMEH7JRpVW0s9JtjhI8uf1QBxKSq1WK8qBESDci5qqdM4dZjUGBYgT0gRpE/ 3Ah5gHLOZ0UeSBO+77A1bPscaSjzJIuab0Tyw3IPlg7Pn1im4Gk2aMAqptYyQVxqeVAD 83uw== X-Gm-Message-State: AC+VfDzVmOhj4SBL+Ut2SLX+Mo9Z+1Uvwri0MGXH7p2c2kZ3jtgOfKtJ r5sh5U9WRsXXKhascOtPQRJnYEST2PCEINBrFbbkqQ== X-Google-Smtp-Source: ACHHUZ5C6FhXdMxKSPBM4310iZdAeCeYilPOa98ys57+ZB94IVGz2Owi5H5jWX7YlPLVXK2MyQhueEi1OB+gKFLDV8w= X-Received: by 2002:a17:90a:c7c4:b0:25b:e4ac:98ac with SMTP id gf4-20020a17090ac7c400b0025be4ac98acmr4246384pjb.17.1686834567869; Thu, 15 Jun 2023 06:09:27 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Thu, 15 Jun 2023 21:09:16 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: Michal Hocko Cc: minchan@kernel.org, senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5EC5F4001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w4g45yo7yd986a8rn6ys9bg1ih3ddhz9 X-HE-Tag: 1686834569-422229 X-HE-Meta: U2FsdGVkX1+HmDAV0EEQqhdLiDjcvF2jinQu23sm5GoC4+uH7ZeVVoSliO/mmcCDUkyllG9uuJDykLZWb95ogcvn90tzgBTWk4mHF6+scE1KA55VTNl9543Rf2trrFvbJd4WruAm+4njelfOnEN9ACMQTjFzKTmknidZbRbhrdPy9T2JtxvuP/ArT7HeODct397GekFU5ZkCpCvV+WG4TDyzkQyNoHjMtBAVAG24LEnS29Xk1qe2YOP4qRZ94rEiZAugasww8J272iMtwF97WdYmH3PGl30z3GdLFWpV8Zbz1asRtndCtnlr6V02EmxFGn/+EoQr7ZJSQgFI4YssLSlC0w5iXaXZsGtKtKK/KsEYViviHwVYPVB+Wr5aT22Z59OVlvw+VF0oK8sGsvzb35XWI78TAhEyqVeTkIoutxzdPwjhypjdHxxB63EF7bAlZyMj8S/H35teEpE/Sn+5Rw3KNmvns8kQ4jyQvl9INscHSNgtRH+zJB2BCz0oEz32gZJD3iByOkLVfYjmQDFc+GVpCsFM56uZH5ybLTpLVO9fA35W1N2bAn3B5s7HbMHQiym02k/MyPcFkHM3ESPrqdG2crpuMwWqPmDm/tsxlzFJhSn4leJnsq36W07XbOZ38N52Phd1LY1WE+0RUkStzvPyrBqnDIatwluCrUDYviGTdWzNaIYT7cgGOfw0L8xNQIddOhMMyKOWwe1AlDe+LGbDeDwz7/8KtxAOJkVdOU6yK/pa6blg5qSLWwINPW0wDm4yga1COBKdZF2z1frxlaC6UBITwvfXk07YosiKaFdTYZmK8dLy4ei1dFREtStr13lDppXswkFkc9s1rBeu1jeq6YxeBPTTb0bAyxYsEMrA3bFDgimXwBMr0n4edlTvj2MP+k2RY2uHhzpWOvN/DsAXTaxzzOXLfkibMrtSKsN5sClkGueHrLtBAwmo1T+OYfV94E0waMdkzQSXMpL fIELBRtq CsxMhCU6Q7w7/Jl9BVoG+WB/LS0Ix773mdLEu+l/spp4xFh9aks/227+G3kg171J4bGpQC7xOQ/+fxdpbSoKYDePVtbcYqYmzGkiW5j7CdOcWBkqREYk5jC0airL0KUe/Uq4QGjheQsGpJjqnUOgBGYz33ZDk3M//bGbnhZtp8ss8Hop6y5nZUJpt+GCGNXo9S/1H0lWSWz3+3w2LCrruPhq665V2lK5M7IarUO7ZPi82RcvrVXIyZ74U0ToVw0IQoPsWV7DoUqPDcNo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000081, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Let me check I understand. This patch on its own doesn't really do > anything. You need the zs_malloc support implemented in patch 3 for this > to have any effect. Even with that in place the zs_malloc doesn't follow > the __GFP_ACCOUNT scheme we use for allocation tracking. Correct? > Yes=EF=BC=8C I will use it on next version. > I do not think this is answering my question. Or maybe I just > misunderstand. Let me try again. Say you have a memcg under hard limit > pressure so any further charge is going to fail. How can you reasonably > implement zram back swapout if the memory is charged? > Sorry, let me try to explain again. I have a memcg under hard limit pressur= e. Any further charge will try to free memory and swapout to zram back which is compressed and stored data in memory.so any further charge is not going to fail. The charged memory is swapout to compressed memory step by step, but the compressed memory is not charged to the original memcgroup. So, Actual memory usage is already greater than the hard limit in some case= s. This pachset will charge the compressed memory to the original memcg, limited by memory.max > -- > Michal Hocko > SUSE Labs