From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6BDC28B28 for ; Thu, 13 Mar 2025 02:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08A62280002; Wed, 12 Mar 2025 22:29:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 013D8280001; Wed, 12 Mar 2025 22:29:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFE0280002; Wed, 12 Mar 2025 22:29:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BB0C1280001 for ; Wed, 12 Mar 2025 22:29:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F08FD12192E for ; Thu, 13 Mar 2025 02:29:59 +0000 (UTC) X-FDA: 83214947718.23.5967706 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf14.hostedemail.com (Postfix) with ESMTP id CF1CB100004 for ; Thu, 13 Mar 2025 02:29:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BtK8+XTi; spf=pass (imf14.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741832997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qmeGXx2A1NAbuljKwpxBnF8ga8bqqzllLRpOlTd+ZSw=; b=JgO5TH36YWJ4r8Dwu8tLLYf6u0BKAwapktXNpDO9T9uo30uD3MGsJZELGZsHB9/hC/KWsS UaHup1+YhO93waJNoOyp7bane5erLXocbe7nMyhznTgwcal5TPrqXxDdVdN2CYnABk2A4H dJnicxoOzghO6+7zsEySmLfnjLs/EDA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BtK8+XTi; spf=pass (imf14.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741832997; a=rsa-sha256; cv=none; b=aGPwaT4wvMCfOnYoYTrlWDP2718jaGgKVXbGx6ibWGnMCdLlAqsvWddziQItDXC3Y3N6zC nRaPfLzDlgQGQ4xcYIZqkcKm1PC+gm21hkY9Tb2EEwMKwTXGrEY3XNZThWK+Z3CeQCv8eF 3fQYNqgSR1Dd1le1jadeB+NmAp704PA= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-549b12ad16eso530028e87.0 for ; Wed, 12 Mar 2025 19:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1741832995; x=1742437795; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qmeGXx2A1NAbuljKwpxBnF8ga8bqqzllLRpOlTd+ZSw=; b=BtK8+XTik91qX43diUW/HDoOTd9k4P5T/lhkJPuyHJynyY0asrJaRUS+a0cbkLja/g 8M7h6G6Xf9LwOrrGWxD4CAJ5ctrkSgrj+3zs3lOH/qy00+RiHjnkJrIATn+O2YF4EQkv HXtRel+DenkNSUapzX7WDCfTlXlxp8CEmUbsgmXw586NErHqLbIMLxogTHvPOJiD7bbC K9rt2svZ3Hqsgw3mTNZWPzOro1VWqF2Xe2SEmonG/Dt+9MjdW+/e261xnxUglzyk9RwU WRFUZHFyLz7m06+lW9Mgao+4Z5V4x+e283cHImqciMb7wSENUsDgOOXmkQ0VxFrboTKT R91Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832995; x=1742437795; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qmeGXx2A1NAbuljKwpxBnF8ga8bqqzllLRpOlTd+ZSw=; b=p5NvnwWsdILQ5B2QlakN5F1KFgrPwdPW0XvqspKrUM8G4lkai+KZQDxAwYmJV5wann Z7hvrnwooTwhAd2nfEURoLkEqSfO+HLUPmCl1zeonl42x8a1BQhfojzI+6hzWUU8ZTLz 8QOJAN+lIVQW9pIO0JCc15FFmzdlKHXQLK8G0+2HAG19WdMToCHuSaVx2h+ChxfCBcHD n9bFCCzWYnR3sCvSvMFj5yq+RC75VtKjsBYYzRWN+J5nw5Z+3dTgry8+jGtFdAbglurM h3CTJdBBrdI6Ltrn6egvT69igvqEuYivnRB3bcLvdeol8JpCpnC5B2J3tT603lr4eToN Ir+w== X-Forwarded-Encrypted: i=1; AJvYcCX1BnhyGZQGofg33vXuEfjFGD3mugS5VbRIdT/S615/090Hebeg8rQaq8HbcVLm5O2ok11y7ApZqg==@kvack.org X-Gm-Message-State: AOJu0YzSSB9vUwy6WR5xBJ/u8uU3REd4eHwid1+pjHFgwvU1AiSbZOOw 6cjIVOAVXTnQDkkUIJH5mBaUx6hctZA/qwr/+1IRhMeSqP7bhyJEm2OFkDV/T3V3s1Zou1ExmwH vhV9kaVrhHyFtjH5L/eILgUyUlwkboGNFY4Mbyw== X-Gm-Gg: ASbGncvgdbRkO4PRKVBVPdB6SmfYdZFmk66ZMzsj9J5dTp5RsIk+LkrlmRAQQh7cy0U No/xLCHRYfOxpIqvrYaFSiBNU4N6+y9ryoclj1l47SBUDz2046ZVBFJr0N2Tk50vPly7WuCrkZR G1ze69SO3wd1DUTrXWt4v0ApiziaEUr1yGsa0G/EI= X-Google-Smtp-Source: AGHT+IEYUXGUA3sRaQka4rGnypq762oPO2t+iGxw34uT2EYx5soBJ/th0pt98TvntWgNemnIDsXkqAPQgBMFBqc70Tw= X-Received: by 2002:a05:6512:118a:b0:549:43f8:824 with SMTP id 2adb3069b0e04-54990e6737amr7225418e87.26.1741832994619; Wed, 12 Mar 2025 19:29:54 -0700 (PDT) MIME-Version: 1.0 References: <20250312094337.2296278-1-hezhongkun.hzk@bytedance.com> <20250312153618.e24f399d2d9767ebef87519f@linux-foundation.org> In-Reply-To: <20250312153618.e24f399d2d9767ebef87519f@linux-foundation.org> From: Zhongkun He Date: Thu, 13 Mar 2025 10:29:42 +0800 X-Gm-Features: AQ5f1JoUFfEcEatvUScsF6XsU-mtQkFAWzpm1bhdyrvTSYorPI6yVK17DfDQmcY Message-ID: Subject: Re: [External] Re: [PATCH] mm: vmscan: skip the file folios in proactive reclaim if swappiness is MAX To: Andrew Morton Cc: mhocko@suse.com, hannes@cmpxchg.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 95bt6tyoda4tw5mixy4bt7kbe1qha3wb X-Rspamd-Queue-Id: CF1CB100004 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741832996-253059 X-HE-Meta: U2FsdGVkX1/HcI8sV2VV5FFp0oNXXwBgiNOk9mcQyfu27Yi2v2U9+o/inEvlvTEXPR2vEBpVB78oF45/pbIXJ8maU1oPkPz4ZFUgJHA2k9YSVvxJD7VQrx3l8KjtY57bZZ7O9IwYAZf7GE9lP9vixgPyxRZOrJIyOq6A4KOIHEGN3gus3/VSKlvsSph72a34o7uJ5zbkGhGTztW4dsIQ2QzI9v887U9m2WEDjcrsDfmD6NFaaKIoPr/2bywJN8t0E7otSdX0y9l63hUWt5UOK7rG+A30Dpbv3aYAEDUEhWCZMFZanZJOhOwuxT/BTSrjiuPB0VOiwmB1ZtWyteOVXAGHOFufZ2AbtO4kX1njmyGYvPlJQHD3VD3njUjJasFGcs/u6I7+qmNcVMek8mZwzdwKpcGoQN7zqIKU5J1xxOxim++hkBXtkr8i5KpSU6BJATGVKvSBLbfP8p8C16/7sb/Eefa2nvD5A+JiTrsADZYlnK7Fyf5Z0oTPTD7q9LG/uAjVQAZo5TNT2AePCntWfKXqNMSAfDAuMedSLjvuRub+Vs05+0054nkg3wPRTDFKl7zuZhdDGhLX5A4LLU9IoycjZM+MoGgPPx2s0jQn8Huylx0yKP+euiSwYkf4gmnz8hznQXRNegmPkYlc22xLtIXIwnSYTsoNJhExBJPstpHp9T+H0uTPRA7ftDRlxHLkAOMl5off8Wt3im6P6OAEXGS7IbzaGDJWbpoL7zXZJ+tYpL3SiKSzI1Iw/7mNf46NVDasC1XQdAl4mKNHriHCf5tsEKUKs7Oip+HQF1qawwjql6m7vYzoX/sljENhnB8s3ZlY9xVthl0DB58SqwQeKdGTt9rGaXfqK/5ArK71EFXLaTqP0kvsTTPYy3EWiCNHGmA375SyfKDcCBZtIu0+nxjL3AU9amQfvfPASnPxV2qgfrzSv2j0aGqNUon31ERRBtCMpA7HvcGOM91M3P0 CC17WaAc UMeNEvyqXfyOL2xDPQSe/AvF4cAoztnQolfyxmtAIrVDHUDMDByi0A87kla47BcMrh9uaI1Dy7ooEPB8KkXo+Pm9NrnbjJ1g7DDop1KkXmCTb6mCUYcbe82AdogGLW/VE22QFiZZapUBVx9lZzJUDPlUt+NHOKNe9e/YerEQWV0JQ7LFpQEjHfXh1xv/HmNpgqeNIleOl08vv9RP6LFuTH81WMctOffvagYYZ/mhPp1oTLQwM18Kg0SzUMirVbA5RPTv0sT95U8nLkJGY1qiuV3sDAP1FHoUah28I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 6:36=E2=80=AFAM Andrew Morton wrote: > > On Wed, 12 Mar 2025 17:43:37 +0800 Zhongkun He wrote: > > > With this patch 'commit <68cd9050d871> ("mm: add swappiness=3D arg to > > memory.reclaim")', we can submit an additional swappiness=3D argum= ent > > to memory.reclaim. It is very useful because we can dynamically adjust > > the reclamation ratio based on the anonymous folios and file folios of > > each cgroup. For example,when swappiness is set to 0, we only reclaim > > from file pages. > > > > However,we have also encountered a new issue: when swappiness is set to > > the MAX_SWAPPINESS, it may still only reclaim file folios. This is due > > to the knob of cache_trim_mode, which depends solely on the ratio of > > inactive folios, regardless of whether there are a large number of cold > > folios in anonymous folio list. > > > > So, we hope to add a new control logic where proactive memory reclaim o= nly > > reclaims from anonymous folios when swappiness is set to MAX_SWAPPINESS= . > > For example, something like this: > > > > echo "2M swappiness=3D200" > /sys/fs/cgroup/memory.reclaim > > > > will perform reclaim on the rootcg with a swappiness setting of 200 (ma= x > > swappiness) regardless of the file folios. Users have a more comprehens= ive > > view of the application's memory distribution because there are many > > metrics available. > > > > With this patch, the swappiness argument of memory.reclaim has a more > > precise semantics: 0 means reclaiming only from file pages, while 200 > > means reclaiming just from anonymous pages. > > Please update Documentation/admin-guide/cgroup-v2.rst for this. OK, thanks. I will add it in the next version.