From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197D5EB64DA for ; Thu, 15 Jun 2023 13:41:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4630C8E0001; Thu, 15 Jun 2023 09:41:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 414406B0074; Thu, 15 Jun 2023 09:41:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DACD8E0001; Thu, 15 Jun 2023 09:41:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1990B6B0072 for ; Thu, 15 Jun 2023 09:41:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AD21AB022B for ; Thu, 15 Jun 2023 13:41:01 +0000 (UTC) X-FDA: 80905093122.13.FBEC461 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by imf11.hostedemail.com (Postfix) with ESMTP id A2C5240008 for ; Thu, 15 Jun 2023 13:40:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=G4hXBT6P; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.160.42 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686836459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RGiRhDtKXKdPnyQZXUiGE0ms6YPJSlCDLGcXV/MnxP0=; b=RaoxDSwTc8zOApC9cMIRd8IdXRrVJFutoybnL+1fDXVt6Svrr8jpp5XubPcAYYPYYB6x0z ikEc4EztUiYJxB0dcvPjfbwoGB0bK6dI9spPvNogUI8MPFBDUvZS8y4dMDmoO0oGwxq6nL CjhyOjTOSvlKLnvwWO83TvJNIjD55bw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686836459; a=rsa-sha256; cv=none; b=8N1+tdfMeQ7hxgqchLy5Ja7/BTXNJJ4jSdQTk9PW4cxxg1/4YyhhRcPRb/lXBluUS37H7D QXUBDP2SFeiyJIX6jfw2MG+FnrkJpIuJDCo9lk3g5ZCVKWbO35W1Lxv0K97aTGk+pFiYNC MfuEafZxddZeBBoQeM1GZEAuSjt4eUQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=G4hXBT6P; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.160.42 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-1a49716e9c5so5731922fac.1 for ; Thu, 15 Jun 2023 06:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686836457; x=1689428457; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RGiRhDtKXKdPnyQZXUiGE0ms6YPJSlCDLGcXV/MnxP0=; b=G4hXBT6PybkC8KH4jDO+6jRK9k12fnRxCoaWSRP2wr+gO1sKPWpEMyOL87J/po3GLL KHckQV+ZPZ8XXKPaxxy7BnkWmNwSF/k3ON8UBg/HeFtEOGy5uSnEy3ra3izcRgbXokXp HJzo4pzIOJAdB0eSM8WxGgXk7Sofu06gGpFRFzr0QKqAs/cYDopNhL/yGGO10A/wJLmm BdN1H1shXDMf35pIgpkv0vDspO3LSmUlE3Rv5xpyOiZuvQoaH5STIA/lKVHcgRbKPxVS kpwZcztOeLCajx8hdzuMmWm/Wv+JCgJMLoXMgGAipJ+8P256gry4ceC9A5KEvI1Qim0g GdWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686836457; x=1689428457; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RGiRhDtKXKdPnyQZXUiGE0ms6YPJSlCDLGcXV/MnxP0=; b=iOvzd+jOcSEMmICRqkk9VWFKDd5zNmp59cbwnpQ7dgrzFwTRJpf1EhUn7httzA76mO K/73tYu27Yh9l19CD04YQzT0xaP9bdV/EyDlWnbMimIWmt9QyGxuQ4CqosI30TemQ8qc 3OFJcUynMU+b2CkZSRPafrFNfwPUpl8zGu18pqGTT9+qonHinstI3LVzuibAri/EUktk nWGttffL+g2W4ojRKsF9qCZhENo2MN0pv0XpXtVGFZyzZW4Wggj+EkCzUJs/S9HEF9P9 L+3yig4bPDOgPcoIa8pmPWtsQhTepR7+/OJeh6sEm9a2MNIJzo9oSEYB2yMdijVfzT9H DE7Q== X-Gm-Message-State: AC+VfDzUzc3EFI1eqbPNq12xf7/MSSjQgPbzhdZWJhdLOxyhAoHSYyXm 8I/xbAx8rGrDwMfVFbm4U91eftKySB46h9FXlrV2Gg== X-Google-Smtp-Source: ACHHUZ6XCgEjbimdsWu4x2GNy+nm0L5U2fMv9VbzlJkrjSGth16K34QWIgjt8FDBjyfwI7uf2iQOX1EwMlNCSc7ezUU= X-Received: by 2002:a05:6870:87c3:b0:19e:c567:6020 with SMTP id s3-20020a05687087c300b0019ec5676020mr13345394oam.38.1686836457449; Thu, 15 Jun 2023 06:40:57 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> <3f54542e-235b-8456-f13f-786d21c6c14f@redhat.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Thu, 15 Jun 2023 21:40:45 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: David Hildenbrand Cc: minchan@kernel.org, senozhatsky@chromium.org, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A2C5240008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: f8yszuumep36dkigqe9ret6ewsocx9j1 X-HE-Tag: 1686836458-222815 X-HE-Meta: U2FsdGVkX1/5fzX7alejmPglx9NE6d2J02onXVqIHT7Bo3/JF7hj+b9QCsh1APGlopHAi7n3uyuUai0vnFAlFvZODv0ODjr/UeVEPqXFELJVthmXJrc/ELmNCZhFJEJ3KcRu30lOlXUryuI+y23W5CogbriHL2lwsQLw35y4RlhDwxdoylYLFfur2DFH8BCr3K+UWvGtXQJEYK2bm0iLPtKDlLKbbCYNmIwK2DDp9GeJjp5BE4UPc+a7e6sXuwjrYOyOU501O7KLkCeRaguHnLhMZ3GNtHwq5PzD8UpCSnxAUwzqzLKxyEaZD3oiBB8xvfi9ryiq1PMGHigAd+2+0Xm1QxYGLVFjpTZQHj+cKA4Zdu7jGkcWpoyniKMOBBV1u4a3L7RA+1pvuCk8cZG9nYZ0NEx0yoe7/Vhn/ZYtuAmO6NLFZm9XXvHxW5tFsmg9EBs/86DZ1c26rz0MTGIHcs6fI3OyDUri/Km3qThm1DCjypoX0q+pjNzDDyH/sAfyjtXDhErI5LAy11eAyXmJKPM9LI8nNFWWJq+a6MKMjInPFj43OcySa+qusK/QXZVJIdkA+1zxQRzV+A/F9hX1VXejaiz57jYTyJYGOpKAyDb8vHjhMW3otjqFHJfzDYRuQB28LBMp8B73NMIhiQvoeMBHkPwBGI96pLCey2+Cz1YkpUjFbmRhMB0T1jViw4xBdyGUlW4O1mWFrFFOsx8Z+txknebDmQ5EH374WPFKBwYCg7WsAwrWtOHCySDKrLizM053PyDjhhlwPwLt5VpIzKzjkWWXfgSN9Mt+lLW3U1uDzXeqT7ZBv+iHWhYW4l+vNWp6XAlX5w3M+0tBbLBoiS9exfKD4m/EXVqmJlCDCcS+3FdFZj33HfJIaywv6/E6ezCoo6ieZyphptf3t0s/nXoQAUxcSPm7FH/bJ26z0W9VxzDycuoLDCbUPRBsByrl3+7RJfEv4226jWye6Ml rwqf92te PLPpQj4/baLgWQ8hqjC9C+flPeRcH0SX/TPGNYW8XFigDKKMe4FkaW5Ao2Tb9504MzV2WCkMtXJFtyZJdp7r1GdWrJRtGnzA9I9W+JtTEgBfBwcBfXSvEXBhKRn4bwZlrtJLkNciD44/QEkfksrELWwKF5Rfjy/0fdQWalqHRlFrWZ2yqLWuayat6Qyv3wjd1fQsvIh2YuJqRxKaoSXCZbQbW/k5G/IhXyFX6FUsBvbJUbaUJYchxcF4QyJufjIrPfgaF7EKvZnd7K86a6B8yPctuvdGzQYbd9XM4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > I suspect for the swap->zram we should always get charged pages, because > we're effectively writing out charged anon/shmem pages only -- without > any buffer in between. Hi David=EF=BC=8Cthe charged memory will be released in swap->zram. New pag= es are allocated by alloc_zspage(), and we did not charge the page directly=EF= =BC=8Cbut the objects(like slab), because the zspage are shared by any memcg. > > For the fs->zram or direct zram access device case I'm not so sure. It > highly depends on what gets mapped into the bio (e.g., a kernel buffer, > zeropage, ...). If it's a pagecache page, that should be charged and > we're good. No so sure about fs metadata or some other fs cases (e.g., > write() to a file that bypass the pagecache). > Yes=EF=BC=8C the pagecaches are charged in fs->zram, but will be released = if we drop the cache. the compressed objects are not charged. > -- > Cheers, > > David / dhildenb >