From: 贺中坤 <hezhongkun.hzk@bytedance.com>
To: David Hildenbrand <david@redhat.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, mhocko@suse.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup
Date: Thu, 15 Jun 2023 21:40:45 +0800 [thread overview]
Message-ID: <CACSyD1NfbD_YBADH-3bR0=sGkrkEqxfgYLvyNyTiWdTvw2R6vA@mail.gmail.com> (raw)
In-Reply-To: <bd119703-7b7b-c4ab-0c38-9b85809de252@redhat.com>
> I suspect for the swap->zram we should always get charged pages, because
> we're effectively writing out charged anon/shmem pages only -- without
> any buffer in between.
Hi David，the charged memory will be released in swap->zram. New pages
are allocated by alloc_zspage(), and we did not charge the page directly，but
the objects(like slab), because the zspage are shared by any memcg.
>
> For the fs->zram or direct zram access device case I'm not so sure. It
> highly depends on what gets mapped into the bio (e.g., a kernel buffer,
> zeropage, ...). If it's a pagecache page, that should be charged and
> we're good. No so sure about fs metadata or some other fs cases (e.g.,
> write() to a file that bypass the pagecache).
>
Yes， the pagecaches are charged in fs->zram, but will be released if
we drop the cache. the compressed objects are not charged.
> --
> Cheers,
>
> David / dhildenb
>
next prev parent reply other threads:[~2023-06-15 13:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 3:48 Zhongkun He
2023-06-15 4:59 ` Yu Zhao
2023-06-15 8:57 ` Fabian Deutsch
2023-06-15 10:00 ` [External] " 贺中坤
2023-06-15 12:14 ` Fabian Deutsch
2023-06-16 1:39 ` Yosry Ahmed
2023-06-16 4:40 ` [External] " 贺中坤
2023-06-16 7:37 ` Yosry Ahmed
2023-06-16 7:57 ` David Hildenbrand
2023-06-16 8:04 ` Yosry Ahmed
2023-06-16 8:37 ` David Hildenbrand
2023-06-16 8:39 ` Yosry Ahmed
2023-06-15 9:32 ` Fabian Deutsch
2023-06-15 9:41 ` [External] " 贺中坤
2023-06-15 9:27 ` David Hildenbrand
2023-06-15 11:15 ` [External] " 贺中坤
2023-06-15 11:19 ` David Hildenbrand
2023-06-15 12:19 ` 贺中坤
2023-06-15 12:56 ` David Hildenbrand
2023-06-15 13:40 ` 贺中坤 [this message]
2023-06-15 14:46 ` David Hildenbrand
2023-06-16 3:44 ` 贺中坤
2023-06-15 9:35 ` Michal Hocko
2023-06-15 11:58 ` [External] " 贺中坤
2023-06-15 12:16 ` Michal Hocko
2023-06-15 13:09 ` 贺中坤
2023-06-15 13:27 ` Michal Hocko
2023-06-15 14:13 ` 贺中坤
2023-06-15 14:20 ` Michal Hocko
2023-06-16 3:31 ` 贺中坤
2023-06-16 6:40 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACSyD1NfbD_YBADH-3bR0=sGkrkEqxfgYLvyNyTiWdTvw2R6vA@mail.gmail.com' \
--to=hezhongkun.hzk@bytedance.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox