From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6767C072A2 for ; Thu, 16 Nov 2023 03:33:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A2CD6B0375; Wed, 15 Nov 2023 22:33:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0527C6B037A; Wed, 15 Nov 2023 22:33:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAA556B0389; Wed, 15 Nov 2023 22:33:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC7DE6B0375 for ; Wed, 15 Nov 2023 22:33:20 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 91B2E40B89 for ; Thu, 16 Nov 2023 03:33:20 +0000 (UTC) X-FDA: 81462396960.24.4551843 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf06.hostedemail.com (Postfix) with ESMTP id A781D180004 for ; Thu, 16 Nov 2023 03:33:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LgSYs7zP; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700105598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UpqwIukJN4pe5ng/7gTK1zs3f2lJ5+Nh8U6l7DMo/Ls=; b=48/6AnAV+6I7Vll93BlIqwhtpBBJJ8nblv1/IhW4B5p8dalHb/262M3R8hi0iatmDZttcS kRfIShVuHO0XEFguOF8jJpw4qgMk/RPQu2k8iR566dccVbl5RIE4avVMDZpvqU4A4axIf8 WAUfVsY7S8UNpAC+qTnIR7QbQkFPlFg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LgSYs7zP; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700105598; a=rsa-sha256; cv=none; b=M+2EPOg2yG8HkEalBZZBn2i4txM4tUWULVMifm6oaaOX7herKMCcZH/b7JOYeXeByOAHm3 VpgUnSO45FQ4eE2GmwFpKTXD+mQJ8xYWXauf2yv4amhOQO9YtuylpPHNGIVcevSm4XoTXi nyv5ZU4rRfamLGV5TODZDcR/jewPxvs= Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c595f5dc84so16571171fa.0 for ; Wed, 15 Nov 2023 19:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1700105595; x=1700710395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UpqwIukJN4pe5ng/7gTK1zs3f2lJ5+Nh8U6l7DMo/Ls=; b=LgSYs7zPrjEDeGgDH9c2lw3z3J/b52QIfBjvONk5dcod3phiqEQVA4lWwbwYXhNbLr hba9dS7FQaKD8j++2VWbwcDq0aHbXGRR02PHkxv2anZZiV4kpKQygtpCSdqcCsgPC+LV 3ymTjCN0GwkFjZL7+vWMShrTBy6kDJOEVDQer1qB+O82mC05giYY6ZgGkS74GYA53OIe 1se3xTlwp9RD6ruM2FceXf2nyj3k/Fcc1SkJSa4Tg2nJlkV2vhvCARBOJKL8cxll16+g +AN+ItBZGPMaER7oz/3wL5A6gZHcKW/qWAWCym/iOZVwgvCOYmiCRkC9+Z13+W733XWS SiRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700105595; x=1700710395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UpqwIukJN4pe5ng/7gTK1zs3f2lJ5+Nh8U6l7DMo/Ls=; b=X42JEyPES+4hPpt45WQ0X/JH7rT4eDNaCOnC+Hu6SBHntB1GL1iEcY7sn1eB+dnyQ8 7NraRBZbjsmnIPx6glhEnT6ZfEWcNMI0ELxk9/qah/2SHKRo7yzGLgcgYmHJpgY94YuF 6OWe7L92qQwbP/TbP6MILiz+dHRZp3Ork+janLRaGkw8VFbOWjT0t3yGpFpL48oAzzh9 hWRDKZfxW7LWyBvYSiAJiLP2AvBE80ruQic8PksiInR5CHB2SPz+FW+EjxmS0LujZPW2 oE1hZgFehkbFJMX1zdOc1ZZOQU3v70XsyHO+rC0GCIxVBL/VZa+CCBDSMjuP4gSezneh LLfA== X-Gm-Message-State: AOJu0YziwASpLbs6idPy78A/bz/Ab4yT3MOVFJcwQoUf4KS0MU0oVZNY 5+Huz8XtQjUqbfOla3dXRFOUzGEz7v9YIrgo3IQjFw== X-Google-Smtp-Source: AGHT+IGbUOhz2+BNaQkvb9Z18TKRjDf/Bxz4dE2NrTeLNsgDDqA6PVyBftHctxYwLqfPsb6qJXCg7uNMng1BpgSymkg= X-Received: by 2002:a05:6512:b0f:b0:506:8b41:7e31 with SMTP id w15-20020a0565120b0f00b005068b417e31mr193547lfu.6.1700105595568; Wed, 15 Nov 2023 19:33:15 -0800 (PST) MIME-Version: 1.0 References: <20231113130601.3350915-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Thu, 16 Nov 2023 11:33:03 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ying Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A781D180004 X-Stat-Signature: dssh81a3bensixry5juqfeeic84frhyx X-Rspam-User: X-HE-Tag: 1700105597-911675 X-HE-Meta: U2FsdGVkX18/BjHB/S43Qrfyz8cLYXluKGuHU8I4ng2XQJvlAkhs4vtcNSB2cCUqHoFVGytQidOl6f5qm/GU/i9Uy2PQVzXnhU3t01P6iXJvkSVg8Kb4Dd7Tkp1HCK6sk4twy3TBc8o8wlzVC1xkQHvkmulfZ8yATTuVGhlbOS+dEn7mOab5zsfQ1OhqYudo1S2TzMNK0EwwqOUjiVOEXfIt5+6oKWVo//Tg/9Ha7eDs+FEXTcQjzXh2SDY+NbB3lbOkFVUBiP/jLQActAhx5r3iWkbrAglGZ9Wrtdqu5O3/022N2O2SC1vRRM5Z9mO8Kokr1PqiFtAjVaQl6yJCxodgIlDEfuGMb4vCsQZcbb0TC8GZVWBDtQe90fPV8atFea3rL7yU0bsR6H+HTNG0fTNdwG7n2JZ9NR3QrTCsOQq41+rNoKiQ5ckl+aQQRf1PjDYzIvGAx+MhTY1X9zoklzf6wURDMLyJCahFZfsbUiXvMqtfkC2kCnItHcwLKNdsrO3W9cYOBPk5naLUO7M9ydiXHmC92zT9ysvM4XOrbFkzHOQfUVrzyXhVq7cBckoN+GsHrRtAwYXh/K9M9lLS3Os2DHkndJ5HE+GS5u76NqNPlAILDmBHhY8QES88wqF5NvvNzGoeZDN7iOfLKzTYLuTUQzVYswQkAnDdOjxzFFm/RV83ljGdpkj3qaXNMMnVEp4eGRJaFKQDOdOvoGLNgGczu24GwVyLQv82dlI/nBMJOmxIF2Tk8dbbTQWMJaGdJYixhhhpt/K0mvfwsE32ghVBXO+nSIBHy+XtSZ+zqBA9vlOTsSf6XvxjGcz5/tMcFQ6b5b8LZcoEx/wWsVsKwgnRDkixnItjzrRFbpZin/8FrNTU+IZoLeVvTij47Ogt43qyWa4NFuHYYngEjmUoyTHxs8v4map0+NArtYzBefGYIVaGnn2BK7zi2xwO0UZzGQ8IJEto7xkr8sdWJqI EvsL4GQf jg8Yxv42A4S53mD9APFEO9gyQyqBqgXO8015tGnf0Zmatz/zoHCcEGEGGi4SsOv77EVhfBwrNo22yLBqwT6nHc/Szi/i2lMUJqwIeFN6CqmQaGUgF9lY8VjvltkvYAyNE76IHyZfRIazucTN0gmNgg/2MAOiZIcFAgbZNaJ4JVSUNzbC5R5DaWYpeGueXpav/Z0+9gqQobylCCmqxfJsCLhwfdAKn3f5Ma/8tzljz+pHFL68EubwWo2wudBB4hBaCq7GDIZME+LAS+vyJPFE07qWNVyPIRzvMqESx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 4:13=E2=80=AFAM Yosry Ahmed = wrote: > > I think we may need to try to lock the folio. Otherwise we may race > with reclaim reading the dirty bit before we set it. > > Taking a step back, this seems like we are going behind exclusive > loads. We "should" keep the page in zswap as exclusive loads are > disabled and the page is not yet invalidated from zswap (the swap > entry is still in use). What you are trying to do here is sneakily > drop the page from zswap as if we wrote it back, but we didn't. If we want to reclaim the cached zswap_entry, Writing back might be the easy way. > We just know that it was already loaded from zswap. We are essentially > making the previous load exclusive retroactively. > > Is there a reason why exclusive loads cannot be enabled to achieve the > same result in the (arguably) correct way? > zswap_exclusive_loads is not enabled by default, so the shrink_worker may fail if there are many cached zswap_entries on the zswap_pool->lru. Is it possible to make zswap_exclusive_loads the only way in zswap_load? It only makes sense when the page is read and no longer dirty. If the page is read frequently, it should stay in cache rather than zswap. The benefit of doing this is very small, two copies of the same page in memory. Thanks.