From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEE2C7115A for ; Thu, 19 Jun 2025 02:51:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0BC6B00A3; Wed, 18 Jun 2025 22:51:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71966B00A4; Wed, 18 Jun 2025 22:51:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B62096B00A5; Wed, 18 Jun 2025 22:51:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 99C186B00A3 for ; Wed, 18 Jun 2025 22:51:21 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 403EF1416BC for ; Thu, 19 Jun 2025 02:51:21 +0000 (UTC) X-FDA: 83570623962.28.DEAD0ED Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf29.hostedemail.com (Postfix) with ESMTP id 87700120006 for ; Thu, 19 Jun 2025 02:51:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UE4bmpXA; spf=pass (imf29.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750301479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zoj04BxcSgUHo0cLCTX5FEhqXJOUHHj4lUxFfx8StKk=; b=4eWxnA7ztDYBknWYZlPqUN+AGUvgfA6sXFlwTOVCCovuwepN81FfHqsMhP+HzG0o2DrVF6 HC1zsKkTgJANeaSfAIxwhfsPS0Pa8+JAZ22rpUaVz4b6zQY7tnCWRIIPRWwUGz8W7O0h1K binMGD57oKzGQR7GOUHnvGslABlUad8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UE4bmpXA; spf=pass (imf29.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750301479; a=rsa-sha256; cv=none; b=D7Y0cqgzGBTFfBBHPOKmwigTe4PrpS2aGKybdWO47YLutGJudZxuW9uGW5wVcMOhFOc+/t WoA+NY1xoEsaW1BtysVvuVD0N5R5f5RqCVulXZnd4UwTOj2b5gNr7qszmMUGtD+9byqKeD CsdtWtI6D55+44mQB+4EvwWcrQl0G48= Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-32b855b468bso2839811fa.3 for ; Wed, 18 Jun 2025 19:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1750301476; x=1750906276; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zoj04BxcSgUHo0cLCTX5FEhqXJOUHHj4lUxFfx8StKk=; b=UE4bmpXAt0dXjmAOFbn0si6QZ/enAcMkZByeJGFTj9VTRnadbMbTY40RYBtVWfdnj6 hD+IBba2FIt6qK8PaoGeC2xKrRl57EV+wQRPXkMkLemBPlsdTDhexdcazRK0nsxDIkDe OCjNOY6j/OuyGCyXaF8ri9Bs4JD3xV2IgBpx3000YtF+PIboQ9/3RgCKD/Vej8C/nNUr HppU47gygqbdlZG6utlztwYo2OWq71Rg4miTZAox4ghIdk0cw1V+pJofbKXQ2pU2z1ow zLH/8HM4ZdYGIPBYqyQP1/JFYgtIIbvZp518VNoahawyR+TL2msxu6H4ijDtEHFnmZLE QCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750301476; x=1750906276; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zoj04BxcSgUHo0cLCTX5FEhqXJOUHHj4lUxFfx8StKk=; b=T4xPhEnwdbo2mZdiTK9yQij4W2ak8AYzMJachb+SL9cWLz7a/oKFksUdZMo4K6gYaf 3pwojTUB0/KOEOPp3AbuiO3OmU9Zb8zxFacijM1yymdGhNV6u+/m/AgcHZSWLPs9JC4L 9oYSAt9t3KLsX76Qn87m8Anf6Mi5dWcbvz1iEyr1ewwC2WUZTz/Mgu/lGOk78owKdmG5 4hVCthEhFhBRBc32VqACy1QTKMi++9GbIGuqELs4y0UZHkLEJfHt0nl3czYb/vLSrCOU Wl+crkVmBYPG/61vzgWkVc+QCt+HsnzIJQEjqQjNu1UiAL647g+NUDGPpTSsoFSmj+Z+ 2R5g== X-Forwarded-Encrypted: i=1; AJvYcCXs4opKPuhfJ01I4uKOzK54HtojAuxYVar6liCwPnBg+XQEH44eNovfCztNFQ01ctJC/CyHJaVzGg==@kvack.org X-Gm-Message-State: AOJu0YzGc4XaasYFR/Ba1QzMvRyqSoUvEt6oQT39BRc7t9unsS82vtLd oOfarZVNoTdilvhzhy17E9beM2lnytPS52M3AYw+MbbgIUU2yz1L1WIey0bLk+CDeIRsBaktMnh Q+I4jcfyjcZYfmzNnTYyLadQ3iQrQzG5B25nA/9ggIg== X-Gm-Gg: ASbGnctKeUvSvZMkjaz5PJ84aYwwQnsbh8xGG41GmTfSOV6dNjtzIslG200+RtAdXdn xx/xLgCeYMh3sIqREnDmhnnC2ANE4oEk+1PgPqbgcyP+Cq2JgmTjT68gKT8bBxuWscuoZVTfKVb qnYqzt+y+x8kredamlaFoer/DqsBAamdNWyiyrxpEjX2gDQiLKwuC7ejiUWonaUaYlyVgz X-Google-Smtp-Source: AGHT+IFOUkX1y1u7svsw7umztUFkTR7YYsTmcIii9tVEuqmjF5Wrio6cWk8NxPkN4RjFr+vxgJMGVzrOH2QKeH+KSOs= X-Received: by 2002:a2e:ae18:0:20b0:32b:7ddd:278d with SMTP id 38308e7fff4ca-32b7ddd28ddmr10008701fa.3.1750301476457; Wed, 18 Jun 2025 19:51:16 -0700 (PDT) MIME-Version: 1.0 References: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> In-Reply-To: <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> From: Zhongkun He Date: Thu, 19 Jun 2025 10:50:39 +0800 X-Gm-Features: Ac12FXxRaTVqIQbFKrHZT4tz0w7uMsleAym2ofIe8msdET6hsMg9nOlLueUNXrk Message-ID: Subject: Re: [External] Re: [PATCH] mm: rename the oldflags and parameter in memalloc_flags_*() To: Andrew Morton Cc: mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kent Overstreet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 87700120006 X-Stat-Signature: ym1wq1eow49tmfxcn6w6pfym59dmtwjf X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750301478-570209 X-HE-Meta: U2FsdGVkX1+Bk8RMJMXPk9ZxnkB3S6FU3YOcRGpDH6/erg07d1uI8HDXeyUGrFXTxnH72SVOXoUxCCrGUqa3uT+x4JySfP+Fvsn+urp2Q7s9UGmaqCjhytBq/PwFejlArhfZhLFU+qvz0uJqX0ZOEo+DvaBtSxRplm2Zn46gmJ8YDZnv7yY/gY90jnaV+gbL8YYVn1c6HLBGWH05PfjiZkfu2NJg2z73NKDIlaZQzLnYXdZ+FraNoMQNNXEjr9PphkECYwGnEAPvNzoyOMzo26ABoP6jqf0XxFbSkYTHVmaqkO+CRJEnwKus3JNTyVwwU+IjSPyaBAYn21GUFQ6Meib51dFri9khtSaUO0HgAtfJBPgCiOmnM8ZLy3D8vSyFoDuovkVHv2tAZFOuhyk84wKXDnQiMFfn8wbgS9+hFpQ7+7JrPb6GD1gbAkQEz9/03nbKuAXaIfFMRr1cMgSXciQv2NqcdmrAEw+poCL8RCuUV/bp3xVNTUGyB4x3QjPB9tnE7OryZh/2vExjJV9j2MabyxO0Cvx7z5mc5I7R3WY8r48+hiDXTeq3psPUN4/7HmmiqQ8kLSEk99bRoAxjgIzW2Li2zlZejvHcSH7R48SfvtnpsEKcezKoDdIQ7GxnIP6cxRLx3SLM1YBhB2EncfoPSgKXCqYx0vqaoWQyUJaOJ4MEqYkBFxAZxMpaA1pfxDvxBbj09jVk+9d4YMXO9eSTi8aK9Z7/jlAPs9nmAGG2b9wzUVKDJZuLSCenSWmSsoayAd+IUVGeNt2N3IY2a63wHHjeJ7CRiYDGxr0Q0SP/xqU29AIvghKG0W7QhGZzMdwENBhGvZSWTqgbNBvlu7S/zreaLk7hcL+tN5xgZ2MDn6v1jm7cCOeWks841Z4QScE6ueIpVPjepAQ8agbU0vMwyD3yxNB4iz/h13kQRSI56nuzwswm2MWVr/I+U8I6bxNoEd+iCqf58nOVxzI nzWJUsXp lnEqpT5BTlSwQXH2dM8zT1HMX7MOVgB9zqEl71bmHpMDhUlw4KDd0aoSrihtEyxZdl5CNdWAPUn7O4RS/qIEAfJlEZjW17jaZQv6/Y+th+tZGqoIlukLyNJI/q0bYX4sTuP8ar7lWUEHDzkVJMyIurg/oxDxU60oWkzRN/IfdQ2gOYgtdvhtgMdoJk7W7vs3u8P5BiFZfgy5PEpzENZkQz3tOUhy/KnG4ZY0fWGQFZi7BQ7srAko1IBNu9oan9JJbJtG00hYAwkp6JNH87AqrazkgVxQlNsb3YrWzLFJuybojxJAnXx9ZsNJCD+d2t/SB92/Fd1sdc4n5ZxU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 7:43=E2=80=AFAM Andrew Morton wrote: > > On Wed, 18 Jun 2025 15:03:28 +0800 Zhongkun He wrote: > > > The variable name oldflags can indeed be misleading, because > > it does not store the complete original value of flags. > > Instead, it records which flags from the given set are not > > currently set. So rename it. > > > > Your email client is mangling the patches in strange ways. Please send > yourself a patch, figure out why it didn't apply? Thank you for pointing that out. I=E2=80=99ll check the email formatting on= my side. Sorry for the trouble caused. > > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -322,21 +322,21 @@ static inline void might_alloc(gfp_t gfp_mask) > > } > > > > /** > > - * memalloc_flags_save - Add a PF_* flag to current->flags, save old v= alue > > + * memalloc_flags_save - Add a PF_* flag to current->flags, return sav= ed flags mask > > * > > * This allows PF_* flags to be conveniently added, irrespective of cu= rrent > > * value, and then the old version restored with memalloc_flags_restor= e(). > > */ > > -static inline unsigned memalloc_flags_save(unsigned flags) > > +static inline unsigned int memalloc_flags_save(unsigned int flags_mask= ) > > { > > - unsigned oldflags =3D ~current->flags & flags; > > - current->flags |=3D flags; > > - return oldflags; > > + unsigned int saved_flags_mask =3D ~current->flags & flags_mask; > > + > > + current->flags |=3D flags_mask; > > + return saved_flags_mask; > > } > > > > -static inline void memalloc_flags_restore(unsigned flags) > > +static inline void memalloc_flags_restore(unsigned int flags_mask) > > { > > - current->flags &=3D ~flags; > > + current->flags &=3D ~flags_mask; > > } > > I guess so. Maybe. A bit. Kent, what do you think?