From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76095C41513 for ; Fri, 13 Oct 2023 12:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE8BA6B02C9; Fri, 13 Oct 2023 08:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A236B02CA; Fri, 13 Oct 2023 08:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88A76B02CB; Fri, 13 Oct 2023 08:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C556C6B02C9 for ; Fri, 13 Oct 2023 08:59:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 96D741A0224 for ; Fri, 13 Oct 2023 12:59:33 +0000 (UTC) X-FDA: 81340444626.12.03FF139 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf28.hostedemail.com (Postfix) with ESMTP id 810D4C000F for ; Fri, 13 Oct 2023 12:59:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="LeSxri/V"; spf=pass (imf28.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697201971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eg6s+PkmAT7pmMliH2xO/Md/Hft9jtXneskCjh9+2ds=; b=65D9VbrV5Zza8v9gYZ6SWaB5H9K5Izar7A1kqyc6o3yq5KJcQ6ij3jY6R2Rd+NrKFmwdKz tmog6ZHk6RMVzKLMLmmZhheF7YU3JnlBgtlz6Fc5cxywrfF9p06hRv3VYBwQUx9Pw3odfi 2oS8YHzrbUPqYUrZz3vbuHRrq5omJM0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697201971; a=rsa-sha256; cv=none; b=4n3/yFhrtCFYXPJiIwMUl2AObmJ0Jgk6ImAvQOX/Qv3ncmoq7S2DoUm9zXYbV+tE/V0etN WuY62ru9idDh8kke6DoVrsYQFoZO3qV4g4P+AEaH9WYnLgVUOD4zmqerWnfWXmy+JJHz5p 2bIIQy1lz0qma8PCx0K8oEefjOPN1Cs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="LeSxri/V"; spf=pass (imf28.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5079f9675c6so134919e87.2 for ; Fri, 13 Oct 2023 05:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1697201968; x=1697806768; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Eg6s+PkmAT7pmMliH2xO/Md/Hft9jtXneskCjh9+2ds=; b=LeSxri/VvaTJicy3+D+RNeEYlFbtdNQ3RIVBBN7/sGw/8/EKGSInIEc9LX40UA9+ht 02oHovUEUS0g5u0nitUON4mlmhePfpmhrZd8Qpmi4uXzFnNHXci3KmKZoBXXhofopno1 oFLOt5fCM9UoKH9OLjCM9gsI+6BtK3rbHM3yrQcZC5ASKsmDKpHApWERU53FAgpoyDsc rouRcZhxV33y/hB144AeEenIieqaWh/jYH5WhCi4gw/bNgGuJBr4wg1J2vRH8ZjF2dfR hxiDNK6iD89UgIiJOeI79u7kcshXlIaW9TsWy6hsNuv3drs1GUFT+OVSlU1GsjwJrTRb 6dEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697201968; x=1697806768; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Eg6s+PkmAT7pmMliH2xO/Md/Hft9jtXneskCjh9+2ds=; b=bORiGs85r+1opr6gywvgu1Q38OngJbepTMpyEpR4AXNJDlSiWGY46Os6snNe1AC6fq UcHDh1K32bktaQoRzj3aULpBu6xxHH8zoQizGSR8bi4IapSgKYo8vjHsJTWOhwxSTd+9 RnxpATx06D0FOUZhbRJNLFCDDjLu0NHi4cbVknxe1zwTMuFaDwDZnhJY1ARgbSY/flOD PXSNmUehznHaAYMorMJ2iN8X4/r3qQu8HHepG7ezC4HqZHJEEnobCmHSwbRE6rMlxhHx lL9RMu9xYDval8/nnR/yLbs2xsu3jxQRQpejNoexcLycrGmqfxSTPumKwQLP12WiaBDi NGKQ== X-Gm-Message-State: AOJu0YyWs5p5PZEuOkwjgoeie3BYbyLehRIpj5RPkVD6jJaKIFfUgWcW ZQSU99L558i9SGmoQvNU2zNip9Rj8ZmDE8d3YWQNWA== X-Google-Smtp-Source: AGHT+IF8wms366Ocsuw+3/X4x3cARD5bRqEjcX99vqDV4+xvzcKp0vvywQs7RHegbwHauJoJefab87c2mHdjolL3u08= X-Received: by 2002:a05:6512:3ca4:b0:500:b9f3:1dc4 with SMTP id h36-20020a0565123ca400b00500b9f31dc4mr28837815lfv.68.1697201968478; Fri, 13 Oct 2023 05:59:28 -0700 (PDT) MIME-Version: 1.0 References: <20231011051117.2289518-1-hezhongkun.hzk@bytedance.com> <20231012142203.GB470544@cmpxchg.org> In-Reply-To: <20231012142203.GB470544@cmpxchg.org> From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Fri, 13 Oct 2023 20:59:16 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH] zswap: add writeback_time_threshold interface to shrink zswap pool To: Johannes Weiner Cc: Nhat Pham , akpm@linux-foundation.org, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 810D4C000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qficjaj1rmfrxay4j6oi7q8b4js8r1qu X-HE-Tag: 1697201970-692223 X-HE-Meta: U2FsdGVkX1/DWhrKerGEjj5lcTTpZ4GKLpNwxKVa+XSrAkiufjarT7yFKutTgkrLQdHqExus2tveaN2x9AaTumBUrg/Fo7UH1G/xe8UfUyo7D7lySZW++Xd+30IvXT/UwPBKVKzhRf0r3V9zfVHY3aAzhB1VOfPLG6hDSyHbtgJCzv+j11ZyNGK1N6buqNF9VrNLKgiWE2RooDZDTBge7vAPjKbRWY/V440AClPEKR5u2a1Eba0QdviGwofg0WOoADuxiVqAU/XYq0trAfneZQHjwq196wgm+qs1wSzs3R/8q+DsEwFpgUR3MPxEfGXpgKdv+QAl4T+8MD4c+YaUOuChHCI9P4fiB7QYyVIRYU2YfuadA/H/Y/g1eVhiBEQ2cBev3zTxW5ki5+qGcY6UWdbepSiokZf078ozMp/ju6fW3JnTIvIeH9VxL5+K/fyLqBdQ8twzRtx4LCHU5QVU/kx6F4OuLGIfI8yuVOV3w5T18swmI6GuQ3GmBOUloKZY60YA/RzaYI9lkLNsGDpUOfsfNgQg3Jr4ZYdLo+Xhb9D854NO4KX80fKJusbhsFbCFrTo2D432/TAALCDwU9TBmdTlJA7RCNdvTlgmvU0hhCEAKrBqEX+aKuxxFqv1rKDdkoHWZtXHM1tvGqMUBUg/6ngYqSPmRDAESH7hmgvZTZ8LcK2HV8ehpQPoRBWa+isJfAMh61Vi9qE+6CuMEnNOeg1ImApbYmQQxPHTTpQDfcXaYORN1QILHJ0hD1dhrJAYJ9+LjqhdwW4ZFRpiEB9RpV9eze5Mlp7pX7n8xhFxh+JRdV5KPVHgBHKPPp/VxXAAH+2LL4dQsIXiSozc4RgjwCaLDS/Xc8Ol8DMu5yiWt63jE8fl7AFL8H6xlgDSlFZbCVLSH1/34G+Cef/C5xSce7LK6rrqInmlz6ERcMNrtF7qp36sUkqml/Nu7u5L+HHUSQeO2uoH+LionQbgx6 YaEU/6oS fF43JU0el8onx32dyTMAbiU+e5DbM1NvCWcO865UfN9Xh2UM+2e+shekxP1+PECyz0fhGOS8wcCgbGCEiyQOWVQ2PxLfsqGCy1HR2vDzPlx8x9XXtQQKGr7mXPxFbMtbLoJwyrhf6sjxlGVA5lmSQfLM3GhKMpCC1cp+c5U1t+k2dBcVj2gygQA1Z1qcAj+eE8RBsCsRBvbuOGzZ+ZIE+a5yo9Zopdg4Xzp9gSf1pccJWRC5ClmbOkCEci2LQrq1BMB6VFggHvsNYSDBosvYdzbFAjJcEZccBiZAWEfAkH4Edl1ok65LbRVjORA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003107, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Can you use memory.reclaim itself for that? With Nhat's shrinker, it > should move the whole pipeline (LRU -> zswap -> swap). > Thanks, I will backport it and have a try. > In many instances, swapins already free the swap slot through the > generic swap code (see should_try_to_free_swap()). It matters for > shared pages, or for swapcaching read-only data when swap isn't full - > it could be that isn't the case in your tests. Got it. Thanks for your reply.