From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD34C197A0 for ; Fri, 17 Nov 2023 09:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8EB228000C; Fri, 17 Nov 2023 04:56:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E1E280008; Fri, 17 Nov 2023 04:56:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B067A28000C; Fri, 17 Nov 2023 04:56:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9F994280008 for ; Fri, 17 Nov 2023 04:56:16 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6CF7BC0D1C for ; Fri, 17 Nov 2023 09:56:16 +0000 (UTC) X-FDA: 81466990752.19.91865CD Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 09C29A0019 for ; Fri, 17 Nov 2023 09:56:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WL8+zJwK; spf=pass (imf25.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700214974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mAvn4TYGu0MnjACYvrOksw5KpK5y/I6gyUCVs13r44Y=; b=6Kiqd/EEg7IuVhLHFZ5pyC/jjExtpcOfndfEvaLZS3JxLsbjMD6vNpuL8n9wYiRNuIvipl WujNiDrqOleGwX2tw5RcqfVBBdpHTGwX1MIJHJoGinBR0b+TLII37BJwRz6Ob97gGEwz51 E00SS2uLqZGnGWSKy5ByDpvqcs40IiE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700214974; a=rsa-sha256; cv=none; b=gnSebDYymCNVomGRhKcVNjKlOl7plszggajtf9VNCPu/9824WyfMh7QWjR0tIQv9tFKVwO XKMJ0SFhBKffJblN67s8H5OnM0FhfABDMKN+jf6NLyWChCVNj17h6E0yuJvySZIF0pqiaU ozn1D5a+VV7fgmrCgwAVdW0EUPedX6Q= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WL8+zJwK; spf=pass (imf25.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-507a5f2193bso1882925e87.1 for ; Fri, 17 Nov 2023 01:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1700214972; x=1700819772; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mAvn4TYGu0MnjACYvrOksw5KpK5y/I6gyUCVs13r44Y=; b=WL8+zJwKyqwLwEsJCyaVfeImymjA2E2ykgAUvdrQ4qY6uXiJwliitoenuZY4A05tJ8 CHyZC8ADg3Ma93Ge3vYSl9LGJ1HCveCu/spQpKlVoA6RpSKn65VtIUaA8Z1bOLidO9aG wRfBVyekAZMMR4CJQE7+v2wXCfOF1H9kZdPScGIjmKA2p5I+52vU77rio2+HiOAV8PeE dIsMyTSAYbKm8QT0JEfIJTkwhMrDc0Ci3P3uoPAkGTv73xlOCofdUCmu7E6Wm01uJUmX yZbXoOKlQ3t6G1ff98RULOQ42oWUnlHvLK+P/tKBlOPBqRZwWJs4kKRqnnEWEzhy7LCl ltsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700214972; x=1700819772; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mAvn4TYGu0MnjACYvrOksw5KpK5y/I6gyUCVs13r44Y=; b=io72lJguFMecv9SY+XjU+BIRVSmChg+LDIwcXTPhH5KDpvvQ2+GcaQNY2X26mIQIZr 5zYXY/nwcwvmXr+YBngc3df6K8CgQclUEkTgghnn4SHCfPZeCu6MLAQUxEF0OuP28ixI Jl7C+YgxygdeV4wFWUgkA2BtyNpf7PxEM8Xkij78mn5fvDIY7ayKdvZ10zeQBYz6sXo8 8S9ZxLr3onC8aAP7noFdwo5Ifj8slfWqXHPRDfOeCd9CsEvB3McmCc0T/OE7C8WFxMeK dK76HY7LuRxE5jQvTkqSHdiQM7ADNowu5n/26pu4S/BoF2KS88OHxEEmrLIOTngcl435 FXTQ== X-Gm-Message-State: AOJu0Yz46WGSgLzvMMFMFIeZ9buyT3huFqOLKYV75ZWjPq1I1FQMCCnI dBaUvnAoR5+O41eLWhi6Jd9dpJNMvcZGq9oBNQB88g== X-Google-Smtp-Source: AGHT+IFQ33UA3tDkivKY/MbQUTpvO//HGjhdrR+dNQs+AkzXrlfm9w9hulG6vAzWc+6GV0F+aONHgMimEceIG0dWEvk= X-Received: by 2002:a05:6512:ea5:b0:4fe:8ba8:1a8b with SMTP id bi37-20020a0565120ea500b004fe8ba81a8bmr2028501lfb.7.1700214971975; Fri, 17 Nov 2023 01:56:11 -0800 (PST) MIME-Version: 1.0 References: <20231113130601.3350915-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: Zhongkun He Date: Fri, 17 Nov 2023 17:56:00 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios To: Chris Li Cc: Yosry Ahmed , Andrew Morton , Johannes Weiner , Nhat Pham , Seth Jennings , Dan Streetman , Vitaly Wool , linux-mm , LKML , Ying Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 09C29A0019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pbbxhgkcb6wu8ozwohfridiriior4iqd X-HE-Tag: 1700214973-668763 X-HE-Meta: U2FsdGVkX19f4yfJh8/tb2qlgzN76xH9pjmIpEcHSR0ji0DpUiiUPe290LuJjlu4A+ZjWamx8pWPS4uih7I4VRYpQW8aHKdvSuBfy/qmKlMWreL2Vdbmxek0wzZy8b/ikVdzSOABHLpZhLglPdias9QqbNCsl5efl9+79aSdBt9rLynZ3D0UFTt8QinNSVzQKFXryZlRCSpvnPCMKKqAIRBT8ptn0ez+CU1XOzeYExOkPZ3m2oQvjPd0axFniJ//STFdVE9WVz7wjp9HlJ1uQ5wgwwoevZ2yA94tUATWDjHopchgkaLbebTZP5sJ3xDvMM2IkMCAJjN6tzcfK/zoFIPABBcOUbMvo4CdpmZBC5h5TQKynBz9+C1xNkVr5udKyfu61vMR8Amei1I9Jrl0VMIxVhnTuHgySXTOEtmPDgXYAHfwXOTI6r+tyDxUWm0D300Nu/LkkyobPb60gigN7Egv0mmDweksp6JLIt75mVu4G7j9+fZl7/u1vW/Xcvn9nYiS1LxqNZTHfKmSzb61twcLn7nwMeQJ/jDObxWH/aRwO1XuZwVdLrqt0ywm2IcqsJPxWtzvznXTH/EIJRADZGHzK2yugIc3ui5l07/aE+XDhXyG5N+IqAP+4UJ9Yd2lRauiDsI5y98gr8Mg94lLyEWtp7+ZasdLYUp0aZ72gDdneYXUf+hQ0J4HgA5xP+ji1gyjiT5wGivcaDpbnLw/ixgAecQLSUdKmdmUjnWynmZHQDeLqdOeNENp9uZ1xnBn2uRy1n4qlQTEWFPHX41RQJyI8mU9Vf2sr+YaE5mEMyCzKNx7uxzJYdSvkvLCbrdlQm5H6zQ2aVr4PR9G8xvTY7IwGWFfxt6bOR8nCQFJsFMz/6nueO4B9NWhWdxfE7SkGi+JUKVMBE9q0BLi4lTzg2URXndXuAlq37zc6+dOWiycld+VosYcPVcjxI0CH+aedzADKQbb4XvKROtWikH duFAGFv3 EAZbHIf0holXMaEabt/Mi8Ul1QFm3Hkd0IBnY13GlcV11q4QwJbG9u8qGLP/QLsOX0Ed2uxv1oLs1oJii3SFIf4qshPKAWpS1+eqbliaIBazS5fkUe8bnMLw/zi9GbMfB9C33/rJkRzA4msnPEqBgXnL2Yi0349v2v/ra6T2dH7PDZinzKc8HOGtuNWgOlUUdczInxxNl0qNKu24Nz3RdkDzz+XsVSOkdUTEQk4tFKbOf3mY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000132, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > That will cancel the batching effect on the swap slot free, making the > common case for swapping faults take longer to complete, righ? > If I recall correctly, the uncharge is the expensive part of the swap > slot free operation. > I just want to figure out what we are trading off against. This is not > one side wins all situations. > Hi Chris, thanks for your feedback. I have the same concerns, maybe we should just move the zswap_invalidate() out of batches, as Yosry mentioned above.