From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD07C197A0 for ; Thu, 16 Nov 2023 04:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006536B0400; Wed, 15 Nov 2023 23:23:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF8A76B0402; Wed, 15 Nov 2023 23:23:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC01F6B0403; Wed, 15 Nov 2023 23:23:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD3AC6B0400 for ; Wed, 15 Nov 2023 23:23:33 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A22B21A01CA for ; Thu, 16 Nov 2023 04:23:33 +0000 (UTC) X-FDA: 81462523506.24.9423E74 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf05.hostedemail.com (Postfix) with ESMTP id 99567100004 for ; Thu, 16 Nov 2023 04:23:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q10EE2uf; spf=pass (imf05.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700108611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0aRwczQ6tXJ0ICX2vno9uyodkFr2+icyRVyCD2VH6Q=; b=EFcpq1bWuaFJ83Ux/n+pvISyxUyZO131N3OFx5bzb3+hGlOjrtM/WuXSh0KWDq2ckVr7BH 8++L6pIq4yIF/w0/Z7Gyyt/htI1Fma+lmUS6uWhqbk5vleh4r0OjT8N2D8JIhMdiO18Dam JvrYRb5OTL0mWQ3sCMCQY8yKDsxW75Q= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q10EE2uf; spf=pass (imf05.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700108611; a=rsa-sha256; cv=none; b=eycOCBZsH7V5hzvIjou6p5g/gG/ImmJITsC3WGPr2jJtn94m12HpTDNFvyQwNDdbfP9l1G MdWrE406Xo654zRitboJEvrQPcV8eIHt6aefkiFeh6bNCKn297QX/nZGfPnNAmMHOtTOzB GhDOxRmrULHdUKMpSPjHq3FwGCiCONo= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-50949b7d7ffso546860e87.0 for ; Wed, 15 Nov 2023 20:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1700108608; x=1700713408; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g0aRwczQ6tXJ0ICX2vno9uyodkFr2+icyRVyCD2VH6Q=; b=Q10EE2uf8znhOoxuvwQecsy1hR2VzK7QtB7wIgtbR2H+42jxXBVSbjPIpu1Qsrpi+Q 0orHhrZiBJez+vUhYahf4+jbFn+pHbLB4PuleK/ihnpnz5bCA/QuWJnQsLTQgRgeDApS jkBWQz34V3EqUZZrxMDtbJBfIyWKWgtzQQq1NTiSG+OCkiizRSAyPlII6IECoukMBWXH fdvSFiCrWw89Di5bs4srw6OiCyLzkeL7wrH3XKkqA0bDQQI2bZnqW/DIHzu+h4Mh1AjV +AmDVN7Dzvli9WruFtgzSa/4Fz+3Ag3hHKlSmJ7WYdb74QDddsLCVu0tDSS46DRWgg/Q JcdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700108608; x=1700713408; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0aRwczQ6tXJ0ICX2vno9uyodkFr2+icyRVyCD2VH6Q=; b=IhSAL4122A9pRRD8l5YPV23kd/GGzAlhXoa8RNmadcu4bCvUXk6tfln/n6iic/0Dpq 8WOwjzYAA5TgSvwLw773uUpCcwnQgM+K+T8KAdkyfplsLOHSVRhVkrolYJdn3pdPU4/j GLVcbgmfPqLd04oHTrwfx+XAhoMC3it8N2lPYCC+j6pqmFWPwcFpW8FFfkPd+1WgUOMk BlewNmIKhxtXB+lz5ENhm1hpk8Uw0RL570Vlmqf13Aos46JmGecW5cw1A0Ei7eHRhxHN cBmnG4xeHlzig4B1xTogjWhc+4qlfYu2SfKEjLNfIbtgb2j83rKAeScBJhCtQO+BlmGQ CXDA== X-Gm-Message-State: AOJu0YyPySOnNI8lB+tGtDIDaKqUVA36kYKswKOnesLt30XXg5MTswAI yL7C1GbPiVXOPMjz1ShKWlqdyte+XDX06h8gCF9WEw== X-Google-Smtp-Source: AGHT+IFV9dF39WtBwrc6I+AKNmbZNIWJVcMdtcfciM5wJckqUfPts+vsDyQehbBFStQ2v0COe4qgTLSGhLtzadfnKrg= X-Received: by 2002:ac2:4e10:0:b0:503:905:c5a3 with SMTP id e16-20020ac24e10000000b005030905c5a3mr1029096lfr.35.1700108608561; Wed, 15 Nov 2023 20:23:28 -0800 (PST) MIME-Version: 1.0 References: <20231113130601.3350915-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Thu, 16 Nov 2023 12:23:17 +0800 Message-ID: Subject: Re: [External] Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ying Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 99567100004 X-Rspam-User: X-Stat-Signature: 31tb4ccw6rmuzzdtf69znc45azz1gxpr X-Rspamd-Server: rspam01 X-HE-Tag: 1700108610-158127 X-HE-Meta: U2FsdGVkX1+CRnBYAoAPS5t03E7zdvar1zqMMTWwtc2BF2mYhqDJSxgqPwhadfS9WZOV3CuzXyDCFcYQnrdQiUub2s0M3iZOcZCJsFOQMteLjx/jmEDgdW4iJ8VPovhMBi4mScBOuphjVsvAN8ucB7/JcYm9COLZoEPMpjWvNGoBLxqlhGprrzUZgMgUXhOE2T9IhOf4+Jbf6zQFWRVMhleMo8EMQ/nkXhz6RLoK9brbk0QapB2VAf9Buq/uxeMtdnYvdP3h8dmcHEoT3DrnJvz+0OSm9xdHceZ891vKXk6JTg9j4yMHmbsrUc0QtGQQnbFK6Z3uqOQnHdRPkP9hrazcGpxSp62d2ZbU74YAhhYE8i7Yp+pO2epf2h+zH7OXUkZml7eRmx63psSmIwT5BR5WEQhvDhbHp6VHcE0ejcCp1E684DO5vaQZC2GWP1rhbQzAjOi/Fp4SjGkMY5c+Y7p5D7w4kkV+ijhIlS+mONXajVfwKJxfMEShlhz2OFcQzIlwJ7VH2J1anquja/+vlNv14gy0kL/lOmdJDQOywxnHEPQhSxyxgxPWH2AXMs4aKhz2DXUsaBqNWHm3aHP+Eo5aYm1M/Xdb6hOvsLwQ0G4tdg1KsKEdSDDxH9KuikjAoYWVlcp7x2VoBJfKwOnI4fFU6iHAmaAiw/l5obg3x6qqSv11Us44tQ0hR5HTI5jF88k5gg8vj6odxpsVK5G7RdesJ2vtPhNIIP1FVAONkzLYOzps4+6+IRQbuaOaDatvGU97tynXizekz+rQzSLb3iuayLG902PmBXlVn52+Ao3Dz/R4XlrcUczh0Ew80i08j4VFFuwyy+Zv2/2OaNVKMu/ipyULXJr4rtU8pVzO7isLKV2q7DBy7IlF3opwuIOETSFqmtw0mLgZWapRAdvJm3ksl8ZL0Qq7oobVN39GCGUcbnLt9o8MEkFc3REiiHUgy8KNwhw0tFtMzDInu+b c+iTW2Pt 3gNqoGAdNk6S4MBdoT1WwcQYdJ3ARZX5HWAP4Kv7DTHijeyLUlri63e2H9pRcbEWxKNIW57+JrNueetYl0MneNIvG1mDYS5e8/ovAIZjSdT6C5ge8/CCMD49AeBeXwpH02sk6snKeATfVK6wzd1A0MBlpC0oG06kZl21yCVT398VmEuhepVzcOaV39sxkMBmDjEf5aUNipif7EORH5oIL4st38aDTLqQBMEV0pOqxnJm1vXZdQ1XXUWwbiPDWkphJuUxofrBtPK1LYWIbcjKv4/PT2ayPzb1uA5h7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 12:10=E2=80=AFPM Yosry Ahmed wrote: > > It can be enabled at runtime, or enabled by default by using > CONFIG_ZSWAP_EXCLUSIVE_LOADS_DEFAULT_ON. > Yes, I see it in the doc. Thanks. > > > The reason I added it behind runtime and config knobs is to preserve > the existing behavior in case someone depends on it. At Google, we > have been using exclusive loads for a long time. If other users of > zswap agree to make this the default behavior or make it the only way > to do zswap loads I don't have a problem with it. > Got it. Thanks for your feedback.