From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947CFEB64D9 for ; Mon, 10 Jul 2023 14:59:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E150F6B0072; Mon, 10 Jul 2023 10:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5CA6B0074; Mon, 10 Jul 2023 10:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8CE96B0075; Mon, 10 Jul 2023 10:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B77E16B0072 for ; Mon, 10 Jul 2023 10:59:35 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 35510C016B for ; Mon, 10 Jul 2023 14:59:35 +0000 (UTC) X-FDA: 80996011110.21.1C9DF76 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf18.hostedemail.com (Postfix) with ESMTP id C96D81C001E for ; Mon, 10 Jul 2023 14:59:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Le27rs3W; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689001173; a=rsa-sha256; cv=none; b=K4lOe6eGy3g2a4XU+6fUqpwFzSvzl0c+bb3D5A0cdJmlrH+tdEiPjFEcOP3MPm2gF1UgOF 0ycHq4AShVgKmIoTDBQQiolcLVBeglEiL6ZU9NxKsg6z/WUsD/ZFRA/rwJmdNZOnjjGeIL XQf5nCj/5brSFJidooBQTkcDHLnHffk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Le27rs3W; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689001173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WHR2WMJHyhNBH5ZT3Q1RZDBVx9mfa7kaDZFV2zZ72Ww=; b=gC95ZmVBvWcoXQtGh4ZhGX7i5gaSw3dKRcaELo8/ANLBIGcCeiOA1hlg8ETUP2iCEh1bQv TLD9MYU541/ZUm2r9ZV2b/2HcXvdX/jiLPxoE/XIx7TAZFuSKCyR9M/iW6Og+R48rXl86Z g6wNgBGL388sSVu6eP1Z7FqhsclbovY= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4fba86f069bso7164774e87.3 for ; Mon, 10 Jul 2023 07:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1689001170; x=1691593170; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WHR2WMJHyhNBH5ZT3Q1RZDBVx9mfa7kaDZFV2zZ72Ww=; b=Le27rs3WECyaK18VKxayFVkBGweMznr5HZ2oGqvoMXtcGJHUZr5T8rvIGsfMEVJ8Ed Gxw8bEHkvgkAcj3psTDWLqN/h7P8RlLx4UORMWNXQvC3BFNcRSJsumdlJvaOQTtefnEm uB3r35Gj8NEc5VFRY8S3oCp5Evn4lZ2PvrFIVzhlEnx2qeYf3Rhy1Jpz+hDS+PTcB1+d ls6Wfs8U6ppK5ORoA1iBP6x7DKtKqf+WqlF64Hyn8kkoJBq8ElwtP+yFYokF1KxYZkMl 4UNEl4goJfldztpoV+lbI3im7qC4CQ0cwvzP8hwB/0uSUXcqbM8qe+LcOZnx1wHF+wrk tpXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689001170; x=1691593170; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WHR2WMJHyhNBH5ZT3Q1RZDBVx9mfa7kaDZFV2zZ72Ww=; b=E2WNvp+rhWvmA1eFw+X/qY96uKYQDo3lj8sKnNII09Q37MGSikA3dmsaGZmbcm7Ns+ d5pTvmpPonr4sE9KyIY7T5iq9zXufUAq+8bqVnKRPgko11elOyYN2jMH0OJ7ggVLrR9U z9ry1cVy2o2Hpi1dDZnMocHRih4cEQy2EqQLHO7c+PiDczhGmZaGLIjqetBuekGsvhV4 7926qCeZZK7aeXVhtc6N4no0Ua3PBY6PujuLeNjKx32yF3GoHJrO1/XUviaZg1qYik1Z Orlx7f5aq7FoqNE5FSetMyoOrq6M7PD/6strZJtF7jX91DxthIdfwsg/UDC4qy3QM4ke cXdw== X-Gm-Message-State: ABy/qLbu3h+9GyWTpFSsun9EkIX3KJV91JHS3u6rSZ/cSpdlhqrY/y6h IR7vHr9+fFkxS7VomaH44GU1EVtvAf8bAypzz19slw== X-Google-Smtp-Source: APBJJlGiRrXZU17h177ynrv1JY0VYTE8itWE/BdTFgxmRh8eY8Fs8de2BqiUpS4VkSVxQ1MVKxX+X35Zgs+eCQgd6JY= X-Received: by 2002:ac2:58e4:0:b0:4fb:9772:6639 with SMTP id v4-20020ac258e4000000b004fb97726639mr8786868lfo.6.1689001170542; Mon, 10 Jul 2023 07:59:30 -0700 (PDT) MIME-Version: 1.0 References: <20230707044707.1169285-1-hezhongkun.hzk@bytedance.com> In-Reply-To: From: =?UTF-8?B?6LS65Lit5Z2k?= Date: Mon, 10 Jul 2023 22:59:18 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 2/2] zram: charge the compressed RAM to the page's memcgroup To: Michal Hocko Cc: minchan@kernel.org, senozhatsky@chromium.org, david@redhat.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C96D81C001E X-Stat-Signature: zacsqfc6az44bphdu588zs9fpmkna834 X-HE-Tag: 1689001172-832554 X-HE-Meta: U2FsdGVkX19m9m0jXrq/rMercGlqMmxn+Y2XxlV9vxhJX6QcCEhn+oLKSEgwmlKVZx24Wmit387NqdkHp9FEZIZFWLErZuGX2PTCjwL0NtcvPGjOq2Ubgyj+l5HY1oVupTQxf7TWlsSXkgdNcdv7VaP3qDcxyp55X5QEBiAr943qpQVPL7FnlcEmme3ys2mVFj3SWvyJuYXpLRP2aIv0D1os7HAoKSbXfiUmLO2iq9WSCoQULreW7IQ8qkVQ6V5C6E7tDcuFZWok9BlRq1DwFElclSkDrm1YAi3ennYsN8Aj9+geZH3PF0ZN0VCw9rbtaVedT9HPAmZxhWFReGJGzJdPfiAvPSV9TXGj4On7HBiCPlqlVyJDnJA2d4Y4pjnJKNk3r9eLetqIhqt0Vv73b3j0+kbjpZsHhPTNZb1E1KNL6KPnVNQV1ner5iTziMVBzzKzyHdGszzVZ37qkwi3cOu2DfPW3XzciUFuIkiBzZoicWDNGuvqCHIpNN/gJiq+tNODaUD1Dd5jVbFpVX1f+AagS46+4AEz2GYQYCmguUDXAK5XLtYOiMKfUWVs/AL8hTrDtU66wPpry8j1FaIl/bfyVKfUxNuUeX9PAsl/4P0jR4Lo17O6W2YazYWWZ3KqHioQC620IQc7E6NrT56O1eS8wYfkfiEZUse/XQqdG8UmJHBYurJzP50AZYBpoRLDsztg+wfK5LTQytDhOTy1LNxGRIk467UkUe3D2GPlc/wOoUOjEeYOktk4vP7m3lfLIomW8L0Zc5gJl7hvF5ByOaCaTfgx6xC75fs55RZT3/09w2yHTw2AvKiH6YTT9aT5fROtYt32QUw5i12Oab+T+02+Clq0ZYyZqEm0yjpRplNKSAYYQretPQDXJB6LnhxK0HPXIq3JCtJyBc8TllTU/ZFZyieI/+ICPZI+l1MBLrnJ5oP1kwVG7lmd9+TwkbQQBXLov29qdcllV5oTRoF fgngqfjq m94WzcFqh53YGqHctpn9yCJ/c1//bJ3sES1oE0UxW55aEZnAoDqAouzkZ0bOVMn8HDgK1WjUTvIBqwN6eMN3PGA1WtWihObi29sz9a5e01CCPQMIV/Gy62vTSGDVHwL1kO5t/20bYtMFTDXa5EftSFPWbLjPV/cNIzjKaOOrGp9r4hsVUYFLnzc5+wblBck5OKt04yPA2qGdcvu/g9THwCV0PglbM9ChXifZvvdZBIChknED3xf6doOWnoHVrp9Y8x/fc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > AFAICS your obj_cgroup_charge_zram doesn't have gfp argument. > > Anyway, memalloc_noreclaim_save is an abuse IMHO (the primary purpose of > the flag is to prevent recursion into the memory reclaim). Do you really > can not perform any memory recalim to trigger to free up some memory if > the memcg is at the hard limit boundary? > Got it . I agree, memalloc_noreclaim_save should not be used, but return nomem directly,which is more clear and satisfies both direct and indirect usage.