From: 贺中坤 <hezhongkun.hzk@bytedance.com>
To: Michal Hocko <mhocko@suse.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, david@redhat.com,
yosryahmed@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [RFC PATCH 2/2] zram: charge the compressed RAM to the page's memcgroup
Date: Mon, 10 Jul 2023 22:59:18 +0800 [thread overview]
Message-ID: <CACSyD1M9ad6wTeT-jAtAyWz2LztLrRok8bVT56+Xbx-NReRe7g@mail.gmail.com> (raw)
In-Reply-To: <ZKvi4ZvhQaIFtSvg@dhcp22.suse.cz>
>
> AFAICS your obj_cgroup_charge_zram doesn't have gfp argument.
>
> Anyway, memalloc_noreclaim_save is an abuse IMHO (the primary purpose of
> the flag is to prevent recursion into the memory reclaim). Do you really
> can not perform any memory recalim to trigger to free up some memory if
> the memcg is at the hard limit boundary?
>
Got it . I agree, memalloc_noreclaim_save should not be used, but return nomem
directly,which is more clear and satisfies both direct and indirect usage.
prev parent reply other threads:[~2023-07-10 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 4:47 Zhongkun He
2023-07-10 10:52 ` Michal Hocko
2023-07-10 14:59 ` 贺中坤 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSyD1M9ad6wTeT-jAtAyWz2LztLrRok8bVT56+Xbx-NReRe7g@mail.gmail.com \
--to=hezhongkun.hzk@bytedance.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox