linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Mike Rapoport <rppt@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	 Ira Weiny <ira.weiny@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	 Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2] Documentation/page_tables: Add info about MMU/TLB and Page Faults
Date: Tue, 15 Aug 2023 14:58:33 +0200	[thread overview]
Message-ID: <CACRpkdbZkp5Tx3SXkdmErcbJ1aMB5t5s=MUO1cDnMs=sGu92nQ@mail.gmail.com> (raw)
In-Reply-To: <3179607.5fSG56mABF@suse>

Hi Fabio!

trying to answer these things as best I can!

Notice I'm not natively anglo-saxon either.

It's refreshing to have a discussion about formulations in text
in addition to our everyday technical churn!

On Tue, Aug 15, 2023 at 2:27 PM Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
> On martedì 15 agosto 2023 10:51:24 CEST Linus Walleij wrote:
> > > +Instead, there are also common and expected other causes of page faults.
> > > These
> > The word you are looking for is "Additionally" right?
> >
> > "Additionally, there are..."
>
> I was only able to use "Instead" to express that, contrary to the former
> conditions that is unexpected and uncommon, there are other expected and
> common causes of page faults. I thought that "Instead" stresses that the
> latter causes carry with them opposite and wanted consequences.
>
> I think of "additionally" as a means to introduce less important and less
> frequently occurring conditions.
>
> Nevertheless, I'll change it to "Additionally" as you are asking for.

I think the following is the best:

"There are also other, common and expected causes of page faults".

No bridge words. I can't really explain it, it's just language intuition. :/

An option is to also move the section about the common case section
before the exceptions, which may be more natural to the flow of the text.

> > > +Swapping can't work for memory mapped by kernel logical addresses. These
> > > are a
> > "kernel logical addresses" -> "kernel-internal logical addresses"
>
> My only question is about why you prefer "kernel-internal" to a straight
> "kernel". Can you please say more about this?

It's because the kernel handles many address spaces and is aware about
also the userspace address space and the physical address space.
So just so emphasize which one it is.

Yours,
Linus Walleij


      reply	other threads:[~2023-08-15 12:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-13 18:25 Fabio M. De Francesco
2023-08-15  8:51 ` Linus Walleij
2023-08-15 12:27   ` Fabio M. De Francesco
2023-08-15 12:58     ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbZkp5Tx3SXkdmErcbJ1aMB5t5s=MUO1cDnMs=sGu92nQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox