From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B2CC76196 for ; Tue, 11 Apr 2023 08:57:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 642F6280061; Tue, 11 Apr 2023 04:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F31128005D; Tue, 11 Apr 2023 04:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BA80280061; Tue, 11 Apr 2023 04:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3BFE828005D for ; Tue, 11 Apr 2023 04:57:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06D22A0A70 for ; Tue, 11 Apr 2023 08:57:42 +0000 (UTC) X-FDA: 80668507164.19.0E6D689 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 3BD9C20003 for ; Tue, 11 Apr 2023 08:57:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=n1QnfhAO; spf=pass (imf03.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681203460; a=rsa-sha256; cv=none; b=uh5mkaoZzfxoqQyuwRpyDe2aaSTn829dj4mIbfLYnP7vNy8J8/xAjHQhtktVUmIk8BSq4q 6INrW6vcCLImYosq+goSjAws2JvJuLRTYXkOlKNpXdjn6O8gEeFQJRTMUr7+aIe/b2Pr+h +np2twhOOXcx0wdFFyqaDc5aCkgmzLM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=n1QnfhAO; spf=pass (imf03.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681203460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gdATQ6SYcVmJmouCDRYiMfiaYGt9VMr4r2+RGYSpQ50=; b=LU8dkqdHKoLbcmdwNqOEG+kEUhQCs1zFTftzdTvM6RS/3zjBk8axpwEm5KrLNssWtZVjaS ecMcLV8wN3dJeCwjBmnWNZBnF/AeVcO/owdbDeWcVCJnh/eFSf0EGndEZ4pgnoCZhcX0wP qd4ZsMpGEWgudTZ/nK2bFXUqHnG3MRo= Received: by mail-yb1-f180.google.com with SMTP id i20so10953512ybg.10 for ; Tue, 11 Apr 2023 01:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681203459; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gdATQ6SYcVmJmouCDRYiMfiaYGt9VMr4r2+RGYSpQ50=; b=n1QnfhAOkaZh2YeSwChYZ4fgRwj0FtyFVzAQ9K++nCnadYqTsZxGlIBN2fO9yh2//s dyQgz2YGmkzsryKnloXXWyqsH10ez2tBx2ORDmOWjA0FsNDUVJnbeiq0kTF0DIJUWL6M B/vDrUEIUINtwrk70qD39awc/Icn6I4fy/ihmKUSpC6GEM4hiZn7uQlykcxTpiY3Zg0a bdW14Z+ZT7mxeFjW2egx94p1sdawydoo3MiDabD7pULgaJ3THKyrlPF3+QVxl55HqRyX 83slDYC2Z4psXhdPPiy2SY4dFyo+ld/TjkUYtOa6HkUVuQvVsKXnrDiqB5+ag/YVqSZr HjAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681203459; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gdATQ6SYcVmJmouCDRYiMfiaYGt9VMr4r2+RGYSpQ50=; b=Zbn9roFUB/C0dTb40bDCoUr2iPy0Ar4PcabuF/Ok2biUToMNqJu/iph6YlN99DSwof upAOiVvM8uOvC4rDEYM1XQSKTT3vySNwQrADw0jI/1iheU+SUDuBndz7ZChXmdqmERuG CImWSdKr/nHxYQPScX0Xwt8VO3TQ51/h+kUwwjDV8wqOcdGN3WVsOAeQsSc2GGis366O xVcB1L3rhJswSL7ZUfeEU/2CSfI7Tyn/Mt/Syzf2B9iSzUEOQtPFavi43kExFxy3/tq7 L/q7ISEYPaUwNc+91Dvg1KqzB2nr+5GsYgxWRAX/sNA/d+3OqjXiSO3Wq4iq9wd5yH0A aDxA== X-Gm-Message-State: AAQBX9ctUvI/BXnPuJGyc5Kn7FFNI+sIFUIaepwDXvI+NUQTQXk7JAXm wvH36rI5frWjoa4eQ7BnQtYKusv9Wd7FWfJKB2mbXQ== X-Google-Smtp-Source: AKy350a++3JYl4b5orvykBwgXzpw0u/ViD6Mgu9dnHLpQlskcqGZij1u89TLnLtzeuqNxul39K8znLHp3kO5Fmw4ZlU= X-Received: by 2002:a25:7612:0:b0:b8e:ec30:853e with SMTP id r18-20020a257612000000b00b8eec30853emr3267991ybc.4.1681203459288; Tue, 11 Apr 2023 01:57:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Tue, 11 Apr 2023 10:57:28 +0200 Message-ID: Subject: Re: selftests: gpio: crash on arm64 To: Naresh Kamboju , Bartosz Golaszewski Cc: "open list:GPIO SUBSYSTEM" , Andy Shevchenko , Anders Roxell , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, "open list:KERNEL SELFTEST FRAMEWORK" , linux-mm , Arnd Bergmann , Shuah Khan , Bartosz Golaszewski , Andrew Morton , Pengfei Xu , yi1.lai@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 3BD9C20003 X-Rspamd-Server: rspam01 X-Stat-Signature: frcg845tk69r9hs84gzq1bbh684b3ebm X-HE-Tag: 1681203460-316952 X-HE-Meta: U2FsdGVkX1/YH6NgT1+TBcJ/63Ax1e5tHxsKmknlqy0NQl0P6j0BwlOswBPYtOwWtEy4bI05BkHk52zobidGtKMlEEd4xhsgs37nJp+OIdGIOV/miTyb8VgcsmaBSQ/CDkRcksqN006dYF5j5KXef7061XJ5blkgaR88TOjMyq6JQrZw7QcHRwQONwOmbgG2WhYY5aGeGz+uZ0idcntInFfP+A9vBnuoQusHnbRg9KxCOv977ZKXpxeVYSOedK5opjc5z2i204ffdmsJn4UYzA2eCP7g3At2ju6MwWIzeFBp9ezWkG2CNLOGldDkyBFl0/wSBRmWP81/O55ftKTogK83qsTvUl8luv37BjQF8zzZ6X83T98Siayv70JXbKzWdQ51w22OIPpxVGTvF04nqd+kwdzoRUotJ52rmFlWMVqTkDPcM6++MB3NB6WfpeSNAfGizuYh+pRULftD2SjIwJ7pBqcdaxJkxUVwzAVBMSDzvkKzWxYWnYgL1B7UJmxIQJuj3Ya45e0n3lm0OJ24/aWkZhl1GwrBwCFa9NAuiT872kIj/BKaVwdwDNGNOKUtxmoDMY80V90ugcRBrZuCI+ywYlRj2IFKa2rDmiyZ9Huf1vlbZEPUdR6+5hLBZe0bSeOIWnv/a6XZ6H03cHn8MjQU00pvaAtZiEas3Yzto8pB4Ju60ykLkHbN3JJWBKsjg0fXk2xEkGP/QW8hW79LVzM2rmHElPJ/a0009/3teQvqPcdPHVgpeJMXt5aiUjkdFGe/PI06TH5U7xNjWKG+VV0fOEah/fIMFuWVIirLCOonu7dVdLbgvMNzc5+KeUmBAVNTOGtuwwXbyiDBNlZiE0X4eFUh9NTlKyeYVBiOTguDpTtjPE4imT1RK+pAPMalxWnqiRU1imxUFT5gZ/04mzrbO/seAnxPlbKw5QXWJQUf5yhfq7kZ5dw3gzR20lULtvYqo7TGOcWcWMeaPFS MDlFEE9r R0/9iF2nDX3m0dgtYup0jMwy/IywLKVN47FGPplr93M0ujidWZL6X+8gvbbeLGJsuguzaAvh+g/dxjm6sC7qHe6fzCD7AQXLcIVMD2iM2323x3Q3Njz+HzZq4PD9BRF3aL57DAPlT3EGG1ZQN9Abtf7fDrtSEfHmF1OjKQ6uUV+/lzIVhxGa7w6biPijssaqS8IipmFFNf2Zlr2LOQnmuHL7N4rN01OU8abQJKY9ESU/J33owvGwOfa3lBizyLd8VuRWP2JBL+68D0A83nH+4Qyqn0jiyYncOR7y/U5r/HyqtkuU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 10, 2023 at 11:16=E2=80=AFAM Naresh Kamboju wrote: (...) > Anders performed bisection on this problem. > The bisection have been poing to this commit log, > first bad commit: [24c94060fc9b4e0f19e6e018869db46db21d6bc7] > gpiolib: ensure that fwnode is properly set I don't think this is the real issue. (...) > # 2. Module load error tests > # 2.1 gpio overflow (...) > [ 88.900984] Freed in software_node_release+0xdc/0x108 age=3D34 cpu=3D1= pid=3D683 > [ 88.907899] __kmem_cache_free+0x2a4/0x2e0 > [ 88.912024] kfree+0xc0/0x1a0 > [ 88.915015] software_node_release+0xdc/0x108 > [ 88.919402] kobject_put+0xb0/0x220 > [ 88.922919] software_node_notify_remove+0x98/0xe8 > [ 88.927741] device_del+0x184/0x380 > [ 88.931259] platform_device_del.part.0+0x24/0xa8 > [ 88.935995] platform_device_unregister+0x30/0x50 I think the refcount is wrong on the fwnode. The chip is allocated with devm_gpiochip_add_data() which will not call gpiochip_remove() until all references are removed by calling devm_gpio_chip_release(). Add a pr_info() devm_gpio_chip_release() in drivers/gpio/gpiolib-devres.c and see if the callback is even called. I think this could be the problem: if that isn't cleaned up, there will be dangling references. diff --git a/drivers/gpio/gpiolib-devres.c b/drivers/gpio/gpiolib-devres.c index fe9ce6b19f15..30a0622210d7 100644 --- a/drivers/gpio/gpiolib-devres.c +++ b/drivers/gpio/gpiolib-devres.c @@ -394,6 +394,7 @@ static void devm_gpio_chip_release(void *data) { struct gpio_chip *gc =3D data; + pr_info("GPIOCHIP %s WAS REMOVED BY DEVRES\n", gc->label); gpiochip_remove(gc); } If this isn't working we need to figure out what is holding a reference to the gpiochip. I don't know how the references to the gpiochip fwnode is supposed to drop to zero though? I didn't work with mockup much ... What I could think of is that maybe the mockup driver need a .shutdown() callback to forcibly call gpiochip_remove(), and in that case it should be wrapped in a non-existining devm_gpiochip_remove() since devres is used to register it. Bartosz will know better though! I am pretty sure he has this working flawlessly so the tests must be doing something weird which is leaving references around. Yours, Linus Walleij