From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1758C54E64 for ; Thu, 28 Mar 2024 09:18:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EF3C6B0089; Thu, 28 Mar 2024 05:18:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59E056B008A; Thu, 28 Mar 2024 05:18:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 465786B008C; Thu, 28 Mar 2024 05:18:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 28E776B0089 for ; Thu, 28 Mar 2024 05:18:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A14CE140F5F for ; Thu, 28 Mar 2024 09:18:30 +0000 (UTC) X-FDA: 81945897180.13.11E93A3 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf24.hostedemail.com (Postfix) with ESMTP id 0343018001D for ; Thu, 28 Mar 2024 09:18:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="rhMkT/n+"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf24.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.219.179 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711617509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JdlPi/D8q9gRz0rC7iT/EQjBcreVsogwectsXFf1ljg=; b=HmhW7HSoVCh8O93qs9jK9tNg54G9XaJNm7qsqU8yfq7fRIf6YeDDP8WY7niU7u6zcv6E8i LERlFlKT7gfZO6FbJv/8/NC3m8b0r53shO222GeD5meXuXdFtwiAb7zrJunfODmXTNfJAL MWTp0WR3Y8qd6WQWy2A9y1rRoQU/V/4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="rhMkT/n+"; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf24.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.219.179 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711617509; a=rsa-sha256; cv=none; b=HR6NEU3mZbYRr1wZzRqRFZZt/ZKRbD/REupDVpqOmI5q/s2O77W3375mQ7wdPdtJFpci0d S27s3ZOVA7W/qQiRsQyYZLy4eXLtHPG0eldUdhB3btmVQIjfSob3n0sHZz0eTTnGQtexXM 946Q0fufebK5YGFkEKY5T6yZ061fLBA= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-ddaad2aeab1so651427276.3 for ; Thu, 28 Mar 2024 02:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711617508; x=1712222308; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JdlPi/D8q9gRz0rC7iT/EQjBcreVsogwectsXFf1ljg=; b=rhMkT/n+DdTXWcBc4XR50+hNA/IktXn8sbJoQU/eyH1ovmOMAH/6fJ0ymEU20LwTAv N1yzJJBE0BZ6xn2RWlppe6MgNmG1F9UGHi7bRsS1vE0ziQqzMpsp+hUhmYYo5O2phVE1 bz3V4D/unBksUPxbNepNwtnGzG/1nBm+5AFX4nDf0EdfD82OxJvuHSIGOXEvQLcVBGBA 8s/1Iy5k0wPQg5Q6AovJRx1cyWQxY03sSO2gN+iNAvCSroZ9LolN9UGuLEhn4kN91Kgh KiFv2yb1K7vrHU8valaJ1CeyHcEGlG/2Lu/0Z/Bixar8JY+1pyeMGERVqZqunu4k9fxe dqvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711617508; x=1712222308; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JdlPi/D8q9gRz0rC7iT/EQjBcreVsogwectsXFf1ljg=; b=EvASnvZfUNb7F9SlD3SV7Mp19sOEQh2Iry1n5g6JuSUtQh3NrvzxNOuMAXLnM6myCa vEJWyrYx3hctzkggeMoyJepTZm2ZcpSA1RWiYVf8jjWCJog4pzBmXFkFTYemVFYdns3k XO4bYn/3pBLXliZQZQFRHJK3pT/qJ7xuMMEdhBms1ilLzuxZL4u8/OWMYajmJTSHBCVm qWYd5eYUeBvHt5DLUhzq2L3u1DRwMUhXT2y8fzef0AUl7kEBOBVQa7P5ToMDMOfr4Ma/ N6n0zuwrk+CZDcY2N09AUDPOuseXtpHcgsT0ToMbtThhFQUqgqNZ2nlWV0lAgTPv9b5B pROA== X-Forwarded-Encrypted: i=1; AJvYcCXDYCl7yaadj52WZqRFyfbTE4xnZYE5YTCQ9p+bQWL+8V29EIvWDicE69TWkg7svq526aqfNwKkAqDaHGX8+Mr1ytY= X-Gm-Message-State: AOJu0YwFFamzAZS91qCBDLzgr9wROIpzRy6NBFvGVkazgZkdNAGz4TWo scSZpMyzyV4aYi6JG3SGJKUAm4YOqTUffmeOpYWHV2nGKq9WUZiClsaVVR4wGdnjgfCBkHRzWdf J2PLx2Wsqlw0RrL1hu3Hl79Bpwww7hLqaSucR7Q== X-Google-Smtp-Source: AGHT+IHUYiXsFEyaSrFSbE/Sr9EQQEbq6LIDEHkAK2tUEMiEJLOv+Yp1LaCp4ieBZ7Wds5RI7onQUIkumjvsdiSFxmI= X-Received: by 2002:a25:9091:0:b0:dca:e4fd:b6d6 with SMTP id t17-20020a259091000000b00dcae4fdb6d6mr2028363ybl.61.1711617507999; Thu, 28 Mar 2024 02:18:27 -0700 (PDT) MIME-Version: 1.0 References: <20240326144741.3094687-1-arnd@kernel.org> <20240326144741.3094687-2-arnd@kernel.org> In-Reply-To: <20240326144741.3094687-2-arnd@kernel.org> From: Linus Walleij Date: Thu, 28 Mar 2024 10:18:17 +0100 Message-ID: Subject: Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent To: Arnd Bergmann Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada , Harry Wentland , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jani Nikula , Lucas De Marchi , Oded Gabbay , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jakub Kicinski , Paolo Abeni , Andrew Jeffery , Joel Stanley , Alexei Starovoitov , Daniel Borkmann , Andrew Morton , Nathan Chancellor , Nicolas Schier , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0343018001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5bgrkz8iqken9jo46swknaeee5upifj5 X-HE-Tag: 1711617508-4960 X-HE-Meta: U2FsdGVkX1/msv4kyYT1BwZcdOF8A2UG8kbeDSxCEPAbV2BplK8Hz9+VVxNv/CjEr4wiWaC2VwAScyzAKIyma7a4q/tHj0s7ZKjgIDjSjH/Hyxw4TTi1X7+sv7BpzglBLSO6w9dQy+XZfOORR5UMMg+AYbltKuBGSyLlFX+XeuQMx4KrN2hTm7+ay7xkdwBe3Jtd7oi1I5btdz+xhzotfV2pVwbf19xAeuLkgkLJ3ltsaD9aiBnxJOOsVrxuCeBrGtG2FZviJLDdrVNwyGdVxnL/H2qMUJkvnXVg4kRhZ2GT6vtLhORk8icUoa7FIiFi5F5VSkfRK/6SkZZdj6JaN24i8e0C8lXUYf7gly2/xDyvPHXaOzqNogAXx7xY56N/Y6AU//Z15vstwcKwMQf2X9H1l2+ME6KVypgVoPqDsxfY6N1xxg2osI/ta7bTKInJK2vwGjaAysl9D6ru0GRl+n+n6RyorDOFcGspodPJZHUKw7DSuQf8fl7/YWQvqg/QwpPwA4zz0U3fPJWRzkp9w+zpENbq4IdMGL5tgTDgFB/8giztB2fJ/Q6Sl8D8NXPn/teBl2eH4FZPkER0nU4F/PAJxqpX22UmvWxVLLzy8UvyxVZ3R8XKgh1oHSUzGlUojYAQa5yTCbDga4qfBlUJ8Nplw4Ju2pnXellgKcl2OjAYufO5Hhzn/pSBP7g0j64TJG9Lq3t7UcKk0n5ap3VWzQgSC4+eM6y6oEnyPD0yjj9pcmaievbVtpykl6VkWSl9+4fy+Ysi2Wd/w/YHQadEiYioP+l1/B1E73TkUQg29BthP36WcVWBlGgb5QBdZbaD56UMiVsZB8G7Y7tawiIZPE/CE27e+5hDSWvl57yEf+Ti8tm6PAF1Mjark0EwsJYOq2DXTYdWzjV97tRaohZZq/B4Mq2xPia2Kj6mIb6hhbkEoi1yD6z7WYfdwXUbC3GPvDgkGg5rGdKLudkcro5 JQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 3:49=E2=80=AFPM Arnd Bergmann wro= te: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default > and we have multiple settings in scripts/Makefile.extrawarn as well as > individual subsystems. > > Older versions of clang only supported -Wno-initializer-overrides with > the same meaning as gcc's -Woverride-init, though all supported versions > now work with both. Because of this difference, an earlier cleanup of > mine accidentally turned the clang warning off for W=3D1 builds and only > left it on for W=3D2, while it's still enabled for gcc with W=3D1. > > There is also one driver that only turns the warning off for newer > versions of gcc but not other compilers, and some but not all the > Makefiles still use a cc-disable-warning conditional that is no > longer needed with supported compilers here. > > Address all of the above by removing the special cases for clang > and always turning the warning off unconditionally where it got > in the way, using the syntax that is supported by both compilers. > > Fixes: 2cd3271b7a31 ("kbuild: avoid duplicate warning options") > Signed-off-by: Arnd Bergmann Neat! Reviewed-by: Linus Walleij Yours, Linus Walleij