From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8016CC388F2 for ; Fri, 6 Nov 2020 08:53:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C152720936 for ; Fri, 6 Nov 2020 08:53:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RNzGMDhH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C152720936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D12D66B0068; Fri, 6 Nov 2020 03:53:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC27B6B006C; Fri, 6 Nov 2020 03:53:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB12C6B006E; Fri, 6 Nov 2020 03:53:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 8AF526B0068 for ; Fri, 6 Nov 2020 03:53:42 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1445452DA for ; Fri, 6 Nov 2020 08:53:42 +0000 (UTC) X-FDA: 77453380284.21.board34_38137a2272d1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E59E7180442C2 for ; Fri, 6 Nov 2020 08:53:41 +0000 (UTC) X-HE-Tag: board34_38137a2272d1 X-Filterd-Recvd-Size: 3795 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 08:53:41 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id e27so831613lfn.7 for ; Fri, 06 Nov 2020 00:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4/A6nu8MNcFF5kEXxP7WUxb3KBC2mAt5+C5+mvUuYRQ=; b=RNzGMDhHp73XmjY1Bms/XuoOVUwytmZsV5/QpIu1tAlwCRysXnqw8iuUGIDlQD909j YlSJAVjj0clZQ/UF437CfqodV+VleA7HZp87eC+27a/bYEretbW7CZwA8TpEvQl4CwQM nLSx6a8+iNw1iuWGc9S3puIg1NhO0sEsHlVRKVlESVeFNqcDzsZrbBk6gnERCZ4jWMSe lWV6qpHLVLVBZ6jyw4aHcQYy7wLk884Otvu/hZAEPFqGCxLwk3I+dRAP4GdztiW92GgH gfiWn3/gETymmzhuE07Vm0bIFjGuD539QXAsjcIWO1xcQJTtQJ9QuArTrkcZEmMOz0k9 gRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4/A6nu8MNcFF5kEXxP7WUxb3KBC2mAt5+C5+mvUuYRQ=; b=AzikmuhCPrRKwbdYyW5m2l72zoFvqMqVJRe5quYlL2+SxBz+4hQ+wTKlGA2ILja4M/ dubYgYHBE8T5dXcaC5fefm2FfcbNsC9pK2w2wQTkwyOMmQme1X9kxp3PrB2qugDTNvwv QH1y4W4q5jcgpi8SXkTanBh3AwYmBNZiTrwe+iTIZ6dTW6G0CMQnCX8S/nRnVezqaqxD 2EHmETXvFcrBZfjXC7OAqXu6zh5JIBNTcNOTuf5eQJkUVA4vlvf3QYC2pdIaQ0TtxoFS 9ayvxyZkzoIOKy8yoAihwRZmpX+zTB10xT14nhpphnf+AlSh2/vDMNQeONNQsBxrgAcr iiBg== X-Gm-Message-State: AOAM53145E9e0GRFwOKkQ/k0XgOrGXW8/ml1fuSBL5NGJfvvz565b+a0 uZR6nEcWQDy+m5jxPORykQmrFUmJ3cfDxVCsr0ix0g== X-Google-Smtp-Source: ABdhPJzk8z0AVQI2UcUnBpEmkxDS2x9y2SwwwLCWWRPt0uhFIFFMmSFQQ4j/5nZ/bhymTmdnJLdGgt8uLzebVgr870o= X-Received: by 2002:a19:7b06:: with SMTP id w6mr518836lfc.260.1604652819821; Fri, 06 Nov 2020 00:53:39 -0800 (PST) MIME-Version: 1.0 References: <202011020749.5XQ3Hfzc-lkp@intel.com> In-Reply-To: From: Linus Walleij Date: Fri, 6 Nov 2020 09:53:29 +0100 Message-ID: Subject: Re: [linux-next:master 1570/2472] mm/kasan/init.c:318:9: warning: variable 'pud' set but not used To: Ard Biesheuvel Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Russell King , Abbott Liu , Florian Fainelli , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 3, 2020 at 9:22 AM Ard Biesheuvel wrote: > What about > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index fe6be0be1f76..7c3eb1f5a439 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -315,12 +315,10 @@ static void kasan_free_pmd(pmd_t *pmd_start, pud_t *pud) > > static void kasan_free_pud(pud_t *pud_start, p4d_t *p4d) > { > - pud_t *pud; > int i; > > for (i = 0; i < PTRS_PER_PUD; i++) { > - pud = pud_start + i; > - if (!pud_none(*pud)) > + if (!pud_none(pud_start[i])) > return; > } Yeah that is way better, also makes the code a lot easier to read. I sent a patch rewriting all the kasan_free_p??() calls like this. Yours, Linus Walleij