From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC7FECAAD2 for ; Mon, 29 Aug 2022 21:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEBEA940007; Mon, 29 Aug 2022 17:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B9D6B0075; Mon, 29 Aug 2022 17:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B62DA940007; Mon, 29 Aug 2022 17:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A41256B0074 for ; Mon, 29 Aug 2022 17:04:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 763FC1603FE for ; Mon, 29 Aug 2022 21:04:01 +0000 (UTC) X-FDA: 79853857482.08.1D58874 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf23.hostedemail.com (Postfix) with ESMTP id 18489140046 for ; Mon, 29 Aug 2022 21:04:00 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id z2so11736434edc.1 for ; Mon, 29 Aug 2022 14:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=zOzBDc+ySgJWmv3/SWvrgeYUML404A/WBkOO7QeM0bU=; b=aNvVUOTfJJV7QMCgPkBEf3uI6T5fFIP1NHLs74haOn4Fz8M/1JELdSQrNoYR7qbQRV ZSRWmFQVGWVI4cmw1+zv929F6tS1NpW5bcWF4SNkcj/fjRxbr6norse/BlWzkC6eeDHZ 9dB5baefMmiQxV/teTTu+RsQ9hCZ0VGhuQElYtIEMDA27Oc+uZjLXdRIm0pAaVISQpMJ 4HW4Iu4k6WbuNKKodrxD4R0lpTcWiFCwOoTawfRqtyun1QvDKwyMhK08F1sn5zkhG9KL F8qvUtkZIo7xHtx5GR0OGJL2kupI36bxptUpaDw0MA49CVg8II6SMkkZlKsAE+n/gGt9 Zgjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=zOzBDc+ySgJWmv3/SWvrgeYUML404A/WBkOO7QeM0bU=; b=Qi2asxpJQ44sbtwj48PmJeV3a5BTx6aoOLT5re4xVJ1FAm3+7HTXFBG/yjkHmx8PFm 0vbug3rGaP34ABwnNmaRow/YJuDieBWxZSvAJKb8Tl1xQpj5/BvlNBE/JGTt+ub2ygUd 8YfTVWt2oD9xeqZffVwRkNGVXU6R02Z9XNU7ctqeZFDJOnai5b9Z1pVY9SHN5kYhi3/f TRZXnaO00NXXWxRLwAN2NOvmJZTCtZFD0uNB2AkwSeq89CbCFT8LmnQV35YkmqYDtT48 lDX90MapqrQkyaCiI+oyBHQzty53iejhmYK9FmKgilk9nF45GWwqex04HA2RcploSWop lurQ== X-Gm-Message-State: ACgBeo0BvafKlvfAWMjncEYgG2favqqYFtjrQzI9+jZFsUFPjxSo6KYz osIzQ+/XHewmMhuPLwFAYh805qkKM/BS8Fg9nGaBDw== X-Google-Smtp-Source: AA6agR6YHumaK8Mw85EiR+VezxveiVr+ooRc/cp/dOdvVwQGHKw2HpEO08QvBkxXK/x3WXTLdUf8/wKMI3MFNzLEN0E= X-Received: by 2002:a05:6402:4517:b0:443:7fe1:2d60 with SMTP id ez23-20020a056402451700b004437fe12d60mr18030433edb.133.1661807039676; Mon, 29 Aug 2022 14:03:59 -0700 (PDT) MIME-Version: 1.0 References: <20220829131317.114007-1-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Mon, 29 Aug 2022 23:03:48 +0200 Message-ID: Subject: Re: [PATCH] fs/proc/kcore.c: Pass a pointer to virt_addr_valid() To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=aNvVUOTf; spf=pass (imf23.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661807041; a=rsa-sha256; cv=none; b=avnZpJ5WbFN+w6uml/VqXl+d5X6NWeQBW1dj1dNPoxKza7uYW7envM7msDszYvLVM0WITI OjgMH/nuS31Nx4THSaXcJgScbFVZb5J9fzVVebIeK56G+Sqx+xl5XsvRdvbJ6VCKEVm+jY qdNcr9Tw+jNnRpQOteV/K9ojIPv0o2E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661807041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zOzBDc+ySgJWmv3/SWvrgeYUML404A/WBkOO7QeM0bU=; b=GzXA1dk/Q+GxydUinYA0T6mZMLSkTT/S4t/gAIO5nnWpFfFuyVIZ2c5Vgn9EW6iWZtNRwB yczjfTG4XZFJTv7gBCIsWaSf7c0nrVArYsjvu2oJ4r5IKdG2XVUQaoF8avUOlTzmnzyfxN iPK6afmvuxaLN4Oak7jBr+18pOCPuRo= X-Stat-Signature: miduehdbxonzx9hzbx3cdo36fpt88h7j X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=aNvVUOTf; spf=pass (imf23.hostedemail.com: domain of linus.walleij@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=linus.walleij@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 18489140046 X-HE-Tag: 1661807040-880096 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 5:18 PM Matthew Wilcox wrote: > On Mon, Aug 29, 2022 at 03:13:17PM +0200, Linus Walleij wrote: > > The virt_addr_valid() should be passed a pointer, the current > > code passing a long unsigned int is just exploiting the > > unintentional polymorphism of these calls being implemented > > as preprocessor macros. > > Why do you think it's unintended polymorphism? It looks to me > like polymorphism is absolutely intended. Intended, maybe. Desired, no: https://lore.kernel.org/linux-mm/20220701160004.2ffff4e5ab59a55499f4c736@linux-foundation.org/ Strong typing is nice. Yours, Linus Walleij